valgrind detects uninitialized (but really unused) bytes in 'queue'
authorKen Raeburn <raeburn@mit.edu>
Thu, 1 Mar 2007 02:19:41 +0000 (02:19 +0000)
committerKen Raeburn <raeburn@mit.edu>
Thu, 1 Mar 2007 02:19:41 +0000 (02:19 +0000)
commitbb351b78a590a4a94c1e76bd0809d0961832c072
treee6a4a670bd69882f6fc7b1e3f1430a002ea501d7
parent36ff243effef4c41f5a2220b9a0fb8c16ecd5e8c
valgrind detects uninitialized (but really unused) bytes in 'queue'

The gsstest program exports a GSSAPI security context to a blob in
memory, writes that memory to a file, and reads it back to use it.
Under valgrind, the writing phase triggers a warning about
uninitialized storage.

The "queue" structure as implemented in generic/util_ordering.c holds
an array of values, some of which may never be initialized.  As far as
I can tell, those uninitialized values are never used before being
initialized, either, but valgrind doesn't know that.

This patch zaps the structure contents (including the array) before
using the queue object.

ticket: new
target_version: 1.6.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19196 dc483132-0cff-0310-8789-dd5450dbe970
src/lib/gssapi/generic/util_ordering.c