--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id ADF78431FBD\r
+ for <notmuch@notmuchmail.org>; Sun, 20 Jan 2013 14:55:40 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id JBKbOlVeqzvr for <notmuch@notmuchmail.org>;\r
+ Sun, 20 Jan 2013 14:55:39 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0C726431FB6\r
+ for <notmuch@notmuchmail.org>; Sun, 20 Jan 2013 14:55:39 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 530BA100086;\r
+ Mon, 21 Jan 2013 00:55:28 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>, david@tethera.net,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 5/7] CLI: add --leak-report top level option\r
+In-Reply-To: <87d2wzwmd9.fsf@servo.finestructure.net>\r
+References: <1358619958-21209-1-git-send-email-david@tethera.net>\r
+ <1358619958-21209-6-git-send-email-david@tethera.net>\r
+ <87d2wzwmd9.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.15+5~g6f527c2 (http://notmuchmail.org) Emacs/24.2.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 21 Jan 2013 00:55:28 +0200\r
+Message-ID: <m2ip6ro467.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 20 Jan 2013 22:55:40 -0000\r
+\r
+On Sun, Jan 20 2013, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+\r
+> On Sat, Jan 19 2013, david@tethera.net wrote:\r
+>> This roughly mimics the samba4 argument. The presence of the command\r
+>> line argument overrides any value of NOTMUCH_TALLOC_REPORT in the\r
+>> environment.\r
+>> ---\r
+>> man/man1/notmuch.1 | 8 ++++++++\r
+>> notmuch.c | 18 +++++++-----------\r
+>> 2 files changed, 15 insertions(+), 11 deletions(-)\r
+>>\r
+>> diff --git a/man/man1/notmuch.1 b/man/man1/notmuch.1\r
+>> index 6bf9b2e..5c58c41 100644\r
+>> --- a/man/man1/notmuch.1\r
+>> +++ b/man/man1/notmuch.1\r
+>> @@ -70,6 +70,14 @@ Print a synopsis of available commands and exit.\r
+>> Print the installed version of notmuch, and exit.\r
+>> .RE\r
+>> \r
+>> +.RS 4\r
+>> +.TP 4\r
+>> +.BI \-\-leak-report= path\r
+>> +\r
+>> +Write a detailed report of all memory allocated via talloc to\r
+>> +.I path\r
+>> +.RE\r
+>\r
+> Do we really need a command line option for this? Why isn't the env var\r
+> sufficient? This just seems to me like it clutters the interface, for\r
+> an option that is purely for debugging and should rarely if ever be used\r
+> by most users.\r
+\r
+Jameson does have a point. Now that we already have that environment\r
+variable and it can be used in shipped notmuch 0.15 it is perhaps\r
+simplest just to stick with that.\r
+\r
+My thoughts after brief first visit to the patche series has so far\r
+being either make the command line usage 1:1 compatible with samba\r
+or use option like --leak-report-output=..., --leak-report-file=... or\r
+--leak-report-to=... (and attempt to deprecate the env var...)\r
+\r
+That said, I withdraw my previous suggestion of the command line option...\r
+\r
+The other changes in this patch series looks initially good -- and changes\r
+that drop deprecated features should be get in as early after last release\r
+as possible.\r
+\r
+> jamie.\r
+\r
+\r
+Tomi\r
projects / notmuch-archives.git / blobdiff