1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id AA870431FD0
\r
6 for <notmuch@notmuchmail.org>; Sat, 24 Dec 2011 00:06:14 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id VNsoOgZIIwND for <notmuch@notmuchmail.org>;
\r
17 Sat, 24 Dec 2011 00:06:14 -0800 (PST)
\r
18 Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com
\r
19 [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
20 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
21 E0607431FB6 for <notmuch@notmuchmail.org>; Sat, 24 Dec 2011 00:06:13 -0800
\r
23 Received: by wgbdt12 with SMTP id dt12so13256552wgb.2
\r
24 for <notmuch@notmuchmail.org>; Sat, 24 Dec 2011 00:06:12 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=NV9ntzrCKJvfKwMtLtbZhfEDliI8VCJ3ZzHkxsQn1K8=;
\r
29 b=qu/orSRT0AW+s11fK2HWEljBYL5nvEdyo8r1bANnDV/l9CqJ+g6ieEiiEIstTI6oWg
\r
30 OL7PqsY3J36AtFEYJjY/zzOC/yaIVpcrKEGmjARLvQCMrB98KuYWE94lpfREJONv9f1V
\r
31 gplhJAs7GQpQ1FNRubdSerhEAosnHGiCY+HDA=
\r
32 Received: by 10.216.139.91 with SMTP id b69mr7818557wej.51.1324713966483;
\r
33 Sat, 24 Dec 2011 00:06:06 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id 1sm38306320wiz.11.2011.12.24.00.06.04
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sat, 24 Dec 2011 00:06:05 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
40 Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME
\r
43 In-Reply-To: <87y5u2jte1.fsf@servo.finestructure.net>
\r
44 References: <1323460468-4030-1-git-send-email-amdragon@mit.edu>
\r
45 <1324698348-27620-1-git-send-email-amdragon@mit.edu>
\r
46 <1324698348-27620-3-git-send-email-amdragon@mit.edu>
\r
47 <87y5u2jte1.fsf@servo.finestructure.net>
\r
48 User-Agent: Notmuch/0.10.2+116~g4c449d4 (http://notmuchmail.org) Emacs/23.3.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Sat, 24 Dec 2011 12:05:21 +0400
\r
51 Message-ID: <87wr9mjsxq.fsf@gmail.com>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Sat, 24 Dec 2011 08:06:14 -0000
\r
68 On Fri, 23 Dec 2011 23:55:34 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
69 > On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
70 > > + /* True if decryption of this part was attempted. */
\r
71 > > + notmuch_bool_t decrypt_attempted;
\r
72 > > + /* True if decryption of this part's child succeeded. In this
\r
73 > > + * case, the decrypted part is substituted for the second child of
\r
74 > > + * this part (which would usually be the encrypted data). */
\r
75 > > + notmuch_bool_t decrypt_success;
\r
77 > > + /* True if signature verification on this part was attempted. */
\r
78 > > + notmuch_bool_t sig_attempted;
\r
80 > I think these new variables make sense, and reflect the correct
\r
81 > semantics, as you already mentioned.
\r
83 > I do, however, think the later variable should be called
\r
84 > "verify_attempted" (or "verification_", or "ver_"?), instead of
\r
85 > "sig_attempted", since verification is the complementary action on a
\r
86 > signed part, just as decryption is for an encrypted one.
\r
87 > "sig_attempted" somehow implies to me that one is trying to make a
\r
88 > signature, not verify an existing one.
\r
91 I agree, verify_attempted seems to be consistent with decrypt_attempted.
\r
92 Please, do not make it "ver_", it is easy associated with version.
\r
94 I guess I prefer long clear names in general, do not mind pushing few
\r
101 > _______________________________________________
\r
102 > notmuch mailing list
\r
103 > notmuch@notmuchmail.org
\r
104 > http://notmuchmail.org/mailman/listinfo/notmuch
\r