1 Return-Path: <doctormo@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id F32AE429E21
\r
6 for <notmuch@notmuchmail.org>; Sun, 11 Sep 2011 18:03:44 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id X3SGUgWbRGfF for <notmuch@notmuchmail.org>;
\r
17 Sun, 11 Sep 2011 18:03:44 -0700 (PDT)
\r
18 Received: from mail-yx0-f181.google.com (mail-yx0-f181.google.com
\r
19 [209.85.213.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 87507431FB6
\r
22 for <notmuch@notmuchmail.org>; Sun, 11 Sep 2011 18:03:44 -0700 (PDT)
\r
23 Received: by yxk30 with SMTP id 30so2378678yxk.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 11 Sep 2011 18:03:43 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=subject:from:to:cc:in-reply-to:references:content-type:date
\r
27 :message-id:mime-version:x-mailer:content-transfer-encoding;
\r
28 bh=q4OoP+EE9J39d2nZMnSReFIuNsd0Bvi5PZJCaJUZdSg=;
\r
29 b=K8zdjVW3/w+MJ9cQCQxw8CLFTOXwy0hi1bCdZ9OtYTSRwGJT0IccAuMdPEixOxEMy9
\r
30 DA9W0JYG4nmIOTxu9eIe3/MvHaYmnRwvo7yhwFsICf/tWfapsRhKfPZRE1tjgcQBG85B
\r
31 8GHwpM89goAUKts8CQtX+PPc8mN6H3Md9ftm4=
\r
32 Received: by 10.150.212.12 with SMTP id k12mr3645970ybg.413.1315789423047;
\r
33 Sun, 11 Sep 2011 18:03:43 -0700 (PDT)
\r
34 Received: from [192.168.5.100] (mcd2436d0.tmodns.net [208.54.36.205])
\r
35 by mx.google.com with ESMTPS id o39sm12342663ani.17.2011.09.11.18.03.37
\r
36 (version=SSLv3 cipher=OTHER); Sun, 11 Sep 2011 18:03:41 -0700 (PDT)
\r
37 Subject: Re: Patch: Flush and Reopen
\r
38 From: Martin Owens <doctormo@gmail.com>
\r
39 To: Austin Clements <amdragon@MIT.EDU>
\r
40 In-Reply-To: <20110912002327.GC23603@mit.edu>
\r
41 References: <1315445674.32058.183.camel@delen>
\r
42 <CAH-f9WtuYYuksfTHL1ZMmoRF6kyL7iFu9BXDzGn-wWGniSvf9w@mail.gmail.com>
\r
43 <1315536861.2435.34.camel@delen> <87obyuj7q1.fsf@zancas.localnet>
\r
44 <1315590950.2435.59.camel@delen>
\r
45 <CAH-f9WtuL48RtaJ9njxHyCy5cqhhrxdz+30ydE11rq41Lu06pA@mail.gmail.com>
\r
46 <1315615433.2435.62.camel@delen> <20110912002327.GC23603@mit.edu>
\r
47 Content-Type: text/plain; charset="UTF-8"
\r
48 Date: Sun, 11 Sep 2011 21:03:23 -0400
\r
49 Message-ID: <1315789403.2435.74.camel@delen>
\r
51 X-Mailer: Evolution 2.30.3
\r
52 Content-Transfer-Encoding: 7bit
\r
53 Cc: Notmuch developer list <notmuch@notmuchmail.org>
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Mon, 12 Sep 2011 01:03:45 -0000
\r
68 On Sun, 2011-09-11 at 20:23 -0400, Austin Clements wrote:
\r
69 > BTW, in the future, you should send patches inline (see the patch
\r
70 > formatting guide I linked to earlier for easy ways to do this). It
\r
71 > makes them much easier to review and reply to.
\r
73 I tried to do this, my email client doesn't allow this sort of mucking
\r
74 about. sorry guys bare with the patch file.
\r
76 > I assume you've tested it?
\r
78 Absolutely, I have my testing framework and it would fail quite badly if
\r
79 either flush or reopen failed to work in either py binding or lib.
\r
81 > Notmuch is quite consistent about indentation, though the rule may not
\r
82 > be something you'd expect coming from Python. It uses four space
\r
83 > indentation, but each group of eight spaces is replaced with a tab, so
\r
86 I see, I'm going to forgo the rage and just do it.
\r
88 > Even if you found the above two changes necessary, they shouldn't be
\r
89 > included in this patch because they aren't related to reopen/flush.
\r
91 There were intended to be removed. Should be gone now.
\r
93 > Both catch blocks should set notmuch->exception_reported = TRUE;
\r
94 > (notmuch_database_close happens to be the one exception to this since
\r
95 > it's closing the database; see other catch blocks in lib/database.cc).
\r
99 > The catch block in notmuch_database_flush shouldn't appear as changed
\r
100 > in the diff; you should leave the spacing the way it originally was.
\r
102 The spacing is mostly the same now, I removed a word from the error
\r
103 message deliberately before I noticed it was in the original text. But
\r
104 it shouldn't be too important.
\r
106 Regards, Martin Owens
\r