1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 16A8B431FD0
\r
6 for <notmuch@notmuchmail.org>; Thu, 12 May 2011 07:09:17 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id PR76l8IfmIRs for <notmuch@notmuchmail.org>;
\r
16 Thu, 12 May 2011 07:09:13 -0700 (PDT)
\r
17 Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 4718E431FB6
\r
21 for <notmuch@notmuchmail.org>; Thu, 12 May 2011 07:09:13 -0700 (PDT)
\r
22 Received: by wyi11 with SMTP id 11so1308579wyi.26
\r
23 for <notmuch@notmuchmail.org>; Thu, 12 May 2011 07:09:11 -0700 (PDT)
\r
24 Received: by 10.216.71.136 with SMTP id r8mr1985690wed.0.1305209351804;
\r
25 Thu, 12 May 2011 07:09:11 -0700 (PDT)
\r
26 Received: from localhost (188.152-240-81.adsl-dyn.isp.belgacom.be
\r
28 by mx.google.com with ESMTPS id l24sm764619wbc.64.2011.05.12.07.09.10
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Thu, 12 May 2011 07:09:10 -0700 (PDT)
\r
31 From: Pieter Praet <pieter@praet.org>
\r
32 To: Austin Clements <amdragon@mit.edu>
\r
33 Subject: Re: release-candidate/0.6
\r
34 In-Reply-To: <BANLkTi=iz6F+1-WQ5KDno6N-MF=dQeTbEA@mail.gmail.com>
\r
35 References: <8762pn7gth.fsf@servo.factory.finestructure.net>
\r
36 <87iptkfzwx.fsf@servo.factory.finestructure.net>
\r
37 <877h9zokod.fsf@servo.factory.finestructure.net>
\r
38 <878vuencm5.fsf@servo.factory.finestructure.net>
\r
39 <878vuejym8.fsf@servo.factory.finestructure.net>
\r
40 <87wrhw2jmm.fsf@praet.org>
\r
41 <BANLkTi=iz6F+1-WQ5KDno6N-MF=dQeTbEA@mail.gmail.com>
\r
42 User-Agent: Notmuch/0.5-221-ga19d81a (http://notmuchmail.org) Emacs/23.1.50.1
\r
43 (x86_64-pc-linux-gnu)
\r
44 Date: Thu, 12 May 2011 16:09:08 +0200
\r
45 Message-ID: <87zkms80zf.fsf@praet.org>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Thu, 12 May 2011 14:09:17 -0000
\r
63 On Thu, 12 May 2011 09:18:48 -0400, Austin Clements <amdragon@mit.edu> wrote:
\r
64 > On Thu, May 12, 2011 at 8:22 AM, Pieter Praet <pieter@praet.org> wrote:
\r
65 > > The atomicity tests were failing here because I didn't have GDB
\r
66 > > installed, so I've added it as a prereq.
\r
68 > Sorry, I've had a patch to address that sitting around, but hadn't
\r
69 > sent it out (and I only fixed that one test). I would suggest a
\r
70 > somewhat gentler approach than "error", though:
\r
72 > if test_expect_success "prereq: gdb is present" "which gdb"; then
\r
73 > test_set_prereq GDB
\r
76 > (Plus the two test-lib patches I just sent:
\r
77 > id:1305206080-17461-1-git-send-email-amdragon@mit.edu and
\r
78 > id:1305206110-17511-1-git-send-email-amdragon@mit.edu).
\r
80 > "error" has the disadvantage that it doesn't get counted as a failed
\r
81 > test in the final tally (because, indeed, it's not a failed test) and
\r
82 > also that it immediately terminates the test script so it's not
\r
83 > actually using the prereq system (which is fine for the atomicity test
\r
84 > since all of the test cases depend on GDB, but the pattern I'm
\r
85 > proposing works for finer-grained prerequisites). Plus, with the
\r
86 > above approach, if you don't have a prerequisite, the final tally
\r
87 > shows one failed test plus some number of skipped tests (and the total
\r
88 > number of tests never changes), which I would argue is cleaner.
\r
90 Much obliged for the correction!
\r
96 [0] git://github.com/praet/notmuch.git
\r
97 for-review/test-prereqs-v2
\r