1 Return-Path: <wiz@danbala.ifoer.tuwien.ac.at>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 60944431FC0
\r
6 for <notmuch@notmuchmail.org>; Sat, 4 Jan 2014 14:37:59 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 5NR1jNTL64Cd for <notmuch@notmuchmail.org>;
\r
16 Sat, 4 Jan 2014 14:37:48 -0800 (PST)
\r
17 Received: from danbala.ifoer.tuwien.ac.at (danbala.ifoer.tuwien.ac.at
\r
19 by olra.theworths.org (Postfix) with ESMTP id 79742431FBD
\r
20 for <notmuch@notmuchmail.org>; Sat, 4 Jan 2014 14:37:48 -0800 (PST)
\r
21 Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116)
\r
22 id E7E2D390DA4; Sat, 4 Jan 2014 23:37:42 +0100 (CET)
\r
23 Date: Sat, 4 Jan 2014 23:37:42 +0100
\r
24 From: Thomas Klausner <tk@giga.or.at>
\r
25 To: David Bremner <david@tethera.net>
\r
26 Subject: Re: notmuch-0.16: realpath() compatibility issue; clang visibility
\r
28 Message-ID: <20140104223742.GC16514@danbala.tuwien.ac.at>
\r
29 References: <20140103214735.GG27614@danbala.tuwien.ac.at>
\r
30 <sfid-H20140104-145824-+018.98-1@spamfilter.osbf.lua>
\r
31 <871u0nnaw8.fsf@zancas.localnet>
\r
33 Content-Type: text/plain; charset=us-ascii
\r
34 Content-Disposition: inline
\r
35 In-Reply-To: <871u0nnaw8.fsf@zancas.localnet>
\r
36 Cc: notmuch@notmuchmail.org
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Sat, 04 Jan 2014 22:37:59 -0000
\r
51 On Sat, Jan 04, 2014 at 09:18:15AM -0400, David Bremner wrote:
\r
52 > Thomas Klausner <tk@giga.or.at> writes:
\r
55 > > ./lib/notmuch-private.h:52:13: note: previous attribute is here
\r
56 > > #pragma GCC visibility push(hidden)
\r
59 > The clang related issues might be fixed in 0.17; can you try that (or
\r
62 Yes, 0.17 fixed that problem.
\r
65 > > - char *data, *filename;
\r
66 > > + char *data, filename[MAXPATHLEN];
\r
67 > > GError *error = NULL;
\r
69 > I'm not sure what the right answer is here. MATHPATHLEN (and PATH_MAX)
\r
70 > are not necessarily defined; in particular this would break
\r
71 > compilation on GNU Hurd. Perhaps we should ship a compatibility
\r
72 > implementation of a POSIX.1-2008 compatible [1] realpath. Or maybe
\r
73 > realpath can be avoided completely here.
\r
75 A compatibility implementation for POSIX.1-2008-realpath would be
\r
76 great, as would be avoiding the call. Why is it necessary to resolve
\r
79 > > + strcpy(filename, config->filename);
\r
81 > Any reason not to use strncpy here?
\r
83 You're right, that'd be better here.
\r
85 > Of course bug reports and fixes in any form are always welcome, but even
\r
86 > more appreciated if they roughly follow [2]; mainly patches from git
\r
87 > with sensible commit messages, and some minor coding style issues.
\r
89 Thanks for the comments,
\r