1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1E07E431FBC
\r
6 for <notmuch@notmuchmail.org>; Mon, 15 Feb 2010 02:03:54 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.028 tagged_above=-999 required=5 tests=[AWL=0.571,
\r
12 BAYES_00=-2.599] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 8KEGJnEtqq9Z for <notmuch@notmuchmail.org>;
\r
16 Mon, 15 Feb 2010 02:03:52 -0800 (PST)
\r
17 Received: from mail-fx0-f224.google.com (mail-fx0-f224.google.com
\r
19 by olra.theworths.org (Postfix) with ESMTP id 48D16431FAE
\r
20 for <notmuch@notmuchmail.org>; Mon, 15 Feb 2010 02:03:52 -0800 (PST)
\r
21 Received: by fxm24 with SMTP id 24so5639353fxm.0
\r
22 for <notmuch@notmuchmail.org>; Mon, 15 Feb 2010 02:03:51 -0800 (PST)
\r
23 Received: by 10.87.62.1 with SMTP id p1mr8530507fgk.42.1266228231242;
\r
24 Mon, 15 Feb 2010 02:03:51 -0800 (PST)
\r
25 Received: from aw.hh.sledj.net (host83-217-165-81.dsl.vispa.com
\r
27 by mx.google.com with ESMTPS id 16sm2924241fxm.0.2010.02.15.02.03.50
\r
28 (version=TLSv1/SSLv3 cipher=RC4-MD5);
\r
29 Mon, 15 Feb 2010 02:03:50 -0800 (PST)
\r
30 Received: by aw.hh.sledj.net (Postfix, from userid 1000)
\r
31 id 9A9D33A018; Mon, 15 Feb 2010 10:03:32 +0000 (GMT)
\r
32 To: notmuch@notmuchmail.org
\r
33 In-Reply-To: <1266226909-19360-1-git-send-email-dme@dme.org>
\r
34 References: <1266226909-19360-1-git-send-email-dme@dme.org>
\r
35 From: David Edmondson <dme@dme.org>
\r
36 Date: Mon, 15 Feb 2010 10:03:32 +0000
\r
37 Message-ID: <873a12hl3f.fsf@aw.hh.sledj.net>
\r
39 Content-Type: text/plain; charset=us-ascii
\r
40 Subject: Re: [notmuch] [PATCH] notmuch.el: Colour cited regions and
\r
41 signatures with message-cited-text-face.
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Mon, 15 Feb 2010 10:03:54 -0000
\r
56 This version is over-eager in marking (non-)signatures. The second call
\r
57 to 'overlay-put' needs to move inside the 'if' a line below.
\r
59 On Mon, 15 Feb 2010 09:41:49 +0000, David Edmondson <dme@dme.org> wrote:
\r
62 > 1 files changed, 2 insertions(+), 0 deletions(-)
\r
64 > diff --git a/notmuch.el b/notmuch.el
\r
65 > index 8090b2f..3e8e50d 100644
\r
68 > @@ -703,6 +703,7 @@ is what to put on the button."
\r
69 > (let* ((cite-start (match-beginning 0))
\r
70 > (cite-end (match-end 0))
\r
71 > (cite-lines (count-lines cite-start cite-end)))
\r
72 > + (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text-face)
\r
73 > (when (> cite-lines (1+ notmuch-show-citation-lines-prefix))
\r
74 > (goto-char cite-start)
\r
75 > (forward-line notmuch-show-citation-lines-prefix)
\r
76 > @@ -718,6 +719,7 @@ is what to put on the button."
\r
77 > (let* ((sig-start (match-beginning 0))
\r
78 > (sig-end (match-end 0))
\r
79 > (sig-lines (1- (count-lines sig-start end))))
\r
80 > + (overlay-put (make-overlay sig-start end) 'face 'message-cited-text-face)
\r
81 > (if (<= sig-lines notmuch-show-signature-lines-max)
\r
82 > (notmuch-show-region-to-button
\r
90 David Edmondson, http://dme.org
\r