1 Return-Path: <mh@glandium.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2FCD0431FBF
\r
6 for <notmuch@notmuchmail.org>; Fri, 20 Nov 2009 13:06:37 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id Zp3kZn4AsdNM for <notmuch@notmuchmail.org>;
\r
11 Fri, 20 Nov 2009 13:06:36 -0800 (PST)
\r
12 Received: from vuizook.err.no (vuizook.err.no [85.19.221.46])
\r
13 by olra.theworths.org (Postfix) with ESMTP id 75632431FBC
\r
14 for <notmuch@notmuchmail.org>; Fri, 20 Nov 2009 13:06:36 -0800 (PST)
\r
15 Received: from cha92-13-88-165-248-19.fbx.proxad.net ([88.165.248.19]
\r
17 by vuizook.err.no with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
\r
18 (Exim 4.69) (envelope-from <mh@glandium.org>)
\r
19 id 1NBagZ-0007TC-JH; Fri, 20 Nov 2009 22:06:34 +0100
\r
20 Received: from mh by jigen with local (Exim 4.69) (envelope-from <mh@jigen>)
\r
21 id 1NBag0-0006is-OP; Fri, 20 Nov 2009 22:05:56 +0100
\r
22 Date: Fri, 20 Nov 2009 22:05:56 +0100
\r
23 From: Mike Hommey <mh+notmuch@glandium.org>
\r
24 To: Carl Worth <cworth@cworth.org>
\r
25 Message-ID: <20091120210556.GA25421@glandium.org>
\r
26 References: <20091120132625.GA19246@glandium.org>
\r
27 <87y6m0lxym.fsf@yoom.home.cworth.org>
\r
29 Content-Type: text/plain; charset=us-ascii
\r
30 Content-Disposition: inline
\r
31 In-Reply-To: <87y6m0lxym.fsf@yoom.home.cworth.org>
\r
32 X-GPG-Fingerprint: A479 A824 265C B2A5 FC54 8D1E DE4B DA2C 54FD 2A58
\r
33 User-Agent: Mutt/1.5.20 (2009-06-14)
\r
34 Cc: notmuch@notmuchmail.org
\r
35 Subject: Re: [notmuch] Segfault with weird Message-ID
\r
36 X-BeenThere: notmuch@notmuchmail.org
\r
37 X-Mailman-Version: 2.1.12
\r
39 List-Id: "Use and development of the notmuch mail system."
\r
40 <notmuch.notmuchmail.org>
\r
41 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
43 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
44 List-Post: <mailto:notmuch@notmuchmail.org>
\r
45 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
46 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
48 X-List-Received-Date: Fri, 20 Nov 2009 21:06:37 -0000
\r
50 On Fri, Nov 20, 2009 at 09:53:37PM +0100, Carl Worth wrote:
\r
51 > On Fri, 20 Nov 2009 14:26:25 +0100, Mike Hommey <mh+notmuch@glandium.org> wrote:
\r
52 > > - for some reason, xapian doesn't want to add the document corresponding
\r
53 > > to this old spam message: notmuch->xapian_db->add_document throws an
\r
56 > I think things had just gone wrong long before then.
\r
58 I *did* see it throwing an exception from there. The sad thing is that I
\r
59 can't reproduce the problem anymore :-/
\r
61 > > I can provide the spam if necessary, or can continue debugging the issue
\r
62 > > with some guidance.
\r
64 > Thanks for providing it. It turns out that the giant Message-Id value
\r
65 > wasn't causing the problem. Instead the message was corrupt by having a
\r
66 > stray new line at the third line. (So GMime is seeing only the first two
\r
67 > lines of headers). We *used* to have working code to detect this kind of
\r
68 > file as "not an email" but again, this broke when we changed
\r
69 > notmuch_message_get_header to return "" instead of NULL for missing
\r
72 Interestingly, when I first traced on what message the crash was
\r
73 happening, I did see notmuch having the message-id in the message_id
\r
76 FWIW, that was using c05c3f1.
\r
78 I'll see if I can reproduce my segfault again when starting from scratch
\r
79 again, and will also give a try to your patches.
\r