fb/c5bc4637a0aae4420a546d7e6f5b62d5395966

   1 Return-Path: <amthrax@drake.mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id AF94A431FAF\r
   6         for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 16:40:18 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id xJ1ePPP2Y39a for <notmuch@notmuchmail.org>;\r
  16         Wed, 18 Jan 2012 16:40:18 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
  18         [18.9.25.14])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 144F2431FAE\r
  20         for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 16:40:17 -0800 (PST)\r
  21 X-AuditID: 1209190e-b7f7c6d0000008c3-b1-4f1766719e90\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 04.6B.02243.176671F4; Wed, 18 Jan 2012 19:40:17 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q0J0eGi5014925\r
  27         for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 19:40:17 -0500\r
  28 Received: from drake.mit.edu\r
  29         (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com\r
  30         [209.6.116.242]) (authenticated bits=0)\r
  31         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  32         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0J0eEH8016733\r
  33         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT)\r
  34         for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 19:40:16 -0500 (EST)\r
  35 Received: from amthrax by drake.mit.edu with local (Exim 4.77)\r
  36         (envelope-from <amthrax@drake.mit.edu>) id 1Rng34-0004Yj-Mx\r
  37         for notmuch@notmuchmail.org; Wed, 18 Jan 2012 19:40:14 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: notmuch@notmuchmail.org\r
  40 Subject: [PATCH 0/2] Fix or silence "unused result" warnings\r
  41 Date: Wed, 18 Jan 2012 19:40:09 -0500\r
  42 Message-Id: <1326933611-16898-1-git-send-email-amdragon@mit.edu>\r
  43 X-Mailer: git-send-email 1.7.7.3\r
  44 X-Brightmail-Tracker:\r
  45  H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsUixCmqrVuYJu5vsOelkMX1mzOZHRg9nq26\r
  46         xRzAGMVlk5Kak1mWWqRvl8CV8WnfHJaCuawVh6f/Zm5gXMLSxcjJISFgInGnbymULSZx4d56\r
  47         ti5GLg4hgX2MEmcOdzJBOOcYJV6+a2eGcP4ySZzf/Roqs5dR4nzbY0aQfjYBDYlt+5eD2SIC\r
  48         0hI7785mBbGFBWwk5lx9xQZiswioSvy7u4gJxOYVcJBYe+IQ1G4FiXOrz7FPYORZwMiwilE2\r
  49         JbdKNzcxM6c4NVm3ODkxLy+1SNdYLzezRC81pXQTI9jjknw7GL8eVDrEKMDBqMTDGyEi7i/E\r
  50         mlhWXJl7iFGSg0lJlPdRKlCILyk/pTIjsTgjvqg0J7X4EKMEB7OSCO9OE6Acb0piZVVqUT5M\r
  51         SpqDRUmcV03rnZ+QQHpiSWp2ampBahFMVoaDQ0mC1xBkqGBRanpqRVpmTglCmomDE2Q4D9Dw\r
  52         MJAa3uKCxNzizHSI/ClGRSlx3u0gCQGQREZpHlwvLCJfMYoDvSLMGw1SxQOMZrjuV0CDmYAG\r
  53         ezSJgQwuSURISTUwLhdXXR5alP1zWvCVSc9Tps263rJawuDQsxvTpoZuFzss/ch2484tf81j\r
  54         WX645dVe2Nofs6ufcWOsQ4X+O3HVxBcPvHnWbPi782eYNgdjSumCye3pe773LvsvEru8+Kxn\r
  55         504Buenfdh9i+pi+4hHnM8UF02dFf3A8d2XfDYsnGl+35ybUT1yxd5MSS3FGoqEWc1FxIgDz\r
  56         aqBKowIAAA==\r
  57 X-BeenThere: notmuch@notmuchmail.org\r
  58 X-Mailman-Version: 2.1.13\r
  59 Precedence: list\r
  60 List-Id: "Use and development of the notmuch mail system."\r
  61         <notmuch.notmuchmail.org>\r
  62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  63         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  65 List-Post: <mailto:notmuch@notmuchmail.org>\r
  66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  68         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  69 X-List-Received-Date: Thu, 19 Jan 2012 00:40:18 -0000\r
  70 \r
  71 I'm afraid I bikeshedded dme's original patch for this into oblivion\r
  72 (id:"1324503532-5799-1-git-send-email-dme@dme.org") and we still have\r
  73 these warnings on the buildbot.  Tomi convinced me that dme was right\r
  74 and I was wrong, so I'm bringing dme's patch back.\r
  75 \r
  76 The first patch actually fixes the warning, since the code in show was\r
  77 wantonly ignoring errors that could have correctness implications.\r
  78 This write didn't get much attention in the original thread.\r
  79 \r
  80 The second is a rework of dme's patch to silence the warning for the\r
  81 remaining writes.  I cleaned up the formatting, simplified the macro\r
  82 magic a little, and added a comment justifying its use.\r
  83 \r