1 Return-Path: <wking@tremily.us>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DDA28431FBC
\r
6 for <notmuch@notmuchmail.org>; Thu, 2 Oct 2014 13:48:09 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id K6go61IK3hVm for <notmuch@notmuchmail.org>;
\r
17 Thu, 2 Oct 2014 13:48:03 -0700 (PDT)
\r
18 Received: from resqmta-po-11v.sys.comcast.net (resqmta-po-11v.sys.comcast.net
\r
20 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 1FCD5431FB6
\r
23 for <notmuch@notmuchmail.org>; Thu, 2 Oct 2014 13:48:03 -0700 (PDT)
\r
24 Received: from resomta-po-06v.sys.comcast.net ([96.114.154.230])
\r
25 by resqmta-po-11v.sys.comcast.net with comcast
\r
26 id yLo11o0044yXVJQ01Lo2MQ; Thu, 02 Oct 2014 20:48:02 +0000
\r
27 Received: from odin.tremily.us ([24.18.63.50])
\r
28 by resomta-po-06v.sys.comcast.net with comcast
\r
29 id yLo11o00G152l3L01Lo1iB; Thu, 02 Oct 2014 20:48:02 +0000
\r
30 Received: by odin.tremily.us (Postfix, from userid 1000)
\r
31 id 08EA713E90B1; Thu, 2 Oct 2014 13:48:00 -0700 (PDT)
\r
32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin;
\r
33 t=1412282881; bh=JMrnrfEIPqdohdSi37USN2exKMdWNWjqYfAyG+7MadM=;
\r
34 h=Date:From:To:Cc:Subject:References:In-Reply-To;
\r
35 b=n8+r4Q0XYEwZWpAfut/B+6lHDGM30modf/L6IzolAVXh9PcHi5oj/10g930KVzX6D
\r
36 KMPaX3KqMeF+Nf9JZQ8TK/0i3Dk9Bk/XAtHvUSDwrLBHO35IwQMME0QfDX5gcQX9ex
\r
37 SfzaV5056Rv7r0zra13sfQtPo0AAn3QI2Mrmgd6M=
\r
38 Date: Thu, 2 Oct 2014 13:48:00 -0700
\r
39 From: "W. Trevor King" <wking@tremily.us>
\r
40 To: Austin Clements <aclements@csail.mit.edu>
\r
41 Subject: Re: [PATCH v4] lib: Simplify close and codify aborting atomic section
\r
42 Message-ID: <20141002204800.GS3770@odin.tremily.us>
\r
43 References: <87mw9ee0vf.fsf@csail.mit.edu>
\r
44 <1412277548-3445-1-git-send-email-aclements@csail.mit.edu>
\r
45 <20141002194134.GP3770@odin.tremily.us>
\r
46 <87k34idx4i.fsf@csail.mit.edu>
\r
48 Content-Type: multipart/signed; micalg=pgp-sha1;
\r
49 protocol="application/pgp-signature"; boundary="nqr+Djj1aAiKpg5f"
\r
50 Content-Disposition: inline
\r
51 In-Reply-To: <87k34idx4i.fsf@csail.mit.edu>
\r
52 OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
\r
53 url=http://tremily.us/pubkey.txt
\r
54 User-Agent: Mutt/1.5.23 (2014-03-12)
\r
55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;
\r
56 s=q20140121; t=1412282882;
\r
57 bh=H84DS2lTF1Ue5bjT2rsoettmnML/VuUVrRR5tdzOE68=;
\r
58 h=Received:Received:Received:Date:From:To:Subject:Message-ID:
\r
59 MIME-Version:Content-Type;
\r
60 b=wlXB+5LllZd1EmNcHEF08SRnIJP9OAUbitqti1gqXtAYcDCi3ezMk0rEjvglj/nLo
\r
61 QQXJEBSWHypAtAC9IegkBF5g3usdDpxMXXDvG8gqGC67fL26rvg44epnjSI4/NH4hH
\r
62 2ex8WUroJo6RJLzBMtMkg5FTsIsEZiRgNkd2YInGZc2YSswBoHfCLYXRTOUq+m8A1I
\r
63 LgqDEHdqsk99NtNofmDjvqsTbdyngSBlrhssd0hkCnDsV29R5mu5QtudJz39X3PU5K
\r
64 LJD/ECCMRku3bcK2orBXw+I7hWA8KeUvj+3EIjcuUDVgwAW0xB37GIvuuq/G9AH+wj
\r
66 Cc: notmuch@notmuchmail.org
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.13
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Thu, 02 Oct 2014 20:48:10 -0000
\r
83 Content-Type: text/plain; charset=utf-8
\r
84 Content-Disposition: inline
\r
85 Content-Transfer-Encoding: quoted-printable
\r
87 On Thu, Oct 02, 2014 at 04:39:41PM -0400, Austin Clements wrote:
\r
88 > On Thu, 02 Oct 2014, W. Trevor King wrote:
\r
89 > > On Thu, Oct 02, 2014 at 03:19:08PM -0400, Austin Clements wrote:
\r
90 > >> This patch simplifies notmuch_database_close to explicitly abort
\r
91 > >> any outstanding transaction and then just call Database::close.
\r
92 > >> This works for both read-only and read/write databases, takes
\r
93 > >> care of committing changes, unifies the exception handling path,
\r
94 > >> and codifies aborting outstanding transactions.
\r
96 > > I don't expect atomic blocks are particularly useful for read-only
\r
97 > > connections. If they aren't, I'd quibble with the =E2=80=9CThis works =
\r
99 > > both read-only=E2=80=A6=E2=80=9D wording above. If they are, I'd drop =
\r
103 > It's true that atomic sections aren't very useful on a read-only
\r
104 > database, but we do allow them for symmetry.
\r
106 Heh, and they're no-ops since the beginning in 957f1ba3 (lib: Add
\r
107 notmuch_database_{begin,end}_atomic, 2011-01-29). So both the commit
\r
108 message and read/write check make sense. Quibble retracted.
\r
114 This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
\r
115 For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
\r
118 Content-Type: application/pgp-signature; name="signature.asc"
\r
119 Content-Description: OpenPGP digital signature
\r
121 -----BEGIN PGP SIGNATURE-----
\r
124 iQIcBAEBAgAGBQJULbn/AAoJEG8/JgBt8ol8GeQP/1vp2y0f/I7ADIjn6izfaIS1
\r
125 +u099CWat1dmicKblwR9QROkPxEi/qRFzliHfMg4umIxbWHQFYmYm5w7b80MnXIz
\r
126 1y6ShwE/bDD1bf7omaRZBOmnNZ/GZQsZea+0wdA4VNozQA9M1qBCD0DhxTklgfwe
\r
127 oh2v7SyXPjY92auUYSUG5+B4hcNlwL1uIlp6tlqgOuuxQ6BOEc4TVF288MYRwlRV
\r
128 UrK1Qaz5Ngk5oMhfZphTz5LbWE2YYNIvu9njpKjIatgCjGL1UAxbYAHQ631ZOObG
\r
129 7VrGGttamGfzPQ5srlVxtnClqT3rtjQc/mRU3TNAfIfCGpbv+D3BEVscegFJEWOZ
\r
130 7OjbRath6Ow8wyms5wlQTBcyM3b0qnJYMS/W1D64nV7YkRKxvolIh1ehum1YcvmJ
\r
131 /PJzFaUhQR/PBrL/Bvz6GbQONDNLsKrZ+M7abgkeA4sd/diaU+U11yGkgBTDHVuo
\r
132 iirBXhMQtqqurKScnd5lUDwFjJpRr5Z0VXuu868uolznLHilQk8wgm31qXxXCcm4
\r
133 TSghyT20EwIZZAcm+iZiZyDqoFyw6puLMsjTreT26+jtKEIDTL33USncaRxNqayi
\r
134 BTRtmkZiUXf+SFLuKm3BeNFONx2S9bf9BeaKV+qCiy+q0pIRwZhc0KO/Z1SVqoZj
\r
135 7fovHKHe34TAYtJCENBn
\r
137 -----END PGP SIGNATURE-----
\r
139 --nqr+Djj1aAiKpg5f--
\r