1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E6D5F431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 26 Nov 2012 09:35:14 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id HNF8Y9zxu782 for <notmuch@notmuchmail.org>;
\r
16 Mon, 26 Nov 2012 09:35:14 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 4737E431FAE
\r
20 for <notmuch@notmuchmail.org>; Mon, 26 Nov 2012 09:35:14 -0800 (PST)
\r
21 X-AuditID: 12074424-b7fbe6d000003b02-22-50b3a851d8d7
\r
22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
23 by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id AD.24.15106.158A3B05; Mon, 26 Nov 2012 12:35:13 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id qAQHZCsH004081;
\r
27 Mon, 26 Nov 2012 12:35:13 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qAQHZ8Zx000062
\r
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
33 Mon, 26 Nov 2012 12:35:11 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1Td2aK-0001T5-BF; Mon, 26 Nov 2012 12:35:08 -0500
\r
37 Date: Mon, 26 Nov 2012 12:35:08 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
40 Subject: Re: [PATCH 0/6] API for iterating over all messages in a thread
\r
41 Message-ID: <20121126173508.GQ4562@mit.edu>
\r
42 References: <1353819427-13182-1-git-send-email-amdragon@mit.edu>
\r
43 <87ehjhkb3a.fsf@qmul.ac.uk> <20121125212059.GN4562@mit.edu>
\r
44 <m2624sffj1.fsf@guru.guru-group.fi>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 Content-Disposition: inline
\r
48 In-Reply-To: <m2624sffj1.fsf@guru.guru-group.fi>
\r
49 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
50 X-Brightmail-Tracker:
\r
51 H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hRV1g1csTnAoPOTmMXquTwW12/OZLZ4
\r
52 s3IeqwOzx85Zd9k9Dn9dyOLxbNUt5gDmKC6blNSczLLUIn27BK6M/+u2sxV8kqr4f+c3YwPj
\r
53 R5EuRk4OCQETiQsNn5ghbDGJC/fWs3UxcnEICexjlDh7qZ8VwtnAKHHl4lFGCOcik8Slw0uZ
\r
54 IZwljBL9vw4xgfSzCKhK9KyZwwpiswloSGzbv5wRxBYRUJF40LYeLM4s4Cox48IusHphAQ+J
\r
55 B79/gtm8AtoSVz5vZoIYuoxRovfLFFaIhKDEyZlPWCCatSRu/HsJVMQBZEtLLP/HARLmFDCQ
\r
56 mHv1BTuILQq0a8rJbWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmpRbrm
\r
57 ermZJXqpKaWbGEHBzu6isoOx+ZDSIUYBDkYlHt4DSzYHCLEmlhVX5h5ilORgUhLl3TMXKMSX
\r
58 lJ9SmZFYnBFfVJqTWnyIUYKDWUmE93sjUI43JbGyKrUoHyYlzcGiJM57PeWmv5BAemJJanZq
\r
59 akFqEUxWhoNDSYLXdTlQo2BRanpqRVpmTglCmomDE2Q4D9BwX5Aa3uKCxNzizHSI/ClGRSlx
\r
60 XneQhABIIqM0D64XloxeMYoDvSLMmwVSxQNMZHDdr4AGMwENTr6+EWRwSSJCSqqBsY43JPma
\r
61 EnfadT2xikyR2QfsJ6+IiHjlGhl/9NKPeNcZ84TsW5Z/jSxjDAut6XN4fPzXX0U/8SVvNGIm
\r
62 7rt5Lax2t32e0O7jnGeTlV6dufziQ5z0QWPu+WxCVtdiTvzt91iaeo5v75XJqqvLm6bJ7bBm
\r
63 /3ekV3re/b1PP7BZayu87JZhZ5rDrMRSnJFoqMVcVJwIAIvw24QhAwAA
\r
64 Cc: notmuch@notmuchmail.org
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Mon, 26 Nov 2012 17:35:15 -0000
\r
79 Quoth Tomi Ollila on Nov 26 at 7:19 pm:
\r
80 > On Sun, Nov 25 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
82 > > Quoth Mark Walters on Nov 25 at 2:31 pm:
\r
86 > >> This series looks good to me (I have not reviewed the two bindings
\r
87 > >> patches). Patch 2 looks like it makes things much easier to follow than
\r
88 > >> the current code (if I understood the current pointer stuff it
\r
89 > >> constructs the top-level list by doing pointer stuff to remove all
\r
90 > >> messages which are replies from the complete message list). Indeed, the
\r
91 > >> diff is more complicated than the new code!
\r
93 > >> On Sun, 25 Nov 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
94 > >> > This series adds a library API for iterating over all messages in a
\r
95 > >> > thread in sorted order. This is easy for the library to provide and
\r
96 > >> > difficult to obtain from the current API. Plus, if you don't count
\r
97 > >> > the code added to the bindings, this series is actually a net
\r
98 > >> > decrease of 4 lines of code because of simplifications it enables.
\r
100 > >> > Do we want the API to do more? Currently it's very minimal, but I can
\r
101 > >> > imagine two ways it could be generalized. It could take an argument
\r
102 > >> > to indicate which message list to return, which could be all messages,
\r
103 > >> > matched messages, top-level messages, or maybe even unmatched messages
\r
104 > >> > (possibly all in terms of message flags). It could also take an
\r
105 > >> > argument indicating the desired sort order. Currently, the caller can
\r
106 > >> > use existing message flag APIs to distinguish matched and unmatched
\r
107 > >> > messages and there's a separate function for the top-level messages.
\r
108 > >> > However, if the API could do all of these things, it would subsume
\r
109 > >> > various other API functions, such as notmuch_thread_get_*_date.
\r
111 > >> I don't know if this is the right API. For the matched message etc I
\r
112 > >> think using the existing message flag APIs is simple enough. I am not
\r
113 > >> sure about sort orders though: that looks like it would be much easier
\r
114 > >> for the caller to have the correct sort by I am not sure what users
\r
115 > >> would need it.
\r
117 > > For sort order, I would be inclined to simply construct the reverse
\r
118 > > list the first time a caller asks for it. Theoretically the caller
\r
119 > > could do this just as easily as the library, except that we don't
\r
120 > > expose the list routines.
\r
122 > > If I do add sort order, I would also want to add some control over
\r
123 > > which list is returned, since it would be asymmetric to be able to
\r
124 > > request all messages in either order, but top-level messages only in
\r
125 > > oldest-first. I think this would be pretty simple, and would give us
\r
126 > > a reasonably general-purpose and extensible API. (It would also solve
\r
127 > > the naming conundrum I mentioned below in my original email.)
\r
129 > The code looks good to me.
\r
131 > I'm interested to see the extensible interface for returning desired
\r
132 > list in desired sort order :)
\r
134 I'll give this a shot (probably later today) and people can see what
\r
146 > >> > Also, is this the right name for the new API? In particular, if we do
\r
147 > >> > later want to add a function that returns, say, the list of matched
\r
148 > >> > messages, we'll have a convention collision with
\r
149 > >> > notmuch_thread_get_matched_messages, which returns only a count.
\r
projects / notmuch-archives.git / blob