1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 320D96DE1AE9
\r
6 for <notmuch@notmuchmail.org>; Sun, 20 Sep 2015 05:28:41 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=1.158 tagged_above=-999 required=5 tests=[AWL=-0.238,
\r
12 SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 25efpsF4vsHd for <notmuch@notmuchmail.org>;
\r
16 Sun, 20 Sep 2015 05:28:39 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id D410E6DE1AE8
\r
19 for <notmuch@notmuchmail.org>; Sun, 20 Sep 2015 05:28:38 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 1F80D10008D;
\r
22 Sun, 20 Sep 2015 15:28:39 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default
\r
26 In-Reply-To: <87io75tji3.fsf@maritornes.cs.unb.ca>
\r
27 References: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi>
\r
28 <87io75tji3.fsf@maritornes.cs.unb.ca>
\r
29 User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Sun, 20 Sep 2015 15:28:38 +0300
\r
35 Message-ID: <m2lhc1b7gp.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.18
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Sun, 20 Sep 2015 12:28:41 -0000
\r
52 On Sun, Sep 20 2015, David Bremner <david@tethera.net> wrote:
\r
54 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
56 >> make test V=1 (or any other value than 0) and make test V=0
\r
57 >> works similar way as build in general
\r
60 >> This is 2nd try: In first one I changed test-lib.sh -- there problem
\r
61 >> was the precedence between command line argument and NOTMUCH_TEST_QUIET
\r
62 >> environment variable. Here I don't see a problem there (although
\r
63 >> env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable
\r
64 >> overrule the V=1 -- I am not sure who cares, though :D)
\r
66 >> Anyway, Someone(TM) may have better solution in mind, so let's
\r
67 >> get bikeshedding going!
\r
70 > One thing I thought of was that we could replace the use of
\r
71 > NOTMUCH_TEST_QUIET with e.g. NOTMUCH_TEST_VERBOSE, and have that set by
\r
72 > the command line argument --verbose. This would be less work on the
\r
73 > Makefile side, but I guess a bit more on the test-lib.sh side. I suppose
\r
74 > it might also be an annoyance for some people currently using
\r
75 > NOTMUCH_TEST_QUIET in some autobuilder setup. At the moment I can't
\r
76 > think of what would really break by changing this "API", but knows. The
\r
77 > current behaviour of having NOTMUCH_TEST_QUIET and --verbose completely
\r
78 > independent is pretty surprising.
\r
80 There was 2 primary motivations when I did that patch (which I forgot to
\r
81 mark rfc although I thought doing so) 1) that was the fastest at the time
\r
82 being and 2) the --verbose is already in use in test-lib.sh.
\r
84 First thing that come to my mind is that if (-v|--v[e[r[b[o[s[e]]]]]])
\r
85 option is for the suggested purpose its current behaviour is removed
\r
86 and when the option is not give user is informed how to activate "verbose"
\r
87 progress -- but as said that is just first thought...
\r
90 Making NOTMUCH_TEST_QUIET no-op is probably no annoyance to anyone...
\r
95 > P.S. I hope you appreciate my classic "scope-creep" technique in
\r
98 In test-related issues that is fine by me.
\r