f0/bfdd780bd8aa8671f393c1821f8b09b19b329d

   1 Return-Path: <dmitry.kurochkin@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id C5964429E26\r
   6         for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 04:11:55 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.799\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id DqO4Jyw3zVEW for <notmuch@notmuchmail.org>;\r
  17         Wed, 15 Jun 2011 04:11:55 -0700 (PDT)\r
  18 Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com\r
  19         [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id DF5CF431FB6\r
  22         for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 04:11:54 -0700 (PDT)\r
  23 Received: by fxm8 with SMTP id 8so337389fxm.26\r
  24         for <notmuch@notmuchmail.org>; Wed, 15 Jun 2011 04:11:53 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
  26         h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer;\r
  27         bh=xasTdWsfbhyEjAIEc4wu/WeEENixD2ZXgkCiF2JvD/Y=;\r
  28         b=s3NmnrzMG6VBBumEpW+Et6PQjwEodQP7pSorp78Gr+/pBSIT5C+GXAeDe5RcU2q9Av\r
  29         QEvPfOPLsO2wt+4tobgSJGgYiBm0ityDSWdmsYf4PAl4lq5BX6D8i2HHGUvM3VOOgy6O\r
  30         790aHc71fhCacw/GexfvgOPxdwBplwr+qSp8w=\r
  31 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
  32         h=from:to:cc:subject:date:message-id:x-mailer;\r
  33         b=v1w7/DC7PQ7MBoK70KkiunGa7YxMm/raDXVBOKV3SNNDdm9Jb0vV+uva2ImC3o1BLa\r
  34         0+xkdSkdZRzoZXF9ZxWzstMXvMAZ/6kjRPISdoKvBCo2MwHHviN0SOrNW6UCJsgpFOvU\r
  35         +m0immVyqHxav1vTTEr8NdCeJ/+2jNMOgqIIs=\r
  36 Received: by 10.223.159.14 with SMTP id h14mr452325fax.20.1308136313457;\r
  37         Wed, 15 Jun 2011 04:11:53 -0700 (PDT)\r
  38 Received: from localhost ([91.144.186.21])\r
  39         by mx.google.com with ESMTPS id b26sm162051fak.0.2011.06.15.04.11.51\r
  40         (version=TLSv1/SSLv3 cipher=OTHER);\r
  41         Wed, 15 Jun 2011 04:11:52 -0700 (PDT)\r
  42 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
  43 To: notmuch@notmuchmail.org\r
  44 Subject: [PATCH 1/3] Fix double free in guess_from_received_header().\r
  45 Date: Wed, 15 Jun 2011 15:12:12 +0400\r
  46 Message-Id: <1308136334-9219-1-git-send-email-dmitry.kurochkin@gmail.com>\r
  47 X-Mailer: git-send-email 1.7.5.4\r
  48 X-BeenThere: notmuch@notmuchmail.org\r
  49 X-Mailman-Version: 2.1.13\r
  50 Precedence: list\r
  51 List-Id: "Use and development of the notmuch mail system."\r
  52         <notmuch.notmuchmail.org>\r
  53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  54         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  56 List-Post: <mailto:notmuch@notmuchmail.org>\r
  57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  59         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  60 X-List-Received-Date: Wed, 15 Jun 2011 11:11:55 -0000\r
  61 \r
  62 Before the change, the last loop in guess_from_received_header()\r
  63 did not reset domain and tld variables to NULL.  This leads to\r
  64 double free error in some cases and possibly other bugs.\r
  65 ---\r
  66  notmuch-reply.c |    1 +\r
  67  1 files changed, 1 insertions(+), 0 deletions(-)\r
  68 \r
  69 diff --git a/notmuch-reply.c b/notmuch-reply.c\r
  70 index 514bbc6..dab69e6 100644\r
  71 --- a/notmuch-reply.c\r
  72 +++ b/notmuch-reply.c\r
  73 @@ -406,6 +406,7 @@ guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message\r
  74         /* Now extract the last two components of the MTA host name\r
  75          * as domain and tld.\r
  76          */\r
  77 +       domain = tld = NULL;\r
  78         while ((ptr = strsep (&token, delim)) != NULL) {\r
  79             if (*ptr == '\0')\r
  80                 continue;\r
  81 -- \r
  82 1.7.5.4\r
  83 \r