1 Return-Path: <ethan.glasser.camp@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1D6A9431FBC
\r
6 for <notmuch@notmuchmail.org>; Tue, 13 Nov 2012 18:03:50 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 1-Q4Uy0Dh4fY for <notmuch@notmuchmail.org>;
\r
17 Tue, 13 Nov 2012 18:03:49 -0800 (PST)
\r
18 Received: from mail-qa0-f53.google.com (mail-qa0-f53.google.com
\r
19 [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 9B723431FAF
\r
22 for <notmuch@notmuchmail.org>; Tue, 13 Nov 2012 18:03:49 -0800 (PST)
\r
23 Received: by mail-qa0-f53.google.com with SMTP id k31so17301qat.5
\r
24 for <notmuch@notmuchmail.org>; Tue, 13 Nov 2012 18:03:49 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=g1j4nO3wh8KVUPX+uVwRMNbfCWm3X9pGgJIyNwACcj8=;
\r
29 b=UWMQyOX3+vvDBXxuOTUSD+zkpDfZhp9tTlJ35O4SXBEboW5T9Ep+SLeENedWzRHiLQ
\r
30 U765Amksuz9L7JKkHTSbTWfRdfdRJO+Ms5Qp1oGMquWUUN5nkJk/560p0YiizWwY1BwO
\r
31 Ynvb0xjNmXygCtT3yJpKbbHbWxrAHCiISHODxyg0l1sDXDaSEDYnf4P9EvC7dQ8bveYP
\r
32 TMLKD7wlbq/dMKAnp7HPwwdPykRyktLyKWQE8Evko1Jmg+0fjeJP4FJYJTzuqfmX9ImA
\r
33 UyjzOlyZKLeQg3WIpa9/xRYgN+oj8ilwkR81ozTgGi3625XHFQAKKVr8jK2i0lP666PG
\r
35 Received: by 10.224.109.199 with SMTP id k7mr1497183qap.66.1352858629039;
\r
36 Tue, 13 Nov 2012 18:03:49 -0800 (PST)
\r
37 Received: from smtp.gmail.com (mca2d36d0.tmodns.net. [208.54.45.202])
\r
38 by mx.google.com with ESMTPS id lk6sm1270337qeb.10.2012.11.13.18.03.47
\r
39 (version=TLSv1/SSLv3 cipher=OTHER);
\r
40 Tue, 13 Nov 2012 18:03:47 -0800 (PST)
\r
41 From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
42 To: Damien Cassou <damien.cassou@gmail.com>,
\r
43 notmuch mailing list <notmuch@notmuchmail.org>
\r
44 Subject: Re: [PATCH v2] emacs: display tags in notmuch-show with links
\r
45 In-Reply-To: <1352565719-12397-1-git-send-email-damien.cassou@gmail.com>
\r
46 References: <1352565719-12397-1-git-send-email-damien.cassou@gmail.com>
\r
47 User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Tue, 13 Nov 2012 21:03:44 -0500
\r
50 Message-ID: <87mwyl54an.fsf@betacantrips.com>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Wed, 14 Nov 2012 02:03:50 -0000
\r
67 Damien Cassou <damien.cassou@gmail.com> writes:
\r
69 > +(defun notmuch-tagger-present-tags (tags &optional headerline)
\r
70 > + "Return a property list which nicely presents all TAGS.
\r
72 > +If HEADERLINE is non-nil the returned list will be ready for
\r
73 > +inclusion in the buffer's header-line. HEADERLINE must be nil in
\r
74 > +all other cases."
\r
77 > + (notmuch-tagger-separate-elems (notmuch-tagger-format-tags tags headerline) " ")
\r
80 It is kind of appalling that it takes 128 lines just to do this. It
\r
81 seems like there has to be an easier way, or several easier
\r
82 ways. Unfortunately, I don't see any.
\r
84 > diff --git a/test/emacs b/test/emacs
\r
85 > index 44f641e..ecdc841 100755
\r
88 > @@ -820,5 +820,66 @@ Date: Fri, 05 Jan 2001 15:43:57 +0000
\r
90 > test_expect_equal_file OUTPUT EXPECTED
\r
92 > +test_begin_subtest "Extracting all tags from a thread"
\r
94 > + '[subject]="Extracting all tags from a thread"' \
\r
95 > + '[body]="body 1"'
\r
96 > +parent=${gen_msg_id}
\r
98 > + '[subject]="Extracting all tags from a thread"' \
\r
99 > + '[body]="body 2"' \
\r
100 > + "[in-reply-to]=\<$parent\>"
\r
102 > + '[subject]="Extracting all tags from a thread"' \
\r
103 > + '[body]="body 3"' \
\r
104 > + "[in-reply-to]=\<$parent\>"
\r
105 > +latest=${gen_msg_id}
\r
106 > +# Extract the thread-id from one of the emails
\r
107 > +thread_id=$(notmuch search id:${latest} | sed -e "s/thread:\([a-f0-9]*\).*/\1/")
\r
109 I think the accepted idiom is to use "notmuch search
\r
110 --output=threads". This will output just a string like
\r
111 "thread:00000000000000b9", so if you really need just the ID, you could
\r
112 still use sed here...
\r
114 > +# Add tag "mytagfoo" to one of the emails
\r
115 > +notmuch tag +mytagfoo id:${latest}
\r
116 > +test_emacs_expect_t \
\r
117 > + "(notmuch-show \"thread:${thread_id}\")
\r
119 ... but it seems like "thread:..." is good enough for you.
\r
121 > + (error \"We must be in notmch-show at this point but we are in %s.\" major-mode))
\r
122 > + (push-button) ;; simulate a press on the RET key
\r
123 > + (if (eq major-mode 'notmuch-search-mode)
\r
125 > + (format \"We must be in notmch-search at this point but we are in %s.\" major-mode))"
\r
127 s/notmch/notmuch/ here.
\r
129 Otherwise I think the code looks fine. I think the design concerns
\r
130 raised by Mark Walters are probably valid, though.
\r