1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A9B25431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 6 Sep 2012 01:10:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 0uuYcYDlzgig for <notmuch@notmuchmail.org>;
\r
16 Thu, 6 Sep 2012 01:10:39 -0700 (PDT)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 8CE08431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 6 Sep 2012 01:10:39 -0700 (PDT)
\r
20 Received: from localhost (unknown [192.168.200.4])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id 1812E19F32ED;
\r
22 Thu, 6 Sep 2012 10:10:34 +0200 (CEST)
\r
23 X-Virus-Scanned: IMAP AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,
\r
27 with ESMTP id dVHkoaQ-aWoZ; Thu, 6 Sep 2012 10:10:29 +0200 (CEST)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id 0A14C3CFE74;
\r
30 Thu, 6 Sep 2012 10:10:28 +0200 (CEST)
\r
31 Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30])
\r
32 (Authenticated sender: sojkam1)
\r
33 by imap.feld.cvut.cz (Postfix) with ESMTPSA id BB439660904;
\r
34 Thu, 6 Sep 2012 10:10:28 +0200 (CEST)
\r
35 Received: from wsh by steelpick.2x.cz with local (Exim 4.80)
\r
36 (envelope-from <sojkam1@fel.cvut.cz>)
\r
37 id 1T9XAS-0004l7-JO; Thu, 06 Sep 2012 10:10:28 +0200
\r
38 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH] emacs: Add customization group for replying
\r
41 In-Reply-To: <m21uih6k2t.fsf@guru.guru-group.fi>
\r
42 References: <1343311113-22171-1-git-send-email-sojkam1@fel.cvut.cz>
\r
43 <87vcfu2qap.fsf@steelpick.2x.cz>
\r
44 <m2ligqnoap.fsf@guru.guru-group.fi>
\r
45 <87zk55n44x.fsf@steelpick.2x.cz>
\r
46 <m21uih6k2t.fsf@guru.guru-group.fi>
\r
47 User-Agent: Notmuch/0.14+23~g9d68aca (http://notmuchmail.org) Emacs/24.1.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Thu, 06 Sep 2012 10:10:28 +0200
\r
50 Message-ID: <874nnbvaff.fsf@steelpick.2x.cz>
\r
52 Content-Type: text/plain
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Thu, 06 Sep 2012 08:10:40 -0000
\r
67 On Wed, Sep 05 2012, Tomi Ollila wrote:
\r
68 > On Tue, Sep 04 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
70 >> On Tue, Sep 04 2012, Tomi Ollila wrote:
\r
71 >>> On Tue, Sep 04 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
73 >>>> On Thu, Jul 26 2012, Michal Sojka wrote:
\r
74 >>>>> When one wants to customize the format of reply message, there nothing
\r
75 >>>>> to tell the user how to do it. Without knowing that construction of
\r
76 >>>>> reply buffer is actually implemented in the message package, it seems
\r
77 >>>>> that replying cannot be customized.
\r
79 >>>>> Because I was getting annoyed by the empty line the between citation
\r
80 >>>>> line and the quoted message, I figured out that changing this is fairly
\r
81 >>>>> easy when one knows what to customize.
\r
83 >>>>> This patch adds notmuch-reply customization group that that contains
\r
84 >>>>> references to the relevant customization options. The new group is easy
\r
85 >>>>> to find as it is shown as a result of running "M-x customize-group RET
\r
90 >>>> Any objections against applying?
\r
92 >>> Nobody dares to say anything due to infamiliriaty of this spesific case ;/.
\r
94 >>> I could not find any reference this has been made before.
\r
96 >> It's at least documented at
\r
97 >> http://www.gnu.org/software/emacs/manual/html_node/elisp/Group-Definitions.html
\r
99 >> The argument members is a list specifying an initial set of
\r
100 >> customization items to be members of the group. However, most often
\r
101 >> members is nil, and you specify the group's members by using the
\r
102 >> :group keyword when defining those members.
\r
104 >>> I could not find any discussion about this issue.
\r
106 >>> With little effort I could not extract the customization tree to
\r
107 >>> stdout I could have attempted to grep whether there is same variable
\r
108 >>> in many groups.
\r
110 >> I tried to grep emacs sources and found the following:
\r
112 >> (defgroup message '((user-mail-address custom-variable)
\r
113 >> (defgroup gnus-message '((message custom-group))
\r
114 >> (defgroup ps-print-printer '((lpr custom-group))
\r
115 >> (defgroup customize '((widgets custom-group))
\r
116 >> (defgroup font-lock '((jit-lock custom-group))
\r
118 >> At least the first line corresponds exactly to what is proposed in my
\r
124 > I was looking whether the same customization variable has been put
\r
125 > into multiple groups (now those are also in message-insertion group like
\r
126 > you have in your patch). (So far) I haven't seen that to be done
\r
127 > (not that it forbids doing so, just that there aren't issues about that).
\r
129 > From consistency point of view all the customization variables in notmuch
\r
130 > groups start with "notmuch-" and these "message-" breaks this... An
\r
131 > alternative to the above could be the following:
\r
133 > (defgroup notmuch-reply
\r
134 > '((notmuch-message-replied-tags custom-variable)
\r
135 > (message-insertion custom-group))
\r
138 Why not. Updated patch follows...
\r