1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id EE2C0431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 2 May 2012 15:26:08 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id JS8FxrecYNyS for <notmuch@notmuchmail.org>;
\r
16 Wed, 2 May 2012 15:26:07 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 6B67A431FAE
\r
21 for <notmuch@notmuchmail.org>; Wed, 2 May 2012 15:26:07 -0700 (PDT)
\r
22 Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([156.34.89.108] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
\r
25 (Exim 4.72) (envelope-from <bremner@unb.ca>)
\r
26 id 1SPhzj-0007Bh-8N; Wed, 02 May 2012 19:26:03 -0300
\r
27 Received: from bremner by zancas.localnet with local (Exim 4.77)
\r
28 (envelope-from <bremner@unb.ca>)
\r
29 id 1SPhzd-0002tl-Ru; Wed, 02 May 2012 19:25:53 -0300
\r
30 From: David Bremner <david@tethera.net>
\r
31 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH] configure: test shell parameter substring processing and
\r
34 In-Reply-To: <1334643263-30207-1-git-send-email-tomi.ollila@iki.fi>
\r
35 References: <1334589199-25894-1-git-send-email-tomi.ollila@iki.fi>
\r
36 <1334643263-30207-1-git-send-email-tomi.ollila@iki.fi>
\r
37 User-Agent: Notmuch/0.12+152~g904a807 (http://notmuchmail.org) Emacs/23.4.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Wed, 02 May 2012 19:25:53 -0300
\r
40 Message-ID: <87ehr2nrta.fsf@zancas.localnet>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Wed, 02 May 2012 22:26:09 -0000
\r
60 I'm still a bit leery of over-complicating the configure script to
\r
61 support legacy /bin/sh; however, I guess I'm at least convinced that the
\r
62 only trivial solution is just to document the requirement for posix
\r
63 /bin/sh. It will be odd to back this out and document the restriction
\r
64 later, so please chime in now if you have strong feelings either way.
\r
66 Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
68 > To tackle this situation the beginning of configure attemts to do a silent
\r
69 > parameter substitution in a subshell; in case this fails the subshell exits
\r
70 > with nonzero value which is easy to detect.
\r
74 > The || constructs are used twice. The first one is used as Bourne shell
\r
75 > chokes on 'if ! ... ' construct (and if ...; then :; else do_things; fi
\r
76 > looks stupid). The second one(liner) takes care of the possible future
\r
77 > addition of 'set -eu' in the beginning of this script.
\r
79 OK, although I might have gone for the empty if myself.
\r
81 > +# If not, attempt to locate and launch one which probably can.
\r
83 > +( option=option=value; : ${option#*=} ) 2>/dev/null || {
\r
85 option=option=value seems a little _too_ clever to me. Any reason not to
\r
90 > + if test x"${_NOTMUCH_CONFIGURE-}" = x ; then
\r
91 > + _NOTMUCH_CONFIGURE=1; export _NOTMUCH_CONFIGURE
\r
93 This could probably use a comment.
\r
95 > + for x in /bin/ksh /bin/bash /usr/bin/bash
\r
97 I guess add /usr/local/bin/bash? I'm slightly worried this list will
\r