1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 80E2A431FAF
\r
6 for <notmuch@notmuchmail.org>; Wed, 29 May 2013 18:01:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id FEXLb5Ujz12n for <notmuch@notmuchmail.org>;
\r
16 Wed, 29 May 2013 18:01:40 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id BE07C431FAE
\r
20 for <notmuch@notmuchmail.org>; Wed, 29 May 2013 18:01:40 -0700 (PDT)
\r
21 X-AuditID: 1209190f-b7f256d000005616-b4-51a6a4f3ea64
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 6A.10.22038.3F4A6A15; Wed, 29 May 2013 21:01:39 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r4U11bLo028540;
\r
27 Wed, 29 May 2013 21:01:38 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r4U11Yjd031243
\r
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
33 Wed, 29 May 2013 21:01:36 -0400
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1UhrFG-0007j4-4P; Wed, 29 May 2013 21:01:34 -0400
\r
37 Date: Wed, 29 May 2013 21:01:33 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [PATCH 0/4] emacs: Part command improvements
\r
41 Message-ID: <20130530010133.GY5999@mit.edu>
\r
42 References: <1369687594-31774-1-git-send-email-amdragon@mit.edu>
\r
43 <87zjvghx82.fsf@qmul.ac.uk>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 Content-Disposition: inline
\r
47 In-Reply-To: <87zjvghx82.fsf@qmul.ac.uk>
\r
48 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
49 X-Brightmail-Tracker:
\r
50 H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT0f28ZFmgwapWBYvVc3ksrt+cyezA
\r
51 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZaz7/pyl4Lh4xcYP15kaGE8LdTFycEgImEh8
\r
52 +cHaxcgJZIpJXLi3nq2LkYtDSGAfo8Skh1eZIJyNjBI/Xx9ghHBOM0nMutzNDuEsYZRYMmsZ
\r
53 WD+LgKpE18QtbCA2m4CGxLb9yxlBbBEBHYnbhxawg9jMAtIS3343M4HYwgKWEu17D4DV8Apo
\r
54 Sxz92AbWKyQQJ/Gi6SU7RFxQ4uTMJywQvVoSN/69ZAI5G2TO8n8cICYn0Kq5C8GqRQVUJKac
\r
55 3MY2gVFoFpLmWUiaZyE0L2BkXsUom5JbpZubmJlTnJqsW5ycmJeXWqRropebWaKXmlK6iREU
\r
56 0pyS/DsYvx1UOsQowMGoxMO7QWtZoBBrYllxZe4hRkkOJiVR3lJgRAjxJeWnVGYkFmfEF5Xm
\r
57 pBYfYpTgYFYS4V2jDZTjTUmsrEotyodJSXOwKInzXk256S8kkJ5YkpqdmlqQWgSTleHgUJLg
\r
58 jQQZKliUmp5akZaZU4KQZuLgBBnOAzTcAaSGt7ggMbc4Mx0if4pRUUqcNwokIQCSyCjNg+uF
\r
59 pZxXjOJArwjzBoJU8QDTFVz3K6DBTECDxZkXgwwuSURISTUw6l1++YAxP1pZfJv9FQ5f0ytz
\r
60 ph5dG3o0zTkoPriwW/dcTtjiWfusvE09Vv5ouJVaczJy4uxTDtuspXrVfr359nZ/cudV9tQq
\r
61 j47mCO0JReELHtcujY+X0O35ktchqHRxV/7G+8nLXMJOMhXenlrhVBz37SenwW0986Y+DzvH
\r
62 kBuHVvsYnvNWYinOSDTUYi4qTgQAOL/2ZRQDAAA=
\r
63 Cc: notmuch@notmuchmail.org
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Thu, 30 May 2013 01:01:48 -0000
\r
78 Quoth Mark Walters on May 27 at 11:30 pm:
\r
79 > Austin Clements <amdragon@MIT.EDU> writes:
\r
81 > > This is a follow-up of sorts to id:"8761ycc19t.fsf@qmul.ac.uk", where
\r
82 > > Mark suggested that the part handling commands could all use the
\r
83 > > correponding mm-* functions. I ran with the idea and wound up with
\r
84 > > this series, which, in addition to standardizing on the mm-* functions
\r
85 > > for everything and simplifying the implementation overall, decouples
\r
86 > > the part commands from part buttons, which removes an entire layer
\r
87 > > from the implementation and adds the ability to invoke part commands
\r
88 > > with point anywhere in a part (something I often find myself wanting).
\r
90 > Overall I really like this series. In addition to the clean up etc it
\r
91 > makes it easy to export the text/plain part (which doesn't have a part
\r
92 > button). I have recollection of this being difficult if it is base64
\r
95 Right. That's one of the reasons I wanted a global part keymap (and
\r
96 this series happened to be a convenient place to introduce that).
\r
97 Also helpful is that the part bindings now appear in the show help,
\r
98 which is good because I can never remember which key used the default
\r
99 viewer and which prompted for a viewer.
\r
101 > I have a few small comments
\r
103 > As mentioned on irc (just included here in case other people are
\r
104 > testing) make-composed-keymap is emacs 24 only.
\r
106 I've removed the button map entirely, so this is no longer a problem.
\r
108 > This does change the default directory for saving: not serious but it's
\r
109 > probably worth deciding do we want to use mailcap-download-directory or
\r
110 > home or where emacs was started or?
\r
112 I don't really care what the default directory is, as long as we're
\r
113 consistent, which we currently aren't. mm-default-directory seems
\r
114 like a fine thing to be consistent with, since we use mm for
\r
117 > I don't know if we want to keep a special keymap for the button or just
\r
118 > always use the . prefix; the advantage is that you don't have 's' on a
\r
119 > button acting differently from 's' in the text (which has annoyed me
\r
120 > several times) otoh it is the extra keystroke which may annoy people
\r
121 > too. Let the bikeshedding begin! (obviously return for the default
\r
122 > action would remain.
\r
124 I'm all for removing the special button keymap. The less hidden
\r
125 functionality the better.
\r
127 > Would it be worth having . return in the part body as the default
\r
130 I played with this for a while and eventually decided it wasn't worth
\r
131 the effort. Maybe in a followup.
\r
133 > Finally, with message indenting it's the start/end of the part are a
\r
134 > little unclear. I think it's the [ of the part button at the start of
\r
135 > the part to the character before the [ of the next part button. In
\r
136 > particular on the line of a new part but before the button is still the
\r
137 > old part. Since parts are whole lines it would be nice if the region
\r
138 > were line based but I don't know if that is easy.
\r