1 Return-Path: <amdragon@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D3DF6431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 4 Nov 2011 13:21:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id GePsd+yVDyxs for <notmuch@notmuchmail.org>;
\r
17 Fri, 4 Nov 2011 13:21:48 -0700 (PDT)
\r
18 Received: from mail-qy0-f174.google.com (mail-qy0-f174.google.com
\r
19 [209.85.216.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id AA05B429E26
\r
22 for <notmuch@notmuchmail.org>; Fri, 4 Nov 2011 13:21:45 -0700 (PDT)
\r
23 Received: by qyk27 with SMTP id 27so1499913qyk.5
\r
24 for <notmuch@notmuchmail.org>; Fri, 04 Nov 2011 13:21:43 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=GCj6QoV3Su789/gXHH9eZ4tPjbxmfu00udX8EZ1Qerw=;
\r
30 b=W+vf3SprEv8vfUmQKACRfj6U0OuH7A0AB51xlrhEHTf4Xz/cjUcWSV9y6hM2MsrJ0x
\r
31 sYd8Tule7GkLp8JKn280KA/eXbJ/Ca+XAeu36QjD8dPHBqD3QC++qQq97FgK+iuHL+XM
\r
32 52b8V/jhn7TkkWJeaF8E41zm+3yfB7Tcx5X90=
\r
34 Received: by 10.42.144.65 with SMTP id a1mr17768954icv.46.1320438103538; Fri,
\r
35 04 Nov 2011 13:21:43 -0700 (PDT)
\r
36 Sender: amdragon@gmail.com
\r
37 Received: by 10.143.166.17 with HTTP; Fri, 4 Nov 2011 13:21:43 -0700 (PDT)
\r
38 In-Reply-To: <87obwwlsqo.fsf@nikula.org>
\r
39 References: <cover.1320093940.git.jani@nikula.org>
\r
40 <87fwi86dky.fsf@servo.finestructure.net>
\r
41 <87obwwlsqo.fsf@nikula.org>
\r
42 Date: Fri, 4 Nov 2011 16:21:43 -0400
\r
43 X-Google-Sender-Auth: EP7Y7BZOE58qzzEWKjS9EVVN0LY
\r
45 <CAH-f9WvKpRVg+H8Xu-FG6pmeegS29Z5C7Bw7sDLRoRTHMM-NSg@mail.gmail.com>
\r
46 Subject: Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in
\r
48 From: Austin Clements <amdragon@mit.edu>
\r
49 To: Jani Nikula <jani@nikula.org>
\r
50 Content-Type: text/plain; charset=ISO-8859-1
\r
51 Content-Transfer-Encoding: quoted-printable
\r
52 Cc: notmuch@notmuchmail.org
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Fri, 04 Nov 2011 20:21:49 -0000
\r
67 On Mon, Oct 31, 2011 at 6:07 PM, Jani Nikula <jani@nikula.org> wrote:
\r
68 > On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins <jrollins@fines=
\r
69 tructure.net> wrote:
\r
70 >> In order to push forward with this, though, I think we really need to
\r
71 >> have a complete unit test for this new functionality. =A0We usually like
\r
72 >> to see units tests that describe and then test for the new functionality
\r
73 >> you wish to add, followed by the patches that provide the new
\r
74 >> functionality. =A0Lots of good tests for new functionality being propose=
\r
76 >> here shouldn't be too difficult to work out ahead of time.
\r
78 > Right. I'd just like to make sure the approach I've taken (particularly
\r
79 > patch 1 in the set as it touches the lib) is acceptable before spending
\r
80 > time on testing and documentation etc. Indeed patches 1 and 2 changed
\r
81 > fundamentally between v1 and v2 after some chats on IRC. If the comments
\r
82 > now are favourable, I'll write the tests and documentation. (Though I
\r
83 > guess I have to admit the tests would've been beneficial to me already
\r
86 The library interface looks perfectly reasonable and consistent to me.
\r
87 My only concern would be that there's no way to return errors from
\r
88 notmuch_query_count_threads, but notmuch_query_count_messages has
\r
89 exactly the same problem.
\r
91 Other than that, you missed a few spaces before parentheses.
\r