ec/6637d1e20127325f1e186c05814ea5202e2cdd

   1 Return-Path: <kfogel@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 116AE431FBC\r
   6         for <notmuch@notmuchmail.org>; Mon,  7 Jul 2014 10:36:06 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.699\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
  13         RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id egP7uknrAmKd for <notmuch@notmuchmail.org>;\r
  17         Mon,  7 Jul 2014 10:35:58 -0700 (PDT)\r
  18 Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com\r
  19         [209.85.223.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 49EBC431FAF\r
  22         for <notmuch@notmuchmail.org>; Mon,  7 Jul 2014 10:35:58 -0700 (PDT)\r
  23 Received: by mail-ie0-f180.google.com with SMTP id tr6so2002221ieb.39\r
  24         for <notmuch@notmuchmail.org>; Mon, 07 Jul 2014 10:35:56 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
  26         h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to\r
  27         :message-id:user-agent:mime-version:content-type\r
  28         :content-transfer-encoding;\r
  29         bh=huwzrMNlwIpyn7WZpuO57JTgY4ZWyiHK7VH63AOjLM4=;\r
  30         b=JOF9BeWwjM/Z/lQfn0ffkR+2Kma0NDUSZbG18Xl4Z/gJNZTKmbKJyDZ+0u6QJaakMn\r
  31         rOuDiznRXlV7wKT/7BqFg6qMfk9csLWF+6iEs8JzFpGsV4iPYDiPyAOQLFEQjsvO0wwO\r
  32         Z2tFEjLeYEZPQy8jta66egufpfahf+ZpvcWmnW/B8ln9V52Bqu4dEU/UWHxXkYsF8dx6\r
  33         wY2W1+GnRsWsqLm5ERoSep0S9LD8sf2nRQEEROpE8Ndl6B9SqjRSrtsT9na1QUuISdNp\r
  34         1mjOsgB+rzUw1yX14XWqKNH2R1V6/HFzhEUM4Ha7ww+m4peAFw/5Xf/0rLG9nFPllSgE\r
  35         2hfQ==\r
  36 X-Received: by 10.42.104.75 with SMTP id q11mr33902844ico.35.1404754556839;\r
  37         Mon, 07 Jul 2014 10:35:56 -0700 (PDT)\r
  38 Received: from ktab.red-bean.com\r
  39         (74-92-190-113-Illinois.hfc.comcastbusiness.net. [74.92.190.113])\r
  40         by mx.google.com with ESMTPSA id t1sm91837123igh.9.2014.07.07.10.35.55\r
  41         for <multiple recipients>\r
  42         (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
  43         Mon, 07 Jul 2014 10:35:56 -0700 (PDT)\r
  44 Sender: Karl Fogel <kfogel@gmail.com>\r
  45 From: Karl Fogel <kfogel@red-bean.com>\r
  46 To: Sebastian Lipp <bacuh@riseup.net>\r
  47 Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
  48         notmuch-address.el.\r
  49 References: <87wqsfik5l.fsf@floss.red-bean.com>\r
  50         <87mwtah2hd.fsf@zancas.localnet> <877gkeau42.fsf@floss.red-bean.com>\r
  51         <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
  52         <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
  53         <m2hajgxli5.fsf@guru.guru-group.fi> <87vc7vgbym.fsf@zancas.localnet>\r
  54         <m2ehejykb1.fsf@guru.guru-group.fi>\r
  55         <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  56         <87oax6vt4u.fsf@ktab.red-bean.com>\r
  57         <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  58         <87d2djr7o1.fsf@floss.red-bean.com>\r
  59         <878uo6dxup.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  60 Date: Mon, 07 Jul 2014 12:35:54 -0500\r
  61 In-Reply-To:\r
  62  <878uo6dxup.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
  63         (Sebastian Lipp's message of "Sun, 06 Jul 2014 22:41:02 +0200")\r
  64 Message-ID: <8761j9kr5x.fsf@ktab.red-bean.com>\r
  65 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)\r
  66 MIME-Version: 1.0\r
  67 Content-Type: text/plain; charset=utf-8\r
  68 Content-Transfer-Encoding: quoted-printable\r
  69 Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
  70 X-BeenThere: notmuch@notmuchmail.org\r
  71 X-Mailman-Version: 2.1.13\r
  72 Precedence: list\r
  73 Reply-To: Karl Fogel <kfogel@red-bean.com>\r
  74 List-Id: "Use and development of the notmuch mail system."\r
  75         <notmuch.notmuchmail.org>\r
  76 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  77         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  78 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  79 List-Post: <mailto:notmuch@notmuchmail.org>\r
  80 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  81 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  82         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  83 X-List-Received-Date: Mon, 07 Jul 2014 17:36:06 -0000\r
  84 \r
  85 Sebastian Lipp <bacuh@riseup.net> writes:\r
  86 >Karl Fogel <kfogel@red-bean.com>\r
  87 >> In general, supplying a log message with the patch with avoid such\r
  88 >> confusion.  If there is some prose expressing what the change is\r
  89 >> supposed to to, and giving any historical context (such as the mailing\r
  90 >> list thread starting from last year), then it will be easy for any\r
  91 >> reviewer to understand what the patch is intended to do, and check if it\r
  92 >> actually does that.\r
  93 >\r
  94 >Okay, next time I will provide that information inline. Thought keeping\r
  95 >References and In-Reply-To headers would be sufficient reference.\r
  96 \r
  97 Well, when the patch is committed into a version control system, it's\r
  98 going to need a log message (commit message) anyway.  Since that message\r
  99 is considered part of the change -- anyone reading the change will start\r
 100 by reading the commit message -- it's typical to just include it with\r
 101 the diff.\r
 102 \r
 103 The commit message can certainly include a reference to the email\r
 104 thread; in fact, it's good if it does so.\r
 105 \r
 106 Best,\r
 107 =C2=ADKarl\r