1 Return-Path: <adrien@bustany.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 29709431FCB
\r
6 for <notmuch@notmuchmail.org>; Thu, 25 Oct 2012 11:39:44 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id xN+ffDjV+nIV for <notmuch@notmuchmail.org>;
\r
16 Thu, 25 Oct 2012 11:39:43 -0700 (PDT)
\r
17 Received: from mail.bustany.org (bustany.org [176.31.244.208])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 22537431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 25 Oct 2012 11:39:43 -0700 (PDT)
\r
20 Received: from [192.168.1.147] (91-158-5-86.elisa-laajakaista.fi
\r
21 [91.158.5.86]) by mail.bustany.org (Postfix) with ESMTPSA id BACFC140230;
\r
22 Thu, 25 Oct 2012 20:43:35 +0200 (CEST)
\r
23 Message-ID: <50898769.2040202@bustany.org>
\r
24 Date: Thu, 25 Oct 2012 21:39:37 +0300
\r
25 From: Adrien Bustany <adrien@bustany.org>
\r
26 User-Agent: Mozilla/5.0 (X11; Linux x86_64;
\r
27 rv:16.0) Gecko/20121009 Thunderbird/16.0
\r
29 To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
30 Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t
\r
31 References: <1342723401-26103-1-git-send-email-adrien@bustany.org>
\r
32 <1350510742-13447-1-git-send-email-adrien@bustany.org>
\r
33 <87vce7yllt.fsf@nikula.org> <87y5j15ekv.fsf@betacantrips.com>
\r
34 In-Reply-To: <87y5j15ekv.fsf@betacantrips.com>
\r
35 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
\r
36 Content-Transfer-Encoding: 8bit
\r
37 Cc: notmuch@notmuchmail.org
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Thu, 25 Oct 2012 18:39:44 -0000
\r
52 Le 20/10/2012 18:49, Ethan Glasser-Camp a écrit :
\r
53 > Jani Nikula <jani@nikula.org> writes:
\r
55 >> On Wed, 17 Oct 2012, Adrien Bustany <adrien@bustany.org> wrote:
\r
56 >>> The code of the patches in unchanged, but the formatting issues are now
\r
57 >>> hopefully fixed.
\r
59 >> Hi Adrien, please check at what version flush and reopen have been
\r
60 >> introduced to xapian. If they are new-ish (I don't know, didn't have the
\r
61 >> time to check), please add appropriate #ifdefs. [1] lays the groundwork
\r
62 >> for this. We'll also need to decide what is the minimum xapian version
\r
63 >> required in general, i.e. features earlier than that don't need
\r
64 >> conditional compilation.
\r
66 > Hi! The new versions of these patches are still pretty trivial and they
\r
67 > still look OK to me, but based on Jani's prompting I decided to look up
\r
68 > the methods. Seems that flush() is a very old (pre-1.1.0, 2009-04) name
\r
69 > for commit(), which is the preferred name these days. You should
\r
70 > probably therefore rename the function notmuch_database_commit, and have
\r
71 > it call the WritableDatabase::commit() method.
\r
73 > reopen() is a very very old method, seems like it has been around since
\r
76 > So I think Adrien is safe from having to do version checks, but we
\r
77 > should probably use commit() instead of flush().
\r
82 Thanks for checking that! Sorry for the late answer, I had a hard time
\r
83 keeping on top of things lately...
\r