Re: Patches for 0.12

[notmuch-archives.git] / eb / d51c4f16e2b228e5abebb595fb898945b81c16

Return-Path: <cworth@cworth.org>\r
X-Original-To: notmuch@notmuchmail.org\r
Delivered-To: notmuch@notmuchmail.org\r
Received: from localhost (localhost [127.0.0.1])\r
        by olra.theworths.org (Postfix) with ESMTP id E0EAF4196F0\r
        for <notmuch@notmuchmail.org>; Mon, 26 Apr 2010 07:59:08 -0700 (PDT)\r
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
X-Spam-Flag: NO\r
X-Spam-Score: -2.89\r
X-Spam-Level: \r
X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
        tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
        autolearn=ham\r
Received: from olra.theworths.org ([127.0.0.1])\r
        by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
        with ESMTP id nzCbtD0VGwHa; Mon, 26 Apr 2010 07:59:08 -0700 (PDT)\r
Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
        by olra.theworths.org (Postfix) with ESMTP id EEDB9431FC1;\r
        Mon, 26 Apr 2010 07:59:07 -0700 (PDT)\r
Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
        id 9A80225400A; Mon, 26 Apr 2010 07:59:07 -0700 (PDT)\r
From: Carl Worth <cworth@cworth.org>\r
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
Subject: Re: [PATCH] emacs: Add notmuch-hello.el,\r
        a friendly frontend to notmuch\r
In-Reply-To: <87ljcaimhv.fsf@ut.hh.sledj.net>\r
References: <87y6gguw99.fsf@yoom.home.cworth.org>\r
        <1271924853-8183-1-git-send-email-dme@dme.org>\r
        <87iq7i2aia.fsf@yoom.home.cworth.org>\r
        <87ljcaimhv.fsf@ut.hh.sledj.net>\r
User-Agent: Notmuch/0.2-192-g42bda00 (http://notmuchmail.org) Emacs/23.1.1\r
        (i486-pc-linux-gnu)\r
Date: Mon, 26 Apr 2010 07:59:07 -0700\r
Message-ID: <87ljcab6pw.fsf@yoom.home.cworth.org>\r
MIME-Version: 1.0\r
Content-Type: multipart/signed; boundary="=-=-=";\r
        micalg=pgp-sha1; protocol="application/pgp-signature"\r
X-BeenThere: notmuch@notmuchmail.org\r
X-Mailman-Version: 2.1.13\r
Precedence: list\r
List-Id: "Use and development of the notmuch mail system."\r
        <notmuch.notmuchmail.org>\r
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
List-Post: <mailto:notmuch@notmuchmail.org>\r
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
X-List-Received-Date: Mon, 26 Apr 2010 14:59:09 -0000\r
\r
--=-=-=\r
Content-Transfer-Encoding: quoted-printable\r
\r
\r
=2D-=20\r
carl.d.worth@intel.com\r
On Mon, 26 Apr 2010 10:36:28 +0100, David Edmondson <dme@dme.org> wrote:\r
> I'll do this, but I wonder if it is actually good advice.\r
\r
My primary point is that all of the implemented functionality,\r
(including notmuch-hello and notmuch-addresses), needs to be made\r
available with our documented approach for loading notmuch in\r
emacs. Currently that's "(require 'notmuch)".\r
\r
We can certainly come up with another approach if there's a better one.\r
\r
> So if `notmuch-folders' is set before notmuch-hello.el is loaded, you\r
> get some saved-searches copied from your folders (but this won't\r
> override any specific settings you made for\r
> `notmuch-hello-saved-searches').\r
\r
OK. That is nice. But also a trick order dependency, yes.\r
\r
> of autoloads in it. Oh, or "(require 'notmuch)" should just load\r
> something that has the autoloads (d'oh!) and some\r
> `define-mail-user-agent' goop so that `compose-mail' does the right\r
> thing.\r
>=20\r
> I'll try to produce a patch for this last thing.\r
\r
Yes, that sounds perfect. I'll look forward to that.\r
\r
> >   * The logo background is gray on my white-background emacs. That\r
> >     looks odd.\r
>=20\r
> Patch sent.\r
\r
Thanks. Pushed.\r
\r
> >   * It would be great if point were in the search bar right when this\r
> >     mode started.\r
>=20\r
> This is customisable, and I see that you changed the default ;-)\r
\r
Yes. I'm still on the fence about this change, (as we are talking in the\r
other thread).\r
\r
> >   * I'd like the saved searches to appear before the recent searches I\r
> >     think.\r
>=20\r
> Did you come to any conclusion about this?\r
\r
The thing I most want is for my saved searches to be extremely easy to\r
select. With notmuch-folder, the view wasn't fancy at all, but it was\r
extremely functional in that the first saved search was under point\r
right away and just C-n/C-p (or arrow keys) could be used to select\r
others.\r
\r
I haven't gotten that same convenience with notmuch-hello yet.\r
\r
> >   * I'm not sure how useful the numbered shortcuts are for the recent\r
> >     searches\r
>=20\r
> Patch sent which removes them.\r
\r
Pushed.\r
\r
> >   * Repeating a recent search by pressing RET on it creates a new\r
> >     identical search which doesn't seem all that useful.\r
>=20\r
> Patch sent.\r
\r
And pushed.\r
\r
> We could have `notmuch-hello' use `notmuch-folders' if\r
> `notmuch-hello-saved-searches' is `nil'. Would that help?\r
\r
Yes, that's what I had in mind here.\r
\r
> > Finally, I'm quite inclined to make `notmuch' invoke this mode, so\r
> > think about that.\r
>=20\r
> It seems straightforward, I'll produce a patch.\r
\r
Excellent. A lot of these would have been easy for me to do of course,\r
but it seems to be working well for you to "own" the coding of our emacs\r
code for now. I really appreciate it!\r
\r
=2DCarl\r
\r
--=-=-=\r
Content-Type: application/pgp-signature\r
\r
-----BEGIN PGP SIGNATURE-----\r
Version: GnuPG v1.4.10 (GNU/Linux)\r
\r
iD8DBQFL1ao76JDdNq8qSWgRAoR/AJ91yxDpaB7JZcPru/I4TtszgWYrIwCeNrgQ\r
jV4S/Lgh+SEBWxDnf/0+gUs=\r
=h3FR\r
-----END PGP SIGNATURE-----\r
--=-=-=--\r