1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2316E431E62
\r
6 for <notmuch@notmuchmail.org>; Thu, 13 Jun 2013 13:19:50 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id N+n5hNPBxFlC for <notmuch@notmuchmail.org>;
\r
16 Thu, 13 Jun 2013 13:19:42 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 94BC1431FC2
\r
20 for <notmuch@notmuchmail.org>; Thu, 13 Jun 2013 13:19:42 -0700 (PDT)
\r
21 X-AuditID: 12074422-b7f746d000001b30-08-51ba295d08fc
\r
22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
\r
23 by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id CA.8D.06960.D592AB15; Thu, 13 Jun 2013 16:19:41 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
\r
26 by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r5DKJeSR014226;
\r
27 Thu, 13 Jun 2013 16:19:41 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5DKJcxv029959
\r
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
33 Thu, 13 Jun 2013 16:19:39 -0400
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1UnDzc-0008Jr-Ro; Thu, 13 Jun 2013 16:19:37 -0400
\r
37 Date: Thu, 13 Jun 2013 16:19:35 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
40 Subject: Re: [PATCH 1/1] test/basic: replaced find -perm +111 with portable
\r
42 Message-ID: <20130613201935.GI22196@mit.edu>
\r
43 References: <1370641049-17390-1-git-send-email-tomi.ollila@iki.fi>
\r
44 <20130610155940.GE22196@mit.edu>
\r
45 <m2r4g56be2.fsf@guru.guru-group.fi>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Content-Disposition: inline
\r
49 In-Reply-To: <m2r4g56be2.fsf@guru.guru-group.fi>
\r
50 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
51 X-Brightmail-Tracker:
\r
52 H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsUixG6nrhunuSvQ4KaKxfWbM5kt3qycx+rA
\r
53 5HH460IWj2erbjEHMEVx2aSk5mSWpRbp2yVwZZz9/oGp4IVgxeQzvA2MTXxdjJwcEgImEjv3
\r
54 PGaBsMUkLtxbz9bFyMUhJLCPUeL2gw2sEM5GRonnFz4yQjinmSQ6t75jh3CWMEr0333NDNLP
\r
55 IqAqsX/pUzCbTUBDYtv+5YwgtoiAisSDtvWsIDazgLTEt9/NTCC2sECkRMOEB2C7eQV0JFoW
\r
56 3ITa3c0ocWH3O1aIhKDEyZlPWCCatSRu/HsJ1MwBNmj5Pw4Qk1PAQOLpXUmQClGgVVNObmOb
\r
57 wCg0C0nzLCTNsxCaFzAyr2KUTcmt0s1NzMwpTk3WLU5OzMtLLdI11cvNLNFLTSndxAgOahel
\r
58 HYw/DyodYhTgYFTi4U24sDNQiDWxrLgy9xCjJAeTkihvusquQCG+pPyUyozE4oz4otKc1OJD
\r
59 jBIczEoivOF/gcp5UxIrq1KL8mFS0hwsSuK8YreAUgLpiSWp2ampBalFMFkZDg4lCd4CDaCh
\r
60 gkWp6akVaZk5JQhpJg5OkOE8QMNngtTwFhck5hZnpkPkTzEac0w+u+U9I8fN91vfMwqx5OXn
\r
61 pUqJ8zaClAqAlGaU5sFNgyWmV4ziQM8J884CqeIBJjW4ea+AVjEBrSrK2A6yqiQRISXVwDiJ
\r
62 622RO9fCHfXdNy4c5nzl17HZepPK0gDFBVnrHQr5yh862Uz7+Emlk/WmJuv+6CU+J1q2BZyQ
\r
63 W5TRsk7KZ6+I/N09MTe1fhR+vv/41kndvqLmhTN7haaqJrpOO7rAi+ePm+zvrpiSnjfMSv+f
\r
64 K6bmNb8LTTjCIWWw8r/kBb+qKMlIw74uYSWW4oxEQy3mouJEAP5cjyAnAwAA
\r
65 Cc: notmuch@notmuchmail.org
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Thu, 13 Jun 2013 20:19:50 -0000
\r
80 Quoth Tomi Ollila on Jun 13 at 10:47 pm:
\r
81 > On Mon, Jun 10 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
83 > > LGTM. Though, I wonder, why not *just* -perm -100? That isn't quite
\r
84 > > a correct test of whether the user can execute it: e.g., if the file
\r
85 > > is owned by some other user and a group the current user isn't in,
\r
86 > > then -perm -1 is the correct test, though unless the file has some
\r
87 > > unusual permissions, -perm -100 is likely to pass anyway. But the
\r
88 > > test you have (and the test that was there before) isn't quite correct
\r
89 > > either: if the file is owned by the current user and has some crazy
\r
90 > > permission like 0611, the user won't be able to execute it, even
\r
91 > > though someone else could.
\r
93 > While giving considerable amount of thought for such an insignificant
\r
94 > issue I came to realize this:
\r
96 > The purpose of the '-perm ...' part in that expression is not to check
\r
97 > whether the file is executable by the user but just to reduce the set
\r
98 > of files the whole expression returns without need to "blacklist" more
\r
99 > files that are already blacklisted with '! -name ...' subexpressions
\r
100 > ("Makefile", ".gitignore" and so on).
\r
102 > With +111, /ppp and their portable alternative
\r
103 > ( -perm -100 -or -perm -10 -or -perm 1 ) the implicit reduction this
\r
104 > part does is smaller than with -100.
\r
106 > The returned list is then compared with ${TESTS} and if there is no
\r
107 > exact match then this particular test fails.
\r
109 > Whatever this test result is, the execution of any file in ${TESTS}
\r
110 > will fail with "permission denied" if it is not executable by
\r
111 > the user running the tests.
\r
113 > I think that as we're doing this "shortcut" instead of full file
\r
114 > blacklisting, this should reduce the output less rather than
\r
115 > more and therefore use the version provided in this patch
\r
116 > instead of changing +111 to -100.
\r
118 > (In the future I'd like to see that we had some convention to name
\r
119 > the test scripts and either do comparison to that list or that
\r
120 > convention also dictates order and this test could be removed. There
\r
121 > are a few alternatives that we could think of...).
\r
125 (I completely agree that the right solution here is switching to a
\r
126 naming convention and eliminating the hand-made list of tests.)
\r