1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8FF5F431FD4
\r
6 for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 12:41:47 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id SbPtB3-+cL4K for <notmuch@notmuchmail.org>;
\r
17 Sun, 17 Nov 2013 12:41:40 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E99AD431FAF
\r
22 for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 12:41:39 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1Vi99l-00030w-0D; Sun, 17 Nov 2013 20:41:21 +0000
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1Vi99k-00035J-LO; Sun, 17 Nov 2013 20:41:20 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Tomi Ollila <tomi.ollila@iki.fi>,
\r
33 Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection
\r
35 In-Reply-To: <m2eh6e7r2n.fsf@guru.guru-group.fi>
\r
36 References: <1384689849-9388-1-git-send-email-markwalters1009@gmail.com>
\r
37 <87siuu95uy.fsf@servo.finestructure.net>
\r
38 <m2eh6e7r2n.fsf@guru.guru-group.fi>
\r
39 User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/23.4.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Sun, 17 Nov 2013 20:41:19 +0000
\r
42 Message-ID: <878uwmvk0g.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-Sender-Host-Address: 93.97.24.31
\r
46 X-QM-Geographic: According to ripencc,
\r
47 this message was delivered by a machine in Britain (UK) (GB).
\r
48 X-QM-SPAM-Info: Sender has good ham record. :)
\r
49 X-QM-Body-MD5: 116b825651404d31647c9062f25b1151 (of first 20000 bytes)
\r
50 X-SpamAssassin-Score: 0.0
\r
51 X-SpamAssassin-SpamBar: /
\r
52 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
54 spam. We require at least 5.0 points to mark a message as spam.
\r
55 This message scored 0.0 points. Summary of the scoring:
\r
56 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
57 provider * (markwalters1009[at]gmail.com)
\r
58 * 0.0 AWL AWL: From: address is in the auto white-list
\r
59 X-QM-Scan-Virus: ClamAV says the message is clean
\r
60 X-BeenThere: notmuch@notmuchmail.org
\r
61 X-Mailman-Version: 2.1.13
\r
63 List-Id: "Use and development of the notmuch mail system."
\r
64 <notmuch.notmuchmail.org>
\r
65 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
67 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
68 List-Post: <mailto:notmuch@notmuchmail.org>
\r
69 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
70 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
72 X-List-Received-Date: Sun, 17 Nov 2013 20:41:47 -0000
\r
75 On Sun, 17 Nov 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
76 > On Sun, Nov 17 2013, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
78 >> On Sun, Nov 17 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
79 >>> In current emacs (24.3) select-active-regions is set to t by
\r
80 >>> default. The reply insertion code sets the region to the quoted
\r
81 >>> message to make it easy to delete (kill-region or C-w). These two
\r
82 >>> things combine to put the quoted message in the primary selection.
\r
84 >>> This is not what the user wanted and is a privacy risk (accidental
\r
85 >>> pasting of the quoted message). We can avoid some of the problems
\r
86 >>> by let-binding select-active-regions to nil. This fixes if the
\r
87 >>> primary selection was previously in a non-emacs window but not if
\r
88 >>> it was in an emacs window. To avoid the problem in the latter case
\r
89 >>> we deactivate mark.
\r
91 >>> One key test (which fails under many simpler "fixes") is: open emacs
\r
92 >>> 24.3 with notmuch, open 2 windows (viewing different notmuch buffers),
\r
93 >>> highlight some text in one, and then reply to a message in the
\r
94 >>> other. In many of my earlier attempts to fix this big this test fails.
\r
96 >> I'm very happy to report that I reply to this message with an unpolluted
\r
97 >> paste buffer! Kudos Mark!
\r
99 >>> Anyway, this is the best I can manage!
\r
101 >> Too modest for such an achievement.
\r
105 > This works for me too (and tests pass).
\r
109 > I don't see how this could break thinks, So I think this is important
\r
110 > enough th be included in 0.17
\r
113 I think the only thing that could break is the ability to cut the quoted
\r
114 message with kill-region/ctrl-w. That is probably minor enough that we
\r
115 do not need to worry too much.
\r