1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 35A9F429E25
\r
6 for <notmuch@notmuchmail.org>; Sun, 30 Oct 2011 17:09:17 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id lzD0RCTb95DP for <notmuch@notmuchmail.org>;
\r
16 Sun, 30 Oct 2011 17:09:16 -0700 (PDT)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id A035E431FB6
\r
20 for <notmuch@notmuchmail.org>; Sun, 30 Oct 2011 17:09:16 -0700 (PDT)
\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by earth-doxen-postvirus (Postfix) with ESMTP id D36E766E00EA;
\r
23 Sun, 30 Oct 2011 17:09:15 -0700 (PDT)
\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
25 Received: from finestructure.net (cpe-76-174-136-149.socal.res.rr.com
\r
26 [76.174.136.149]) (Authenticated sender: jrollins)
\r
27 by earth-doxen-submit (Postfix) with ESMTP id DBAE666E00AE;
\r
28 Sun, 30 Oct 2011 17:09:12 -0700 (PDT)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id 8E0F73A7; Sun, 30 Oct 2011 17:09:12 -0700 (PDT)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH] xutil.c: remove duplicate copies,
\r
34 create new library libutil.a to contain xutil.
\r
35 In-Reply-To: <1319383133-11006-1-git-send-email-david@tethera.net>
\r
36 References: <1319383133-11006-1-git-send-email-david@tethera.net>
\r
37 User-Agent: Notmuch/0.9+37~g17fdf70 (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Sun, 30 Oct 2011 17:09:10 -0700
\r
40 Message-ID: <877h3mowd5.fsf@servo.finestructure.net>
\r
42 Content-Type: multipart/signed; boundary="=-=-=";
\r
43 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Mon, 31 Oct 2011 00:09:17 -0000
\r
59 Content-Transfer-Encoding: quoted-printable
\r
61 On Sun, 23 Oct 2011 12:18:53 -0300, David Bremner <david@tethera.net> wrote:
\r
62 > We keep the lib/xutil.c version. As a consequence, also factor out
\r
63 > _internal_error and associated macros. It might be overkill to make a
\r
64 > new file error_util.c for this, but _internal_error does not really
\r
65 > belong in database.cc.
\r
68 > This turned out to be more disruptive than I thought. On the other
\r
69 > hand, having two copies of xutil.c seems like a recipe for disaster.
\r
70 > I wanted to factor out the logic in xregcomp so I could use it in
\r
71 > situations where miscompilation is not an internal error, but more
\r
72 > likely a user error.
\r
74 Hey, David. Other than the fact that git couldn't digest the encoding
\r
75 of this message, I would say the patch looks very reasonable to me. It
\r
76 looks to me like the right thing to do, and that you're doing it in a
\r
79 Once I got over the encoding issues, this patch applied cleanly and
\r
80 seems to be working fine.
\r
85 Content-Type: application/pgp-signature
\r
87 -----BEGIN PGP SIGNATURE-----
\r
88 Version: GnuPG v1.4.11 (GNU/Linux)
\r
90 iQIcBAEBCAAGBQJOrecmAAoJEO00zqvie6q8TpoP/2BeZgAFo99MCgvvv0bIR/Zm
\r
91 r8GqXg+HCe6N2YysQIfrlhHXmWp3hzdfzK5uh3xofkOp6An33fX458BaOY/epfUn
\r
92 U9PaE6cwu98D5Nby1vTkw4CvolnTNQk5nWy4AGP3iWsKqaZU1zfDyuL2J4sdTOVW
\r
93 uSBH4kgv0iTLJyolqnV8cIG6eMPkYZr00LRl1wj9FES3FcGuMKbsQqQLwyAoTkk0
\r
94 W35cczQ+DJ0BwcSQ7IknT18ZO7kAnRSYL/Aq6AlGqllp6CdRxAz34rfMfcX4CE2A
\r
95 /MG32EUZSDxI+Ar3j85KtWLdRyvidXSjG9u39gBR7hFNsaIWi+WUEJQ2A5EKKTZU
\r
96 +aKiykFSG9X8qElw+Yy+XwMx83mvw+TFFFPDfaJzwpprYTDCPuss1T7bcQx+H4Eo
\r
97 TSuvqEjpcQOof06FCANmNPSDZ3UwCCQG0btJCg9DsEvfBIMf5x7zoGc386Y/Nyfh
\r
98 gxZqasE0OGnsEDYii5sQ+lDvVsniffG1ZM9Jrw8h/LPgA4i9Obmrnvxr2XDojgBa
\r
99 OBeoQqh2gDUmvStE7bNVyoWegC3hDq/X2FnsJn5LSy/vW7W/Vgq4Y/ubRbo4rjfk
\r
100 zeJdoqRjFlar1mj7DsYWFBm6/cy4RhDfgqkUL9XsFyyRXjB7nXFusK6sL8eNQBLa
\r
101 5VgrsOQiyTQgt+cbiLsa
\r
103 -----END PGP SIGNATURE-----
\r