1 Return-Path: <dkg@fifthhorseman.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 24F786DE02C9
\r
6 for <notmuch@notmuchmail.org>; Tue, 8 Dec 2015 07:55:31 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.079 tagged_above=-999 required=5
\r
12 tests=[AWL=-0.079] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id MB5_Grsy_rHu for <notmuch@notmuchmail.org>;
\r
16 Tue, 8 Dec 2015 07:55:29 -0800 (PST)
\r
17 Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 2EB5F6DE0217
\r
19 for <notmuch@notmuchmail.org>; Tue, 8 Dec 2015 07:55:29 -0800 (PST)
\r
20 Received: from fifthhorseman.net (unknown [38.109.115.130])
\r
21 by che.mayfirst.org (Postfix) with ESMTPSA id 5E4A3F984;
\r
22 Tue, 8 Dec 2015 10:55:26 -0500 (EST)
\r
23 Received: by fifthhorseman.net (Postfix, from userid 1000)
\r
24 id 99E9A1FF49; Tue, 8 Dec 2015 10:55:25 -0500 (EST)
\r
25 From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
\r
26 To: Carl Worth <cworth@cworth.org>,
\r
27 notmuch mailing list <notmuch@notmuchmail.org>
\r
28 Subject: Re: NOTMUCH_STATUS_LAST_STATUS problematic across additive library
\r
30 In-Reply-To: <87bna1ms58.fsf@wondoo.home.cworth.org>
\r
31 References: <87y4d5q38i.fsf@alice.fifthhorseman.net>
\r
32 <87vb89n83m.fsf@wondoo.home.cworth.org>
\r
33 <87poyhpzbb.fsf@alice.fifthhorseman.net>
\r
34 <87bna1ms58.fsf@wondoo.home.cworth.org>
\r
35 User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1
\r
36 (x86_64-pc-linux-gnu)
\r
37 Date: Tue, 08 Dec 2015 10:55:25 -0500
\r
38 Message-ID: <87fuzdoryq.fsf@alice.fifthhorseman.net>
\r
40 Content-Type: text/plain
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.20
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Tue, 08 Dec 2015 15:55:31 -0000
\r
55 On Tue 2015-12-08 00:22:11 -0500, Carl Worth wrote:
\r
56 > On Mon, Dec 07 2015, Daniel Kahn Gillmor wrote:
\r
57 >> I note that it's exposed in the go bindings -- maybe it shouldn't be
\r
58 >> exposed in any of the bindings that can avoid exposing it?
\r
60 > Quite likely. It's only there in C because there's no other way to know
\r
61 > the bounds for iterating over all possible values for a particular
\r
62 > enum. If other languages don't have this deficiency, then they shouldn't
\r
63 > need this silly thing.
\r
65 OK, so maybe the following patch should be applied. Perhaps someone who
\r
66 understands the go bindings better than i do can comment on it?
\r
68 The python bindings don't seem to include LAST_STATUS, so i think
\r
73 diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go
\r
74 index 0fff1ab..9f910cb 100644
\r
75 --- a/bindings/go/src/notmuch/notmuch.go
\r
76 +++ b/bindings/go/src/notmuch/notmuch.go
\r
77 @@ -28,8 +28,6 @@ const (
\r
79 STATUS_UNBALANCED_FREEZE_THAW
\r
80 STATUS_UNBALANCED_ATOMIC
\r
82 - STATUS_LAST_STATUS
\r
85 func (self Status) String() string {
\r