1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 5531A6DE024A
\r
6 for <notmuch@notmuchmail.org>; Wed, 27 Apr 2016 11:14:25 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.608 tagged_above=-999 required=5 tests=[AWL=-0.044,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id RZdCQp69-wb1 for <notmuch@notmuchmail.org>;
\r
16 Wed, 27 Apr 2016 11:14:17 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 1AECD6DE01D0
\r
19 for <notmuch@notmuchmail.org>; Wed, 27 Apr 2016 11:14:17 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id E571E100063;
\r
22 Wed, 27 Apr 2016 21:14:12 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 0/4] configure: fix some shellcheck warnings
\r
26 In-Reply-To: <cover.1460572142.git.jani@nikula.org>
\r
27 References: <cover.1460572142.git.jani@nikula.org>
\r
28 User-Agent: Notmuch/0.22+7~g2ab49fe (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Wed, 27 Apr 2016 21:14:12 +0300
\r
34 Message-ID: <m24mamx6kr.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.20
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Wed, 27 Apr 2016 18:14:25 -0000
\r
51 On Wed, Apr 13 2016, Jani Nikula <jani@nikula.org> wrote:
\r
53 > TIL about shellcheck [1]. Played with it a bit. Seems useful.
\r
55 > $ shellcheck --exclude 2086 --shell sh configure
\r
60 > [1] http://www.shellcheck.net/
\r
65 This series looks tolerable to me, with a slight change in first commit msg:
\r
67 > configure: SC2006: Use $(..) instead of deprecated `..`
\r
69 This is what older shellcheck outputs, but newer has fixed this to be
\r
71 configure: SC2006: Use $(..) instead of legacy `..`
\r
73 When testing in http://www.shellcheck.net/
\r
77 ^-- SC2034: foo appears unused. Verify it or export it.
\r
78 ^-- SC2006: Use $(..) instead of legacy `..`.
\r
79 ^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd
\r
82 This is the shellcheck commit (s/deprecated/legacy/ for backtick warnings.):
\r
84 https://github.com/koalaman/shellcheck/commit/895d83afc5f4dec7dc9813a2688c45b96d6f7b7c
\r
86 based on these I suggest commit message amend before pushing (?)
\r
91 > configure: SC2059: Don't use variables in the printf format string.
\r
92 > configure: SC2034: glib_cflags and glib_ldflags appear unused.
\r
93 > configure: SC2016: Expressions don't expand in single quotes
\r
95 > configure | 25 +++++++++++++------------
\r
96 > 1 file changed, 13 insertions(+), 12 deletions(-)
\r