1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 14053431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 20 Sep 2014 01:04:27 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YWUJOs0kGQTl for <notmuch@notmuchmail.org>;
\r
16 Sat, 20 Sep 2014 01:04:21 -0700 (PDT)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 9A1AE431FAE
\r
19 for <notmuch@notmuchmail.org>; Sat, 20 Sep 2014 01:04:21 -0700 (PDT)
\r
20 Received: from localhost (unknown [192.168.200.7])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id 5769D3CFE87;
\r
22 Sat, 20 Sep 2014 10:04:19 +0200 (CEST)
\r
23 X-Virus-Scanned: IMAP STYX AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,
\r
27 with ESMTP id aNw2MiXCtBF5; Sat, 20 Sep 2014 10:04:15 +0200 (CEST)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id 011E33CFE82;
\r
30 Sat, 20 Sep 2014 10:04:14 +0200 (CEST)
\r
31 Received: from wsh by steelpick.2x.cz with local (Exim 4.84)
\r
32 (envelope-from <sojkam1@fel.cvut.cz>)
\r
33 id 1XVFeK-0006AJ-0U; Sat, 20 Sep 2014 10:04:08 +0200
\r
34 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
35 To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
\r
36 notmuch@notmuchmail.org
\r
37 Subject: Re: [PATCH] cli: add --output=address-{from, to,
\r
38 all} to notmuch search
\r
39 In-Reply-To: <87k34zbcy3.fsf@maritornes.cs.unb.ca>
\r
40 References: <871troub1v.fsf@qmul.ac.uk>
\r
41 <1410021689-15901-1-git-send-email-jani@nikula.org>
\r
42 <87k34zbcy3.fsf@maritornes.cs.unb.ca>
\r
43 User-Agent: Notmuch/0.18.1+94~gceee2d7 (http://notmuchmail.org) Emacs/24.3.1
\r
44 (x86_64-pc-linux-gnu)
\r
45 Date: Sat, 20 Sep 2014 10:04:08 +0200
\r
46 Message-ID: <87tx427m6f.fsf@steelpick.2x.cz>
\r
48 Content-Type: text/plain
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Sat, 20 Sep 2014 08:04:27 -0000
\r
63 On Fri, Sep 19 2014, David Bremner wrote:
\r
64 > Jani Nikula <jani@nikula.org> writes:
\r
66 >> + if (name && *name)
\r
67 >> + full_address = talloc_asprintf (NULL, "%s <%s>", name, addr);
\r
69 >> + full_address = talloc_asprintf (NULL, "<%s>", addr
\r
71 > Is there some reason not to use sprinter as a talloc context here?
\r
74 >> + if (!full_address)
\r
77 > Is the error here out of memory? Maybe an error message would be a good
\r
81 > Obviously the docs need to be updated as well, and ideally the tests. I
\r
82 > think Jani was hinting that he didn't want to be the person to do
\r
83 > that. Any volunteers?
\r
85 Yes, I'll look at that. It will probably take me a few days.
\r