1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 075E7429E55
\r
6 for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 18:49:03 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id eCTasQcmKWQG for <notmuch@notmuchmail.org>;
\r
17 Tue, 28 Jun 2011 18:49:02 -0700 (PDT)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 52DD5429E32
\r
22 for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 18:49:02 -0700 (PDT)
\r
23 Received: by bwg12 with SMTP id 12so712327bwg.26
\r
24 for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 18:49:00 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:date:message-id:x-mailer;
\r
27 bh=EbcKXl4TxMzy51pNPl0n9NxheqXFFfcUd8UYBOxM0mg=;
\r
28 b=WtJ6mUISAxCGe7UYgcIv2GOCKXdQ6QeHkTmZIk8BXR0ZJm0zurFysOcC6MZvVTysz7
\r
29 MTWpZihEdZ684bffP+YAzzm4/s+V+TX32f1OtW6msUV437EftJcsiQQ/5VvT8N2fNIkq
\r
30 AdZGSSPcJHvUM//YsWtEYOR0k+f4i26GvrCls=
\r
31 Received: by 10.204.14.208 with SMTP id h16mr196328bka.35.1309312140729;
\r
32 Tue, 28 Jun 2011 18:49:00 -0700 (PDT)
\r
33 Received: from localhost ([91.144.186.21])
\r
34 by mx.google.com with ESMTPS id n3sm692880bka.4.2011.06.28.18.48.58
\r
35 (version=TLSv1/SSLv3 cipher=OTHER);
\r
36 Tue, 28 Jun 2011 18:48:59 -0700 (PDT)
\r
37 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
38 To: notmuch@notmuchmail.org
\r
39 Subject: [PATCH 1/3] test: `notmuch-show-advance-and-archive' with invisible
\r
41 Date: Wed, 29 Jun 2011 05:48:50 +0400
\r
42 Message-Id: <1309312132-14564-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
43 X-Mailer: git-send-email 1.7.5.4
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Wed, 29 Jun 2011 01:49:03 -0000
\r
58 Add Emacs test to check that `notmuch-show-advance-and-archive'
\r
59 works for the last message in thread with invisible signature.
\r
62 This patch series fixes the bug reported by Sebastien in [1]. I
\r
63 was able to reproduce it and confirm that the second patch from
\r
64 this series fixes the problem. Unfortunately, I can not explain
\r
65 why it fixes it. The patch uses a cleaner approach for visible
\r
66 text search. But the old approach should work fine as well.
\r
67 Apparently, it does not work when `invisible' property is not a
\r
68 single symbol but a list (which was changed in
\r
69 95ef8da29439f2e79115c36ab4d2a80aef1a1462). I suspect that it is
\r
70 an Emacs bug. I plan to look at it later.
\r
72 Another issue is that the test does not demonstrate the bug.
\r
73 Again, I do not really know why. It passes both before and after
\r
74 the fix. Although if I run the test commands by hand I hit the
\r
75 bug. I guess it has something to do with emacs daemon mode when
\r
76 the buffer is not visible. I hope someone with a better elisp
\r
77 knowledge can tell what is going on and how to make the test
\r
80 I believe patches 2 and 3 can be pushed after review even without
\r
86 [1] id:"8739j5rn2d.fsf@cern.ch"
\r
88 test/emacs | 12 ++++++++++++
\r
89 1 files changed, 12 insertions(+), 0 deletions(-)
\r
91 diff --git a/test/emacs b/test/emacs
\r
92 index e59de47..65a96a5 100755
\r
95 @@ -347,4 +347,16 @@ test_emacs '(notmuch-show "id:f35dbb950911171438k5df6eb56k77b6c0944e2e79ae@mail.
\r
96 (test-visible-output)'
\r
97 test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-with-hidden-messages
\r
99 +test_begin_subtest 'notmuch-show-advance-and-archive with invisible signature'
\r
100 +message1='id:20091118010116.GC25380@dottiness.seas.harvard.edu'
\r
101 +message2='id:1258491078-29658-1-git-send-email-dottedmag@dottedmag.net'
\r
102 +test_emacs "(notmuch-search \"$message1 or $message2\")
\r
103 + (notmuch-test-wait)
\r
104 + (notmuch-search-show-thread)
\r
105 + (notmuch-show-advance-and-archive)
\r
107 +test_emacs "(notmuch-show \"$message2\")
\r
108 + (test-output \"EXPECTED\")"
\r
109 +test_expect_equal_file OUTPUT EXPECTED
\r