1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 5A3D5431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 21 Nov 2012 19:48:20 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YGGxCD0MhcSW for <notmuch@notmuchmail.org>;
\r
16 Wed, 21 Nov 2012 19:48:16 -0800 (PST)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 74773431FAF
\r
21 for <notmuch@notmuchmail.org>; Wed, 21 Nov 2012 19:48:16 -0800 (PST)
\r
22 Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([156.34.89.108] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa
\r
25 (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
\r
26 (envelope-from <bremner@unb.ca>)
\r
27 id 1TbNls-00032L-It; Wed, 21 Nov 2012 23:48:13 -0400
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
29 (envelope-from <bremner@unb.ca>)
\r
30 id 1TbNlm-0000xz-Ry; Wed, 21 Nov 2012 23:48:06 -0400
\r
31 From: David Bremner <david@tethera.net>
\r
32 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH v3 1/2] notmuch-show.el: import calendar data with public
\r
34 function after CR removal
\r
35 In-Reply-To: <1352376480-29961-2-git-send-email-tomi.ollila@iki.fi>
\r
36 References: <1352376480-29961-1-git-send-email-tomi.ollila@iki.fi>
\r
37 <1352376480-29961-2-git-send-email-tomi.ollila@iki.fi>
\r
38 User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Wed, 21 Nov 2012 23:48:06 -0400
\r
41 Message-ID: <87vccywb61.fsf@zancas.localnet>
\r
43 Content-Type: text/plain
\r
45 Cc: tomi.ollila@iki.fi
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Thu, 22 Nov 2012 03:48:20 -0000
\r
60 Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
62 > notmuch-get-bodypart-content provides raw data to its caller so
\r
63 > that it can be stored verbatim whenever needed. icalendar functions
\r
64 > expect Emacs to do EOL conversion for the data given to these. Therefore
\r
65 > it the CRLF -> LF conversion is now done explicitly.
\r
67 > The calls to private functions icalendar--convert-ical-to-diary and
\r
68 > icalendar--read-element are replaced with call to public function
\r
69 > icalendar-import-buffer.
\r
71 This code looks straightforward to me. Any objections to merging?
\r