e7/7030e9b967b318534509fdb1f1584163075c55

   1 Return-Path: <mpn@google.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1C760431FB6\r
   6         for <notmuch@notmuchmail.org>; Tue,  4 Dec 2012 15:04:29 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7]\r
  13         autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id hUfUVEivfuzQ for <notmuch@notmuchmail.org>;\r
  17         Tue,  4 Dec 2012 15:04:28 -0800 (PST)\r
  18 Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
  19  [74.125.83.53])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
  20  certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
  21  D171B431FAE    for <notmuch@notmuchmail.org>; Tue,  4 Dec 2012 15:04:27 -0800\r
  22  (PST)\r
  23 Received: by mail-ee0-f53.google.com with SMTP id c50so2976152eek.26\r
  24         for <notmuch@notmuchmail.org>; Tue, 04 Dec 2012 15:04:26 -0800 (PST)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\r
  26  s=20120113;    h=sender:from:to:subject:in-reply-to:organization:references\r
  27         :user-agent:x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
  28         :content-type; bh=u0LD3WivIfOhPL3atoskyCoPNIG1E+pLO96zYm/YYXk=;\r
  29         b=p3hp9Btm/BX5qBtwHDZ7hXn2JMIxSL7DAbNhGZSrNJfCjrilSkHRwPmgJd5cocOJrd\r
  30         dQ9m0hSd1hfwT2qCiF2CJcA5ogfSiJMb9bkbDYAgpHQiN6maQzDoRWg851fp11q7m2t3\r
  31         6mNZv4yGGqoF6xmmUhj0J009Mk3D84Rlr2FuB2MrI+XqGM+9oZPcYV87BPSSIsX53kXt\r
  32         CNDV7yF6KTB/VJ/BuCAewwKol9yDAp0TnYVoulmdJT5g85WLzXorAGjVmgVHDqUvSPxs\r
  33         o6dtYUsPd9WGHqqfOHQYqN49yksK27Js3XDrxg/MAsiU4IWaJbMsxu7kA9ptYAAEj5m/    SbRQ==\r
  34 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  35         d=google.com; s=20120113;\r
  36         h=sender:from:to:subject:in-reply-to:organization:references\r
  37         :user-agent:x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
  38         :content-type:x-gm-message-state;\r
  39         bh=u0LD3WivIfOhPL3atoskyCoPNIG1E+pLO96zYm/YYXk=;\r
  40         b=R+QlhdkkQoPnfIofvgk3fkQAPdDbBcDqUhLwnD5RCa7v14CdakveUl/BCcrST5EYYC\r
  41         xTwJzN6vWDRRbWuW6xWFOJQP83UlF5P398B+h9bHueNce2kv5PzBuuzFi568OpNyUmDh\r
  42         UrzsQy9kLZLtizLNQkN+ErT/eeRfP1d8tDp+S9JEycXJ1/t8LVfz0XzSW9HfJnfbUum7\r
  43         /JYptdR18BfbUIptQd1t0iVr5iHuJmd4mwBTI74um4C5samxMRUqMe9dOGIFf9WdPgZ7\r
  44         q4uHIemhyOsSnqAL5R1VMchiBN9vSaMHa+xevCHjvoVoR5ETqOg0YmBkSXeFn9wqGYtv\r
  45         8XHA==\r
  46 Received: by 10.14.208.137 with SMTP id q9mr53317980eeo.28.1354662266603;\r
  47         Tue, 04 Dec 2012 15:04:26 -0800 (PST)\r
  48 Received: from mpn-glaptop ([2620:0:105f:5:8c95:2fd8:feb2:1f3c])\r
  49         by mx.google.com with ESMTPS id k2sm5413621eep.15.2012.12.04.15.04.25\r
  50         (version=TLSv1/SSLv3 cipher=OTHER);\r
  51         Tue, 04 Dec 2012 15:04:25 -0800 (PST)\r
  52 Sender: Michal Nazarewicz <mpn@google.com>\r
  53 From: Michal Nazarewicz <mina86@mina86.com>\r
  54 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
  55 Subject: Re: [PATCH 1/3] test: fix count test\r
  56 In-Reply-To:\r
  57  <0ca075ab5fb0d886d0235c1f0549db8b0b14c9b5.1354656085.git.jani@nikula.org>\r
  58 Organization: http://mina86.com/\r
  59 References: <cover.1354656085.git.jani@nikula.org>\r
  60         <0ca075ab5fb0d886d0235c1f0549db8b0b14c9b5.1354656085.git.jani@nikula.org>\r
  61 User-Agent: Notmuch/ (http://notmuchmail.org) Emacs/24.2.50.1\r
  62         (x86_64-unknown-linux-gnu)\r
  63 X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;        KFrfMCylc}gc??'U2j,!8%xdD\r
  64 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC\r
  65 X-PGP: 50751FF4\r
  66 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4\r
  67 Date: Wed, 05 Dec 2012 00:04:20 +0100\r
  68 Message-ID: <xa1tfw3l2zd7.fsf@mina86.com>\r
  69 MIME-Version: 1.0\r
  70 Content-Type: multipart/mixed; boundary="=-=-="\r
  71 X-Gm-Message-State: ALoCoQll6laYoKpAh56sLieFOYOMyjMUl9OuRwAloxmoHD0nbXnWhgJbckWZhDLMP/O+uGETszkIcTSTX2dZs2NJaBYYcx+RaL9I/Hrx6MW74rScawbPe0GI507AkU4OGL+/iYzIjgWdaS1PGGx5g6mOil8psRqHsUvESZTFW84FmcevVAlCSPIJiiMH6x6IMvYrYHE0uWymTTMbpNbATNuhEoAQl/l2/Q==\r
  72 X-BeenThere: notmuch@notmuchmail.org\r
  73 X-Mailman-Version: 2.1.13\r
  74 Precedence: list\r
  75 List-Id: "Use and development of the notmuch mail system."\r
  76         <notmuch.notmuchmail.org>\r
  77 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  78         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  79 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  80 List-Post: <mailto:notmuch@notmuchmail.org>\r
  81 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  82 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  83         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  84 X-List-Received-Date: Tue, 04 Dec 2012 23:04:29 -0000\r
  85 \r
  86 --=-=-=\r
  87 Content-Type: text/plain; charset=utf-8\r
  88 Content-Transfer-Encoding: quoted-printable\r
  89 \r
  90 On Tue, Dec 04 2012, Jani Nikula wrote:\r
  91 > The quoting for ${SEARCH} is broken when it's supposed to be '*', and\r
  92 \r
  93 Why is it broken?  It does not appear to be broken to me and in fact the\r
  94 test passes.\r
  95 \r
  96 > it seems tricky to get it right. Just drop the variable and use '*'\r
  97 > directly. Before this, none of the messages ever matched, and the test\r
  98 > was comparing zeros.\r
  99 > ---\r
 100 >  test/count |   23 ++++++++++-------------\r
 101 >  1 file changed, 10 insertions(+), 13 deletions(-)\r
 102 >\r
 103 > diff --git a/test/count b/test/count\r
 104 > index 300b171..8e587ff 100755\r
 105 > --- a/test/count\r
 106 > +++ b/test/count\r
 107 > @@ -4,37 +4,34 @@ test_description=3D'"notmuch count" for messages and th=\r
 108 reads'\r
 109 >=20=20\r
 110 >  add_email_corpus\r
 111 >=20=20\r
 112 > -SEARCH=3D"\"*\""\r
 113 > -\r
 114 >  test_begin_subtest "message count is the default for notmuch count"\r
 115 >  test_expect_equal \\r
 116 > -    "`notmuch search --output=3Dmessages ${SEARCH} | wc -l`" \\r
 117 > -    "`notmuch count ${SEARCH}`"\r
 118 > +    "`notmuch search --output=3Dmessages '*' | wc -l`" \\r
 119 > +    "`notmuch count '*'`"\r
 120 >=20=20\r
 121 >  test_begin_subtest "message count with --output=3Dmessages"\r
 122 >  test_expect_equal \\r
 123 > -    "`notmuch search --output=3Dmessages ${SEARCH} | wc -l`" \\r
 124 > -    "`notmuch count --output=3Dmessages ${SEARCH}`"\r
 125 > +    "`notmuch search --output=3Dmessages '*' | wc -l`" \\r
 126 > +    "`notmuch count --output=3Dmessages '*'`"\r
 127 >=20=20\r
 128 >  test_begin_subtest "thread count with --output=3Dthreads"\r
 129 >  test_expect_equal \\r
 130 > -    "`notmuch search --output=3Dthreads ${SEARCH} | wc -l`" \\r
 131 > -    "`notmuch count --output=3Dthreads ${SEARCH}`"\r
 132 > +    "`notmuch search --output=3Dthreads '*' | wc -l`" \\r
 133 > +    "`notmuch count --output=3Dthreads '*'`"\r
 134 >=20=20\r
 135 >  test_begin_subtest "thread count is the default for notmuch search"\r
 136 >  test_expect_equal \\r
 137 > -    "`notmuch search ${SEARCH} | wc -l`" \\r
 138 > -    "`notmuch count --output=3Dthreads ${SEARCH}`"\r
 139 > +    "`notmuch search '*' | wc -l`" \\r
 140 > +    "`notmuch count --output=3Dthreads '*'`"\r
 141 >=20=20\r
 142 > -SEARCH=3D"from:cworth and not from:cworth"\r
 143 >  test_begin_subtest "count with no matching messages"\r
 144 >  test_expect_equal \\r
 145 >      "0" \\r
 146 > -    "`notmuch count --output=3Dmessages ${SEARCH}`"\r
 147 > +    "`notmuch count --output=3Dmessages from:cworth and not from:cworth`"\r
 148 >=20=20\r
 149 >  test_begin_subtest "count with no matching threads"\r
 150 >  test_expect_equal \\r
 151 >      "0" \\r
 152 > -    "`notmuch count --output=3Dthreads ${SEARCH}`"\r
 153 > +    "`notmuch count --output=3Dthreads from:cworth and not from:cworth`"\r
 154 >=20=20\r
 155 >  test_done\r
 156 \r
 157 --=20\r
 158 Best regards,                                         _     _\r
 159 .o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o\r
 160 ..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =\r
 161  (o o)\r
 162 ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--\r
 163 --=-=-=\r
 164 Content-Type: multipart/signed; boundary="==-=-=";\r
 165         micalg=pgp-sha1; protocol="application/pgp-signature"\r
 166 \r
 167 --==-=-=\r
 168 Content-Type: text/plain\r
 169 \r
 170 \r
 171 --==-=-=\r
 172 Content-Type: application/pgp-signature\r
 173 \r
 174 -----BEGIN PGP SIGNATURE-----\r
 175 Version: GnuPG v1.4.11 (GNU/Linux)\r
 176 \r
 177 iQIcBAEBAgAGBQJQvoF0AAoJECBgQBJQdR/09hQP/R0VhofnHUmYXItJWr2bOBZB\r
 178 3ExhvQLH3/vOeKSf0kwU/rBwUod2yEVBC9nSJyztPmi2vDUI7QBwxi2IEOG7ophW\r
 179 8ko4lBk6ibc6f48eqBHExP1eB6MIUn2L/oQA+uED/WmTac9nVXP566+0t+SKpYBJ\r
 180 z26peegUP20JNHk4RK3EPBw/xP54MVwBmjD8I4TQFUv5nXUMoftrQ7Ax4g4QmFdq\r
 181 a2IFhCGf6w5owWEpqMV/gr1DBGOQGFtGZicHascA/SIIZ/5eqnqdC9c25TS5bU84\r
 182 fOn0N8L9uKYn04Gw6vcmKcTqdNwRM2e3jDCKS0AAdIuw7zuAsG3yxHaqGF7MxwzD\r
 183 sJzJg+ml49ZKuQIVCtz5jkTFgeIrLjokwbQuREivDpQkW3Uc8Em6KfzB+Cibq3Bw\r
 184 65mfSCWlacWfaPWNYY/2Lb+y5e6NMN0JTwZfLSuJRcBjM+FfEuazsQXs1QDd0uJS\r
 185 Q2NzRsa1gm3dcodqV4pHVWtAOgIRwuVOKKFa5m7aqPQPPxO8WcQb2Mp1u0CfKWnV\r
 186 sOTYEQ6mgKLTmFKjOpvsaANgsNhGLktQViYmeR7B7jrhiQKGIExNYgfH9DIIJeMh\r
 187 sH3zfoW5uJn6w+Z1h79O7E55XiQM/xKF5c1BHJ3KbIC9Emz+DhlkVaqNR2xkqe8/\r
 188 sn3kud6sKU/ZnCi0CZ0S\r
 189 =ZF8K\r
 190 -----END PGP SIGNATURE-----\r
 191 --==-=-=--\r
 192 \r
 193 --=-=-=--\r