e2/77ab24be59217226ebe3d476f7c846b0a7cabe

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 55D9E431FB6\r
   6         for <notmuch@notmuchmail.org>; Fri,  4 May 2012 11:38:27 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id T7kMg6Sq7jRc for <notmuch@notmuchmail.org>;\r
  16         Fri,  4 May 2012 11:38:26 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
  18         [18.9.25.13])\r
  19         by olra.theworths.org (Postfix) with ESMTP id B051B431FAE\r
  20         for <notmuch@notmuchmail.org>; Fri,  4 May 2012 11:38:26 -0700 (PDT)\r
  21 X-AuditID: 1209190d-b7fbf6d0000008ba-72-4fa42221b4d0\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 18.47.02234.12224AF4; Fri,  4 May 2012 14:38:25 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q44IcOep024226; \r
  27         Fri, 4 May 2012 14:38:25 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q44IcNZh007947\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Fri, 4 May 2012 14:38:24 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SQNOY-0005I4-Vn; Fri, 04 May 2012 14:38:23 -0400\r
  37 Date: Fri, 4 May 2012 14:38:22 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Justus Winter <4winter@informatik.uni-hamburg.de>\r
  40 Subject: Re: [PATCH 1/5] go: reorganize the go bindings\r
  41 Message-ID: <20120504183822.GN2704@mit.edu>\r
  42 References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>\r
  43         <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
  44 MIME-Version: 1.0\r
  45 Content-Type: text/plain; charset=us-ascii\r
  46 Content-Disposition: inline\r
  47 In-Reply-To:\r
  48  <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
  49 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hTV1lVUWuJvcGWnlcXs1h9MFtdvzmR2\r
  52         YPKYeP40m8ezVbeYA5iiuGxSUnMyy1KL9O0SuDI6Pl1kL3jFWnH/733GBsZrLF2MHBwSAiYS\r
  53         nyfHdjFyApliEhfurWfrYuTiEBLYxyjx4tAPFghnPaNE+/sXUM4JJomZW+cyQjhLGCVmP7zM\r
  54         BjKKRUBF4v8MZZBRbAIaEtv2L2cEsUUETCU2PHjADmIzC0hLfPvdzARiCwuYS8ye8pINxOYV\r
  55         0JboX/4danUHo8TPs01MEAlBiZMzn7BANGtJ3Pj3kglkF8ig5f84QExOgSCJs69zQCpEgS6Y\r
  56         cnIb2wRGoVlImmchaZ6F0LyAkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRrpFebmaJXmpK6SZG\r
  57         cFBL8u5gfHdQ6RCjAAejEg9vJu8SfyHWxLLiytxDjJIcTEqivAHyQCG+pPyUyozE4oz4otKc\r
  58         1OJDjBIczEoivElfF/sL8aYkVlalFuXDpKQ5WJTEeVW13vkJCaQnlqRmp6YWpBbBZGU4OJQk\r
  59         ePMVgYYKFqWmp1akZeaUIKSZODhBhvMADRcGqeEtLkjMLc5Mh8ifYtTlmDdl61VGIZa8/LxU\r
  60         KXHecpAiAZCijNI8uDmwZPSKURzoLWHeOJAqHmAig5v0CmgJE9ASaYNFIEtKEhFSUg2M11+5\r
  61         xzm2Fr6acv1i+V+59SYVa8O2zanquv9dj/OzhJbruwNL79rPe640hXvZoa9b5/kWsLX99DU7\r
  62         l97erB80mZff8dzC1sviCX+6hexbLJVaVlyWWFx3Unu96KM4/pCyyfFm9V1va08s5DhhvPAY\r
  63         91Qf1wdt95utj7K/fSEwrfyuytKV032blFiKMxINtZiLihMBv5H5XyEDAAA=\r
  64 Cc: notmuch@notmuchmail.org\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Fri, 04 May 2012 18:38:27 -0000\r
  78 \r
  79 Quoth Justus Winter on Apr 30 at  9:55 pm:\r
  80 > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r
  81 \r
  82 Whole series LGTM (and yay gofmt!).  I have only two minor comments.\r
  83 \r
  84 It would be nice to have a little more log message for some of these.\r
  85 Mostly the first one could use some explanation of why you're\r
  86 rearranging the source tree and a mention that there are no changes to\r
  87 the files (since this is hard to get from the diff).\r
  88 \r
  89 It would also be nice if this could optionally be built using the\r
  90 libnotmuch and notmuch.h directly from the source tree containing the\r
  91 Go bindings, rather than requiring them to be installed system-wide.\r
  92 I don't know Go 1's build system well enough to know if there's an\r
  93 easy way to do this.\r