1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3A2F5431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 2 Dec 2012 02:11:15 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.201 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
\r
14 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id OQHCU0M+gbPm for <notmuch@notmuchmail.org>;
\r
18 Sun, 2 Dec 2012 02:11:14 -0800 (PST)
\r
19 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
20 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id ABE7A431FAE
\r
23 for <notmuch@notmuchmail.org>; Sun, 2 Dec 2012 02:11:14 -0800 (PST)
\r
24 Received: by mail-we0-f181.google.com with SMTP id t11so851520wey.26
\r
25 for <notmuch@notmuchmail.org>; Sun, 02 Dec 2012 02:11:13 -0800 (PST)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
27 h=from:to:cc:subject:date:message-id:x-mailer;
\r
28 bh=3ymxTMJP7uRdSAq+Abd7TPtRGMDJtV32j4aZPjvYiWM=;
\r
29 b=AgwAWioqE8szHien4GQG+vl1NqveI9IM6CdKQcZbyMQx3xpFDGpjacdQJad7RAOQ6x
\r
30 mWLkgaiKg8xvgwmEtFXzk/KJy/oLvUx++Kcik7Ly50yyw9eQ80UyCEUer95TsC0sb+jo
\r
31 oSbc51E9+hEID05PiRKqSPGo8OfDoB5cU83JwzA9/MUt5xHiirNZcvvG8lhAEkHxhe/4
\r
32 u6t6uuhWMPQtl9lEL5usDEiu97WcBUuWKyGnNkBRAYY/yOblzDGElfAWNUNwOhz7n/t9
\r
33 hMnPqDs1nFeqkQJbV4ZEln3VETH9Zim2fv3vrLNtcdEvyoQPR5CzCLmWCdxT4GVuu83P
\r
35 Received: by 10.216.70.70 with SMTP id o48mr2335581wed.59.1354443072043;
\r
36 Sun, 02 Dec 2012 02:11:12 -0800 (PST)
\r
37 Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])
\r
38 by mx.google.com with ESMTPS id i2sm6243272wiw.3.2012.12.02.02.11.09
\r
39 (version=TLSv1/SSLv3 cipher=OTHER);
\r
40 Sun, 02 Dec 2012 02:11:10 -0800 (PST)
\r
41 From: Mark Walters <markwalters1009@gmail.com>
\r
42 To: notmuch@notmuchmail.org
\r
43 Subject: [PATCH] emacs: stash bugfix
\r
44 Date: Sun, 2 Dec 2012 10:11:08 +0000
\r
45 Message-Id: <1354443068-5030-1-git-send-email-markwalters1009@gmail.com>
\r
46 X-Mailer: git-send-email 1.7.9.1
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Sun, 02 Dec 2012 10:11:15 -0000
\r
61 Currently an attempt to stash a non-existent field (eg cc when not
\r
62 present) throws an error. Catch this case and give the user a warning
\r
66 While messing around with notmuch-pick key bindings I found the
\r
67 following bug. The easiest way I have found to trigger it is cc
\r
68 (stash-cc) in show mode on a message with no cc header.
\r
74 emacs/notmuch-lib.el | 7 +++++--
\r
75 1 files changed, 5 insertions(+), 2 deletions(-)
\r
77 diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
\r
78 index 1d0ec17..c7d8e02 100644
\r
79 --- a/emacs/notmuch-lib.el
\r
80 +++ b/emacs/notmuch-lib.el
\r
81 @@ -183,8 +183,11 @@ user-friendly queries."
\r
83 (defun notmuch-common-do-stash (text)
\r
84 "Common function to stash text in kill ring, and display in minibuffer."
\r
86 - (message "Stashed: %s" text))
\r
90 + (message "Stashed: %s" text))
\r
91 + (message "Warning: Nothing to stash!")))
\r