e0/075203e039863956dbc0264cf537a4d6bc6d4c

   1 Return-Path: <aclements@csail.mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 15715431FAF\r
   6         for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 19:40:05 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id bCBmSWFYAqqO for <notmuch@notmuchmail.org>;\r
  16         Sun,  9 Jun 2013 19:39:57 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu\r
  18         [18.7.68.37])\r
  19         by olra.theworths.org (Postfix) with ESMTP id F286B431FAE\r
  20         for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 19:39:56 -0700 (PDT)\r
  21 X-AuditID: 12074425-b7f966d00000454c-0b-51b53c7ce65a\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 22.65.17740.C7C35B15; Sun,  9 Jun 2013 22:39:56 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id r5A2dsFn028828; \r
  27         Sun, 9 Jun 2013 22:39:55 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5A2dqd8002769\r
  32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  33         Sun, 9 Jun 2013 22:39:54 -0400\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  35         (envelope-from <aclements@csail.mit.edu>)\r
  36         id 1Uls1Q-00069q-N2; Sun, 09 Jun 2013 22:39:52 -0400\r
  37 Date: Sun, 9 Jun 2013 22:39:52 -0400\r
  38 From: Austin Clements <aclements@csail.mit.edu>\r
  39 To: Mark Walters <markwalters1009@gmail.com>\r
  40 Subject: Re: [PATCH v4 0/5] emacs: show: lazy handling of hidden parts\r
  41 Message-ID: <20130610023952.GC22196@mit.edu>\r
  42 References: <1370074547-24677-1-git-send-email-markwalters1009@gmail.com>\r
  43 MIME-Version: 1.0\r
  44 Content-Type: text/plain; charset=us-ascii\r
  45 Content-Disposition: inline\r
  46 In-Reply-To: <1370074547-24677-1-git-send-email-markwalters1009@gmail.com>\r
  47 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  48 X-Brightmail-Tracker:\r
  49  H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42IR4hRV1q2x2RpocP6mmMWRPbPYLVbP5bG4\r
  50         fnMmswOzx85Zd9k9nq26xezR9GMxawBzFJdNSmpOZllqkb5dAlfGuo5JbAX3OCoWbrzN0sDY\r
  51         xt7FyMEhIWAiseBqSRcjJ5ApJnHh3nq2LkYuDiGBfYwSnctAakCcDYwS015+gHJOMUnsXvMT\r
  52         ylnNKPF3yX5WkH4WARWJic//M4LYbAL6EivWTgKLiwjoSNw+tIAdxGYWcJbY96mTDcQWFnCT\r
  53         OL18OSvIGbxANatn14GEhQQ8JZqWngMr4RUQlDg58wkLRKuWxI1/L5lAypkFpCWW/+MACXMK\r
  54         eEls+XkGrFwU6IIpJ7exTWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbp\r
  55         WujlZpbopaaUbmIEhTm7i+oOxgmHlA4xCnAwKvHwdvzYEijEmlhWXJl7iFGSg0lJlPe82dZA\r
  56         Ib6k/JTKjMTijPii0pzU4kOMEhzMSiK8Py2BcrwpiZVVqUX5MClpDhYlcd4bKTf9hQTSE0tS\r
  57         s1NTC1KLYLIyHBxKErznrYEaBYtS01Mr0jJzShDSTBycIMN5gIbfBanhLS5IzC3OTIfIn2JU\r
  58         lBLnvQ+SEABJZJTmwfXC0tArRnGgV4R5X4FU8QBTGFz3K6DBTECDp6hvARlckoiQkmpgNG1a\r
  59         YfAzXvbd6qR5m6Vc5H8tZ5qzhZn7k1juu/a0eY9+W0Uf3prpcr9YNPvKkvXPm2boy2Y07zgS\r
  60         KOd6x3DpfJNtGareXmeDn6x7c3LNjLkBB3XOxhv1L9X+arp4l9GcYFb3u5Fzwp/caDl/+JXW\r
  61         H8Gq5TzHtsu8utMkudIidlfeQ6sX79oeiSqxFGckGmoxFxUnAgD6wALXHgMAAA==\r
  62 X-Mailman-Approved-At: Mon, 10 Jun 2013 01:19:52 -0700\r
  63 Cc: notmuch@notmuchmail.org\r
  64 X-BeenThere: notmuch@notmuchmail.org\r
  65 X-Mailman-Version: 2.1.13\r
  66 Precedence: list\r
  67 List-Id: "Use and development of the notmuch mail system."\r
  68         <notmuch.notmuchmail.org>\r
  69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  72 List-Post: <mailto:notmuch@notmuchmail.org>\r
  73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  75         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  76 X-List-Received-Date: Mon, 10 Jun 2013 02:40:05 -0000\r
  77 \r
  78 Quoth Mark Walters on Jun 01 at  9:15 am:\r
  79 > This is version 4 of this series. Version 3 is at\r
  80 > id:1370024806-6616-1-git-send-email-markwalters1009@gmail.com\r
  81 > \r
  82 > Changes from version 3 are: fix the whitespace changes in patch 3/5,\r
  83 > store both the start of the part and the start of the content in\r
  84 > insert-bodypart (Austin's part handler series needs one and I need the\r
  85 > other) and fixed the missing save-excursion in patch 4/5.\r
  86 > \r
  87 > Finally, there is one more substantial change: rebasing on to Austin's\r
  88 > part handler (now in master). There was a little more to this than I\r
  89 > expected so for anyone testing please use this version.\r
  90 \r
  91 This series LGTM except for one bug (also related to my new part\r
  92 handling, sorry): after expanding a lazy part, the "." submap doesn't\r
  93 work within that part because it doesn't get the :notmuch-part\r
  94 property applied to it.  I'm not sure what the best solution to this\r
  95 is.  Maybe applying :notmuch-part should be moved to\r
  96 notmuch-show-create-part-overlays?\r
  97 \r
  98 Also, unrelated: with this series, do we wind up creating a second\r
  99 overlay when a lazy part is shown?\r