1 Return-Path: <amthrax@drake.mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B3E84431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 21 Apr 2012 21:27:54 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 5rf3vVrGw-xb for <notmuch@notmuchmail.org>;
\r
16 Sat, 21 Apr 2012 21:27:54 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 2B6FF431FAE
\r
20 for <notmuch@notmuchmail.org>; Sat, 21 Apr 2012 21:27:54 -0700 (PDT)
\r
21 X-AuditID: 12074423-b7fea6d0000074b0-f0-4f9388c9f221
\r
22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
\r
23 by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 1F.77.29872.9C8839F4; Sun, 22 Apr 2012 00:27:53 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q3M4Rrt1019367;
\r
27 Sun, 22 Apr 2012 00:27:53 -0400
\r
28 Received: from drake.mit.edu
\r
29 (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com
\r
30 [209.6.116.242]) (authenticated bits=0)
\r
31 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
32 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3M4RqKI011055
\r
33 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
34 Sun, 22 Apr 2012 00:27:52 -0400 (EDT)
\r
35 Received: from amthrax by drake.mit.edu with local (Exim 4.77)
\r
36 (envelope-from <amthrax@drake.mit.edu>)
\r
37 id 1SLoOu-0003I6-0p; Sun, 22 Apr 2012 00:27:52 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: notmuch@notmuchmail.org
\r
40 Subject: [PATCH v2 1/4] new: Consistently treat fatal errors as fatal
\r
41 Date: Sun, 22 Apr 2012 00:27:45 -0400
\r
42 Message-Id: <1335068868-12593-2-git-send-email-amdragon@mit.edu>
\r
43 X-Mailer: git-send-email 1.7.9.1
\r
44 In-Reply-To: <1335068868-12593-1-git-send-email-amdragon@mit.edu>
\r
45 References: <1330357759-1337-1-git-send-email-amdragon@mit.edu>
\r
46 <1335068868-12593-1-git-send-email-amdragon@mit.edu>
\r
47 X-Brightmail-Tracker:
\r
48 H4sIAAAAAAAAA+NgFtrEIsWRmVeSWpSXmKPExsUixG6nrnuyY7K/waNL8hbXb85kdmD0eLbq
\r
49 FnMAYxSXTUpqTmZZapG+XQJXRuuJE8wF0wUrJk9uYWlg3MrbxcjJISFgIvFnxxYmCFtM4sK9
\r
50 9WxdjFwcQgL7GCXO9b1hgXA2MEo82vWFHcK5zySx9dh1VpAWIYH5jBJPztSD2GwCGhLb9i9n
\r
51 BLFFBKQldt6dDVTDwcEsoCbxp0sFJCws4Cqx+Mx5sBIWAVWJJ+fvsoHYvAIOEmvO3WWBuEJB
\r
52 4tm642AXcQo4Six+eZwRYlWZRNPLZYwTGPkXMDKsYpRNya3SzU3MzClOTdYtTk7My0st0jXT
\r
53 y80s0UtNKd3ECA4aF+UdjH8OKh1iFOBgVOLhfWUy2V+INbGsuDL3EKMkB5OSKK9+JVCILyk/
\r
54 pTIjsTgjvqg0J7X4EKMEB7OSCO9nEaAcb0piZVVqUT5MSpqDRUmcV0PrnZ+QQHpiSWp2ampB
\r
55 ahFMVoaDQ0mC1wkYHUKCRanpqRVpmTklCGkmDk6Q4TxAw5+3gwwvLkjMLc5Mh8ifYlSUEucV
\r
56 AWkWAElklObB9cKi+hWjONArwrxGIFU8wIQA1/0KaDAT0OCEmEkgg0sSEVJSDYxzpZYn2emm
\r
57 s4dmfJy//OMnpxnnbua92lqnO7V2zi325oh3X08y3vlb+0Dh44HFpzafvXCudvJ8bU2b3XLq
\r
58 JdsYF+7ardHBM//c7cDKnJCNm1avbVm82mqyCOORRF+r3brLtaeWLdibJfl+0S39tNeCrwTf
\r
59 Gjv5ynE7eF1pEzfzNLonFxAcqXlTiaU4I9FQi7moOBEA1HLA08UCAAA=
\r
60 X-BeenThere: notmuch@notmuchmail.org
\r
61 X-Mailman-Version: 2.1.13
\r
63 List-Id: "Use and development of the notmuch mail system."
\r
64 <notmuch.notmuchmail.org>
\r
65 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
67 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
68 List-Post: <mailto:notmuch@notmuchmail.org>
\r
69 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
70 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
72 X-List-Received-Date: Sun, 22 Apr 2012 04:27:54 -0000
\r
74 Previously, fatal errors in add_files_recursive were not treated as
\r
75 fatal by its callers (including itself!). This makes
\r
76 add_files_recursive errors consistently fatal and updates all callers
\r
77 to treat them as fatal.
\r
79 notmuch-new.c | 16 ++++++++++++----
\r
80 1 files changed, 12 insertions(+), 4 deletions(-)
\r
82 diff --git a/notmuch-new.c b/notmuch-new.c
\r
83 index 4f13535..15c0b36 100644
\r
86 @@ -308,6 +308,10 @@ add_files_recursive (notmuch_database_t *notmuch,
\r
87 if (num_fs_entries == -1) {
\r
88 fprintf (stderr, "Error opening directory %s: %s\n",
\r
89 path, strerror (errno));
\r
90 + /* We consider this a fatal error because, if a user moved a
\r
91 + * message from another directory that we were able to scan
\r
92 + * into this directory, skipping this directory will cause
\r
93 + * that message to be lost. */
\r
94 ret = NOTMUCH_STATUS_FILE_ERROR;
\r
97 @@ -351,8 +355,10 @@ add_files_recursive (notmuch_database_t *notmuch,
\r
99 next = talloc_asprintf (notmuch, "%s/%s", path, entry->d_name);
\r
100 status = add_files_recursive (notmuch, next, state);
\r
101 - if (status && ret == NOTMUCH_STATUS_SUCCESS)
\r
106 talloc_free (next);
\r
109 @@ -933,6 +939,8 @@ notmuch_new_command (void *ctx, int argc, char *argv[])
\r
112 ret = add_files (notmuch, db_path, &add_files_state);
\r
116 gettimeofday (&tv_start, NULL);
\r
117 for (f = add_files_state.removed_files->head; f && !interrupted; f = f->next) {
\r
118 @@ -965,6 +973,7 @@ notmuch_new_command (void *ctx, int argc, char *argv[])
\r
123 talloc_free (add_files_state.removed_files);
\r
124 talloc_free (add_files_state.removed_directories);
\r
125 talloc_free (add_files_state.directory_mtimes);
\r
126 @@ -1012,10 +1021,9 @@ notmuch_new_command (void *ctx, int argc, char *argv[])
\r
131 - printf ("\nNote: At least one error was encountered: %s\n",
\r
133 + printf ("\nNote: A fatal error was encountered: %s\n",
\r
134 notmuch_status_to_string (ret));
\r
137 notmuch_database_close (notmuch);
\r