da/9e24963fe5f5720df11b9518c272f51924d3b0

   1 Return-Path: <mpn@google.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 70DCA431FAE\r
   6         for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 17:52:03 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.8\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.8 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id p-4Fla5HpsFP for <notmuch@notmuchmail.org>;\r
  17         Mon, 27 Aug 2012 17:52:01 -0700 (PDT)\r
  18 Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
  19  [74.125.83.53])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
  20  certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
  21  5A5A7431FB6    for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 17:52:01 -0700\r
  22  (PDT)\r
  23 Received: by eekb47 with SMTP id b47so1379770eek.26\r
  24         for <notmuch@notmuchmail.org>; Mon, 27 Aug 2012 17:52:00 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\r
  26  s=20120113;\r
  27         h=from:to:cc:subject:in-reply-to:organization:references:user-agent\r
  28         :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version        :content-type;\r
  29  bh=Z6CIdN4bKt3Y8Tw2efw8SA5Jfi2LZ5f5HavbBOR/jrc=;\r
  30         b=N6WQJzWSlxEuYx2Z678qpU/aeHQqKoXanL9ftZabLsso3ScIf0nmgEhJnLFgf/5/7R\r
  31         NCqvM6dAlA/PEObFv0nVz9or7AMJ81yy8CLl9XgBOwOnpcC3gJG5qouO20ssR8/SEBdy\r
  32         grQbG2dy+Mslboz45cNGJGkM2PghRSZSTZZ9aWmsGgueSrzHNlT7dmSfciecHV10Ue6K\r
  33         11KNVAb/fuIBNdFftCy5DilC07Jx9AE1Z7TXSf5gawCHWjPKmtP2gXfQAeLJim3LPnV5\r
  34         Az3oZWuNl9bQNFQBlUklRIAouykQKLRG2G2EaJduDJbJ6AnRfLo8590B6Q49FTG8yvmJ    uvVw==\r
  35 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  36         d=google.com; s=20120113;\r
  37         h=from:to:cc:subject:in-reply-to:organization:references:user-agent\r
  38         :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version\r
  39         :content-type:x-gm-message-state;\r
  40         bh=Z6CIdN4bKt3Y8Tw2efw8SA5Jfi2LZ5f5HavbBOR/jrc=;\r
  41         b=EtlD8u+HHkL8oBq+eBPWNp8Awq36QIxUtQGGZgFEn/kHfTsQk640bXaZOOsaTfJyDc\r
  42         xSmNOmdBe7ePTJjNCeuDq7Og9r3aMLhjQ7N1eGX8PcND1P3xxLhpwhZub2iXJxfMz49r\r
  43         0cE4qrsl1AQIjdWQwTvm9H1/irgKnQSrjrionTklZS59LozNv8+9MPX1id6F0rK2LXXT\r
  44         UVEQTF250jr6PYh4vrGT35Q4gyKwSk28/BECTKzYC5CuNQIikiN00vXzQgmWo0D2HhDe\r
  45         CQIB05Xo/BbpaY6eiI9Cl+Ducs1mrNpeZMsYHpZLcKnkL/WNNm0EbvXF22/J1KMxmMvx\r
  46         Nh6Q==\r
  47 Received: by 10.14.202.71 with SMTP id c47mr532248eeo.42.1346115120217;\r
  48         Mon, 27 Aug 2012 17:52:00 -0700 (PDT)\r
  49 Received: by 10.14.202.71 with SMTP id c47mr532236eeo.42.1346115120076;\r
  50         Mon, 27 Aug 2012 17:52:00 -0700 (PDT)\r
  51 Received: from mpn-glaptop ([2620:0:105f:5:f2de:f1ff:fe35:1a72])\r
  52         by mx.google.com with ESMTPS id 45sm56577867eeb.8.2012.08.27.17.51.57\r
  53         (version=TLSv1/SSLv3 cipher=OTHER);\r
  54         Mon, 27 Aug 2012 17:51:58 -0700 (PDT)\r
  55 From: Michal Nazarewicz <mpn@google.com>\r
  56 To: Austin Clements <amdragon@MIT.EDU>\r
  57 Subject: Re: [PATCH] emacs: notmuch-search: fix faces\r
  58 In-Reply-To: <20120828002215.GB11179@mit.edu>\r
  59 Organization: Google Inc\r
  60 References:\r
  61  <83882f4c8de5317e0184dc091a197b2341e5f015.1345725028.git.mina86@mina86.com>\r
  62         <87ipc4jcfv.fsf@servo.finestructure.net>        <xa1t3938ue0m.fsf@mina86.com>\r
  63  <20120828002215.GB11179@mit.edu>\r
  64 User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1\r
  65         (x86_64-unknown-linux-gnu)\r
  66 X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;        KFrfMCylc}gc??'U2j,!8%xdD\r
  67 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC\r
  68 X-PGP: 50751FF4\r
  69 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4\r
  70 Date: Tue, 28 Aug 2012 02:51:49 +0200\r
  71 Message-ID: <xa1twr0ju9cq.fsf@mina86.com>\r
  72 MIME-Version: 1.0\r
  73 Content-Type: multipart/mixed; boundary="=-=-="\r
  74 X-Gm-Message-State: ALoCoQk10MTOjvLSwMVhHcJtDKK2arIWzpcHwXrTUMyOVRDUfmPbBKlFhEcDSGhrP+IyrDlgSrxiumczyC8ij+kWSLnD8v3q34x5z+IxDcYQG1u4+VKEiZAZvDiFPCEIq9oEwBVGeGAccwbgKvGycAYy0QbTXIhNy5ZWx7vjhdoQnkHPSKBew6Ym48JX5Ga+FDs+gnC6U+9ycRVfhbbgpBIxW9npWz5FgA==\r
  75 Cc: notmuch@notmuchmail.org\r
  76 X-BeenThere: notmuch@notmuchmail.org\r
  77 X-Mailman-Version: 2.1.13\r
  78 Precedence: list\r
  79 List-Id: "Use and development of the notmuch mail system."\r
  80         <notmuch.notmuchmail.org>\r
  81 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  82         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  83 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  84 List-Post: <mailto:notmuch@notmuchmail.org>\r
  85 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  86 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  87         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  88 X-List-Received-Date: Tue, 28 Aug 2012 00:52:03 -0000\r
  89 \r
  90 --=-=-=\r
  91 Content-Type: text/plain; charset=utf-8\r
  92 Content-Transfer-Encoding: quoted-printable\r
  93 \r
  94 > Quoth Michal Nazarewicz on Aug 28 at  1:11 am:\r
  95 >> I'm not an expert either, but with this patch applied I see colours,\r
  96 >> without this patch, I don't see colours, ie. everything is rendered\r
  97 >> using the default face.\r
  98 >>=20\r
  99 >> I'm also not entirely sure if that's the correct way of doing things\r
 100 >> since 'face seems to be working in other modes (most notably\r
 101 >> notmuch-show).  By posting, I'm also hoping that someone more\r
 102 >> experienced will maybe take a look to see what's going on here... ;)\r
 103 >>=20\r
 104 >> For some more info, in notmuch-show mode, I get-text-property of nil for\r
 105 >> both 'face and 'font-lock-face, but in message-mode or in *scratch*\r
 106 >> buffer I'm getting nil for 'font-lock-face but non-nil for 'face.  With\r
 107 >> the patch, I'm getting the same non-nil for both 'face and\r
 108 >> 'font-lock-face; without the patch, I'm getting nil for both.\r
 109 \r
 110 Austin Clements <amdragon@MIT.EDU> writes:\r
 111 > This is odd.  Could you give more details about your environment?  In\r
 112 > particular, what Emacs version are you running and might you have any\r
 113 > unusual Emacs packages installed or customizations set?\r
 114 \r
 115 I'm running Emacs compiled from a week old bzr head, emacs-version\r
 116 reports: =E2=80=9CGNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08=\r
 117 -21\r
 118 on mpn-glaptop=E2=80=9D.\r
 119 \r
 120 I don't think I have any =E2=80=9Cunusual=E2=80=9D packages, but I do have =\r
 121 quite a bit\r
 122 of customization, which you might find at\r
 123 <https://github.com/mina86/dot-files/blob/master/dot-emacs>.\r
 124 \r
 125 > The unusual thing about font-lock-face is that it only gets applied if\r
 126 > font-lock is enabled; otherwise it's ignored.  One theory is that the\r
 127 > nil font-lock-face (without your patch) is causing font-lock to\r
 128 > *override* the face property that we set.  I don't think font-lock\r
 129 > usually does that, but perhaps in some situations, it will?\r
 130 \r
 131 Ha!  That could be the cause.  I've disabled global-font-lock-mode, and\r
 132 the colours appeared.  Getting property returns non-nil for 'face and\r
 133 nil for 'font-lock-face.  When I enable font-lock-mode the property seem\r
 134 to disappear and disabling font-lock-mode again does not help.\r
 135 \r
 136 --=20\r
 137 Best regards,                                         _     _\r
 138 .o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o\r
 139 ..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =\r
 140  (o o)\r
 141 ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--\r
 142 --=-=-=\r
 143 Content-Type: multipart/signed; boundary="==-=-=";\r
 144         micalg=pgp-sha1; protocol="application/pgp-signature"\r
 145 \r
 146 --==-=-=\r
 147 Content-Type: text/plain\r
 148 \r
 149 \r
 150 --==-=-=\r
 151 Content-Type: application/pgp-signature\r
 152 \r
 153 -----BEGIN PGP SIGNATURE-----\r
 154 Version: GnuPG v1.4.10 (GNU/Linux)\r
 155 \r
 156 iQIcBAEBAgAGBQJQPBYlAAoJECBgQBJQdR/0EJ0P/38g1ch0y6r7rKRZwXS3r+9a\r
 157 T0JEQorWG7BLW7M3HIc+0WWWkX1hMBVcELcRwnTP1UfZjd/eBlPfpjlaID5Ridpd\r
 158 dMcWQuiSO+w6gJ2CBxOhu+c68uyh2N9aiJQkymEZ1/tRTdkq5mS26QWUaiR9KFpe\r
 159 aKXnXLhYKzttDwQrEv+YL9pbPm3Onu+SJfLpUMmyU2Sx9j/0TmXkT4YajAuWqnlW\r
 160 xQUNdNHT9/uMCWNhHpDUnp9TkCoN+txT8P42GPEYN7oLBq+UF8RpRELLGvBmMUa2\r
 161 PMmJlBrNQ7hZzubSs365nxRn9AZ7AwdTibygCkxqLGXGOb7csebSQrlIxELwySIR\r
 162 oqrEM2VBX8rNWiNFKK3I4xSoiwEwh2qBOJzK/nD9I7/FeEDzfuwPJYG70f2Qg/YY\r
 163 KALuplvmjp9i8tu4N/70x5wuxI3SLgtwJFLkn4EBB6uYXAzRWdOEqintLaXB4/JT\r
 164 cqNIrVmxnlldKiKXsEIhZSuoDK1IlxIXjliBItRE3WFKNB726YIVN/W3VADpbQfQ\r
 165 87abX7Xb9a/HwbgQXetc8XQPpWJHCSCaa8aQsbPNSbb5PJXqD2OyUUBdzsOPEqC6\r
 166 xmHHTb+fDfSyxs7CmQGGQN4cUkEPElzSBv6U/xmKpVbgmpNo+huhDSSw18ABBYGK\r
 167 a/QlQXI25Gpxvdre5Z8u\r
 168 =oFrd\r
 169 -----END PGP SIGNATURE-----\r
 170 --==-=-=--\r
 171 \r
 172 --=-=-=--\r