1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DD2FF431FC3
\r
6 for <notmuch@notmuchmail.org>; Fri, 5 Jul 2013 11:11:34 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=2.7 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
\r
14 FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id nQ1q41pI1wGJ for <notmuch@notmuchmail.org>;
\r
18 Fri, 5 Jul 2013 11:11:27 -0700 (PDT)
\r
19 Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com
\r
20 [209.85.215.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 1ABD0431FAE
\r
23 for <notmuch@notmuchmail.org>; Fri, 5 Jul 2013 11:11:26 -0700 (PDT)
\r
24 Received: by mail-ea0-f179.google.com with SMTP id b15so1653545eae.10
\r
25 for <notmuch@notmuchmail.org>; Fri, 05 Jul 2013 11:11:24 -0700 (PDT)
\r
26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
27 h=from:to:cc:subject:date:message-id:x-mailer;
\r
28 bh=FGeebwwnnJzxm5/NZuazHwYMbIhxMhV2LFSgtPv7VzY=;
\r
29 b=Yeiw5x0mT1jAtJ3U/ubpnWS3Gb6lMaYjr14dH+UfJC8dBBNnVLkKFnQvV0HjC5nyUX
\r
30 AytRO2EPBibLv6syZGiEyaaHJ0+vEcKCejy03CaVL65p/HpjOLEdEbBbWzu1RhiNQypK
\r
31 6AI7XEkaCft92v0YJgtp6rUFEtjzRZNkJc0KLNavWB6wExkoJ8tc6BIxChoWEX12Q/3n
\r
32 YsWnans4iVMlp9xC0+42ov+EU8enKTz3e3bkgyPzBF0xW7JJYXeQHdtvOT9mVCHQxkKW
\r
33 jDrvc2Z9j0zVKUsec+yMuKLx+0uYeHOo1+dqfMHLhkuigSYKHPliJufMtXxjpj2l9zUs
\r
35 X-Received: by 10.14.203.194 with SMTP id f42mr13612898eeo.53.1373047884516;
\r
36 Fri, 05 Jul 2013 11:11:24 -0700 (PDT)
\r
37 Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])
\r
38 by mx.google.com with ESMTPSA id i2sm15993446eeu.4.2013.07.05.11.11.23
\r
39 for <multiple recipients>
\r
40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
41 Fri, 05 Jul 2013 11:11:24 -0700 (PDT)
\r
42 From: Mark Walters <markwalters1009@gmail.com>
\r
43 To: notmuch@notmuchmail.org
\r
44 Subject: [PATCH 00/11] contrib: pick: keybindings
\r
45 Date: Fri, 5 Jul 2013 19:11:07 +0100
\r
46 Message-Id: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com>
\r
47 X-Mailer: git-send-email 1.7.9.1
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Fri, 05 Jul 2013 18:11:35 -0000
\r
62 This series adds lots of keybindings and funtionality to pick: in
\r
63 particular it adds the stash keymap, the ability to tab between and
\r
64 activate buttons in the message pane, and it reduces a lot of code
\r
65 duplication between pick and show.
\r
67 It is a large series: but most of it is a lot of small changes. These
\r
68 small changes are mostly logically independent but as they add
\r
69 keybindings their contexts all clash. I have made most of the
\r
70 keybindings as single separate patches to make discussion of them
\r
71 individually easier.
\r
73 The key patches for review/discussion (apart from bike-shedding on
\r
74 key-bindings!) are patches 1, 5 and 8.
\r
76 Patch 1 is the most "controversial": it over-rides
\r
77 notmuch-show-get-prop so that whether it uses
\r
78 notmuch-show-get-message-properties or
\r
79 notmuch-pick-get-message-properties depends on the major-mode (ie
\r
80 whether it is called from pick or show).
\r
82 This means that functions from show which just use message properties
\r
83 (most often just the message id) "just work" when called from pick. In
\r
84 particular it gives us access to lots of functions without having to
\r
87 In the longer term it would be better to have some show/pick common
\r
88 file and migrate the common functions there.
\r
90 Patch 5 and 8 add in functions for creating fucntions ready to be used
\r
91 in keybindings. The one in patch 5 takes a show fucntion and creates a
\r
92 function which switches from pick to the message pane, applies the
\r
93 function and then switches back to pick. The one in patch 8 takes a
\r
94 function and creates a function which closes the message pane and the
\r
95 calls this function.
\r
97 Both of these make the keybinding section clearer. They also have the
\r
98 advantage that the user can use them easily to create their own
\r
99 keybindings which do this.
\r
101 This completes all the keybindings I use and I think means that pick
\r
102 doesn't have any glaring omissions.
\r
104 Finally, this will clash with the thread archive patches
\r
105 id:1371195472-441-1-git-send-email-markwalters1009@gmail.com
\r
112 contrib: pick: override notmuch-show-get-prop
\r
113 contrib: pick: Link in notmuch-show-pipe-message
\r
114 contrib: pick: Link in attachment functions straight from
\r
116 contrib: pick: Link in stash map straight from notmuch-show
\r
117 contrib: pick: add in to-message-window function
\r
118 contrib: pick: add button press helper
\r
119 contrib: pick: pass tab through to the message pane
\r
120 contrib: pick: close window function
\r
121 contrib: pick: make help close the message pane first
\r
122 contrib: pick: add in binding to view raw message
\r
123 contrib: pick: use close-message-pane for reply etc
\r
125 contrib/notmuch-pick/notmuch-pick.el | 139 +++++++++++++++++-----------------
\r
126 1 files changed, 70 insertions(+), 69 deletions(-)
\r