1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4A36A429E34
\r
6 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 21:00:01 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Odp1eDQs8fTn for <notmuch@notmuchmail.org>;
\r
16 Sun, 29 Jan 2012 20:59:59 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 6971F431FBC
\r
20 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 20:59:59 -0800 (PST)
\r
21 X-AuditID: 12074424-b7fae6d000000906-98-4f2623ce36e9
\r
22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
23 by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id A0.4D.02310.EC3262F4; Sun, 29 Jan 2012 23:59:58 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0U4xvOD013047;
\r
27 Sun, 29 Jan 2012 23:59:58 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0U4xu2D000317
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Sun, 29 Jan 2012 23:59:57 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1RrjKe-0000WW-9f; Sun, 29 Jan 2012 23:59:08 -0500
\r
37 Date: Sun, 29 Jan 2012 23:59:08 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
40 Subject: Re: [PATCH v2 11/13] emacs: code cleanup in
\r
41 `notmuch-show-operate-all', no functional changes
\r
42 Message-ID: <20120130045908.GO17991@mit.edu>
\r
43 References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
45 <1327890382-548-12-git-send-email-dmitry.kurochkin@gmail.com>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Content-Disposition: inline
\r
49 In-Reply-To: <1327890382-548-12-git-send-email-dmitry.kurochkin@gmail.com>
\r
50 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
51 X-Brightmail-Tracker:
\r
52 H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1j2nrOZv8GShucXVrf3sFtdvzmR2
\r
53 YPLYOesuu8ezVbeYA5iiuGxSUnMyy1KL9O0SuDIubJ3PUrCHr+LJvX3sDYwrubsYOTkkBEwk
\r
54 fhw9yAhhi0lcuLeerYuRi0NIYB+jxJHO5+wQzgZGiW1Hp4JVCQmcZJJ48c4dIrGEUaJl21l2
\r
55 kASLgKrEmodTWEFsNgENiW37l4M1iAgYSty6+IoZxGYWkJb49ruZCcQWFsiQePfiJFgvr4CO
\r
56 xK95XSwQQ08wSrS/XcEMkRCUODnzCQtEs5bEjX8vgZo5wAYt/8cBEuYU8JJYNP062F5RARWJ
\r
57 KSe3sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Zrr5WaW6KWmlG5i
\r
58 BAU2u4vKDsbmQ0qHGAU4GJV4eAP/qfoLsSaWFVfmHmKU5GBSEuV1UVLzF+JLyk+pzEgszogv
\r
59 Ks1JLT7EKMHBrCTC++gnUDlvSmJlVWpRPkxKmoNFSZxXQ+udn5BAemJJanZqakFqEUxWhoND
\r
60 SYL3P8hQwaLU9NSKtMycEoQ0EwcnyHAeoOGcwEQgxFtckJhbnJkOkT/FqCglzvsBpFkAJJFR
\r
61 mgfXC0s8rxjFgV4R5n0BUsUDTFpw3a+ABjMBDX7OAHJ1cUkiQkqqgXGS1/evHH93f1fZrXhC
\r
62 vlYz7Ctfi7N+n+Av5y//Pt2x1/3d0bVcVeFqa/NpBmMRja2yri8Kg2aJMT3OZXb+ffPLrwN9
\r
63 R6ZUbZn4bOmjg1fWRRtKTtqafaigzMJ4mXCvZeVMw1svQyfdX9rqXtCTujJJTDY33Ero4YRg
\r
64 yUl9a2VV66MltD8K+iuxFGckGmoxFxUnAgBl00MDFwMAAA==
\r
65 Cc: notmuch@notmuchmail.org
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Mon, 30 Jan 2012 05:00:01 -0000
\r
80 notmuch-show-tag-all, in the first line of the commit message.
\r
82 As in the previous patch, if the previous patch comes earlier in the
\r
83 series, notmuch-show-tag-all could be written this way initially.
\r
85 Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:
\r
86 > Use `notmuch-show-mapc' function instead of a custom `loop'.
\r
88 > emacs/notmuch-show.el | 13 ++++++-------
\r
89 > 1 files changed, 6 insertions(+), 7 deletions(-)
\r
91 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
92 > index b115a8f..69381ac 100644
\r
93 > --- a/emacs/notmuch-show.el
\r
94 > +++ b/emacs/notmuch-show.el
\r
95 > @@ -1516,13 +1516,12 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
96 > TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
97 > (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))
\r
98 > (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)
\r
100 > - (goto-char (point-min))
\r
101 > - (loop do (let* ((current-tags (notmuch-show-get-tags))
\r
102 > - (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
103 > - (unless (equal current-tags new-tags)
\r
104 > - (notmuch-show-set-tags new-tags)))
\r
105 > - while (notmuch-show-goto-message-next))))
\r
106 > + (notmuch-show-mapc
\r
108 > + (let* ((current-tags (notmuch-show-get-tags))
\r
109 > + (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
110 > + (unless (equal current-tags new-tags)
\r
111 > + (notmuch-show-set-tags new-tags))))))
\r
113 > (defun notmuch-show-add-tag ()
\r
114 > "Same as `notmuch-show-tag' but sets initial input to '+'."
\r
117 Austin Clements MIT/'06/PhD/CSAIL
\r
118 amdragon@mit.edu http://web.mit.edu/amdragon
\r
119 Somewhere in the dream we call reality you will find me,
\r
120 searching for the reality we call dreams.
\r