1 Return-Path: <awg@xvx.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 110EC431FAF
\r
6 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 10:19:11 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 37Op8aS+FQvV for <notmuch@notmuchmail.org>;
\r
16 Tue, 10 Apr 2012 10:19:10 -0700 (PDT)
\r
17 Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com
\r
18 [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 6025C431FAE
\r
21 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 10:19:10 -0700 (PDT)
\r
22 Received: by lban1 with SMTP id n1so29267lba.26
\r
23 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 10:19:07 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=mime-version:sender:x-originating-ip:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding:x-gm-message-state;
\r
29 bh=RmK15CgDOaxHQUxV0R6lktB+/EI9jc3Pht79iQChkBQ=;
\r
30 b=ChyU1bnPkccHX2Ut14W7oezqKx1Q+eVkJu21mLMTWkLlrpqUrPKCbXzylxFYTbQPey
\r
31 tBL3L0EyUdsginHjHBWDXgR6T0jwSiQUjMmwf+nlEq2+QpSJB7mp7FpAOuY9pjN71C0/
\r
32 9rD6k56+QSO19H24N9CalRJqH3HVeD8gfOKk4rG2YIDV7g1DsX7wZAGRPCsyfcMNP5Zy
\r
33 B+LjOBl+XBEzLIbT0E0U92sXjsyOZrI0PK5WvIcGKonB0PN9UUocHPsTeUz2PE5YZjOT
\r
34 /a99EtTSflXHaS/WL8zV2VnW88nzdPL3F56jiP6O2GoFiNxcPNh0R4Viwyh9GhBJx1fp
\r
37 Received: by 10.152.129.137 with SMTP id nw9mr15497086lab.48.1334078347148;
\r
38 Tue, 10 Apr 2012 10:19:07 -0700 (PDT)
\r
40 Received: by 10.112.97.14 with HTTP; Tue, 10 Apr 2012 10:19:07 -0700 (PDT)
\r
41 X-Originating-IP: [128.221.197.57]
\r
42 In-Reply-To: <1334077496-9172-2-git-send-email-markwalters1009@gmail.com>
\r
43 References: <1334077496-9172-1-git-send-email-markwalters1009@gmail.com>
\r
44 <1334077496-9172-2-git-send-email-markwalters1009@gmail.com>
\r
45 Date: Tue, 10 Apr 2012 11:19:07 -0600
\r
46 X-Google-Sender-Auth: miHml0up6etN5Qa3Wty8sH66Ur8
\r
48 <CAMoJFUuXmLQR+awJnPKg8ZJAKbHbPAmSrEUVoFj_=dZ76WiKzw@mail.gmail.com>
\r
49 Subject: Re: [PATCH 1/2] cli: make --entire-thread=false work for format=json.
\r
50 From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
51 To: Mark Walters <markwalters1009@gmail.com>
\r
52 Content-Type: text/plain; charset=ISO-8859-1
\r
53 Content-Transfer-Encoding: quoted-printable
\r
55 ALoCoQmgf5OsmTko++xAXGX/AgSYPyMdsIMmBG3Sg0uXqX/tCqW47k0OQBO9Zy/0MOZXtV7qpWpi
\r
56 Cc: notmuch@notmuchmail.org
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Tue, 10 Apr 2012 17:19:11 -0000
\r
73 This looks good to me, but I haven't tested it. It's probably worth
\r
74 adding a test for the new functionality.
\r
76 One style issue below, which is a matter of taste and I'll defer to
\r
77 others if they disagree:
\r
79 On Tue, Apr 10, 2012 at 11:04, Mark Walters <markwalters1009@gmail.com> wro=
\r
81 > @@ -895,10 +905,11 @@ show_messages (void *ctx,
\r
82 > =A0 =A0 =A0 =A0 =A0 =A0if (status && !res)
\r
83 > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0res =3D status;
\r
84 > =A0 =A0 =A0 =A0 =A0 =A0next_indent =3D indent + 1;
\r
85 > + =A0 =A0 =A0 } else
\r
86 > + =A0 =A0 =A0 =A0 =A0 status =3D show_null_message (format);
\r
88 I accept, but don't particularly like, the notmuch style of omitting
\r
89 braces where they aren't required. However, an else with a brace on
\r
90 only one side just looks weird. If they're like this everywhere else
\r
91 then I guess it's best to be consistent, but to me it's a lot more
\r
92 readable as } else {.
\r
94 As I said above, I'll defer to others' judgement here, just thought it
\r
95 was worth pointing out.
\r