1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 89C6F429E50
\r
6 for <notmuch@notmuchmail.org>; Wed, 14 Dec 2011 15:21:00 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 8NNrh6RQIb6s for <notmuch@notmuchmail.org>;
\r
16 Wed, 14 Dec 2011 15:21:00 -0800 (PST)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id F17DF429E4E
\r
21 for <notmuch@notmuchmail.org>; Wed, 14 Dec 2011 15:20:59 -0800 (PST)
\r
22 Received: from zancas.localnet
\r
23 (fctnnbsc36w-156034079193.pppoe-dynamic.High-Speed.nb.bellaliant.net
\r
24 [156.34.79.193]) (authenticated bits=0)
\r
25 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id pBENKL5a031074
\r
26 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
\r
27 Wed, 14 Dec 2011 19:20:22 -0400
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.77)
\r
29 (envelope-from <bremner@unb.ca>)
\r
30 id 1Ray7Z-0003KP-0Q; Wed, 14 Dec 2011 19:20:21 -0400
\r
31 From: David Bremner <david@tethera.net>
\r
32 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [Alpha Patch 2/2] test: update dump-restore tests for 8 bit
\r
35 In-Reply-To: <87pqfqubzd.fsf@gmail.com>
\r
36 References: <1323808075-7417-7-git-send-email-david@tethera.net>
\r
37 <1323893641-4677-1-git-send-email-david@tethera.net>
\r
38 <1323893641-4677-2-git-send-email-david@tethera.net>
\r
39 <87pqfqubzd.fsf@gmail.com>
\r
40 User-Agent: Notmuch/0.10.2+80~g144897e (http://notmuchmail.org) Emacs/23.3.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 Date: Wed, 14 Dec 2011 19:20:20 -0400
\r
43 Message-ID: <874nx2kaff.fsf@zancas.localnet>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Wed, 14 Dec 2011 23:21:00 -0000
\r
61 On Thu, 15 Dec 2011 00:36:38 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
63 > I did not do a proper review. But I think the encoder and decoder
\r
64 > should accept and return the same type, either char* or unsigned char*.
\r
65 > The decision should be based on what type strings (that would be fed to
\r
66 > the encoder and decoder) have in notmuch code. I guess it is char*, so
\r
67 > the encoder and decoder should take and return char*. Internally we
\r
68 > would cast char* to unsigned char*.
\r
70 After staring at the draft C99 standard a bit, I'm inclined to agree. I
\r
71 think char is the generic, which to my horror is really either unsigned
\r
72 char or signed char is an implementation dependent way.
\r
74 The info I was missing was in the description of <string.h>
\r
77 | 3 For all functions in this subclause, each character shall be interpreted as if it had the type
\r
78 | unsigned char (and therefore every possible object representation is valid and has a
\r
82 I'll fix this in git, but I probably won't bother with another round of
\r