d5/4e01e6df2a42f20562fa2257aea77a16bb9e71

   1 Return-Path: <jani@nikula.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 583D2431FBC\r
   6         for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:21 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id VHApxB1r2lER for <notmuch@notmuchmail.org>;\r
  16         Tue, 28 Oct 2014 12:43:16 -0700 (PDT)\r
  17 Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com\r
  18  [74.125.82.53])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
  19  certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
  20  A1BB6431FB6    for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:16 -0700\r
  21  (PDT)\r
  22 Received: by mail-wg0-f53.google.com with SMTP id b13so274039wgh.40\r
  23         for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 12:43:15 -0700 (PDT)\r
  24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  25         d=1e100.net; s=20130820;\r
  26         h=x-gm-message-state:from:to:subject:in-reply-to:references\r
  27         :user-agent:date:message-id:mime-version:content-type;\r
  28         bh=S/fgXWs0ifvP5FChoiwDkjvs8LJEhWKkd4i7RSHWKJM=;\r
  29         b=CSHvUJtJKSfVsVi+jqNjokT/unk0HOYy7hPmuMuzxwphEkY7T55F28GbmIzJ40uZUW\r
  30         BcbpOpJkbqiGDiT6xTSMA04N0J1KtmDNS4UslI9xpkKKe2gKzjI5MZHhNr+tkcUBQ1ua\r
  31         jInhPV0JNaPwBYvmedphvvHdWSN5FKjsn31IcV6a+eI3AR7KRexx61In91KWNSeXBczn\r
  32         TbUOSJhkubX4sejB0/g/lqVMHBji9O6XpWpfK91qZ9QcVW+Hqa9m1QVJC/kcWF1/yXRu\r
  33         f4MMAcu2aawLEIs6K/nIMixSfW2plbb2c5xKXhB7LmRHxOaj10m9ANCheX9Rq3XJXSN6\r
  34         +Qsw==\r
  35 X-Gm-Message-State:\r
  36  ALoCoQk3V8XmsME4Wq3nRMxXoDB+c+Qo46a/WpQHyZ8y7rT6Eo13Zk8P92iTmR5WzJj9GjKMZJXQ\r
  37 X-Received: by 10.180.76.41 with SMTP id h9mr7490232wiw.40.1414525395324;\r
  38         Tue, 28 Oct 2014 12:43:15 -0700 (PDT)\r
  39 Received: from localhost (dsl-hkibrasgw2-58c36d-48.dhcp.inet.fi.\r
  40         [88.195.109.48])\r
  41         by mx.google.com with ESMTPSA id u13sm1755264wiv.10.2014.10.28.12.43.14\r
  42         for <multiple recipients>\r
  43         (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
  44         Tue, 28 Oct 2014 12:43:14 -0700 (PDT)\r
  45 From: Jani Nikula <jani@nikula.org>\r
  46 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
  47 Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test\r
  48 In-Reply-To: <87a94g2h7t.fsf@maritornes.cs.unb.ca>\r
  49 References: <1414518754-16344-1-git-send-email-jani@nikula.org>\r
  50         <87a94g2h7t.fsf@maritornes.cs.unb.ca>\r
  51 User-Agent: Notmuch/0.18.2+148~g4214adf (http://notmuchmail.org) Emacs/24.3.1\r
  52         (x86_64-pc-linux-gnu)\r
  53 Date: Tue, 28 Oct 2014 21:43:12 +0200\r
  54 Message-ID: <877fzk0ylr.fsf@nikula.org>\r
  55 MIME-Version: 1.0\r
  56 Content-Type: text/plain\r
  57 X-BeenThere: notmuch@notmuchmail.org\r
  58 X-Mailman-Version: 2.1.13\r
  59 Precedence: list\r
  60 List-Id: "Use and development of the notmuch mail system."\r
  61         <notmuch.notmuchmail.org>\r
  62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  63         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  65 List-Post: <mailto:notmuch@notmuchmail.org>\r
  66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  68         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  69 X-List-Received-Date: Tue, 28 Oct 2014 19:43:21 -0000\r
  70 \r
  71 On Tue, 28 Oct 2014, David Bremner <david@tethera.net> wrote:\r
  72 > Jani Nikula <jani@nikula.org> writes:\r
  73 >\r
  74 >> You need to actually check the return value. Limit the missing deps\r
  75 >> part to subtests requiring gdb.\r
  76 >\r
  77 > For me, on a system without gdb, the current version looks like\r
  78 >\r
  79 > T070-insert: Testing "notmuch insert"\r
  80 >  missing prerequisites: gdb(1)\r
  81 >  SKIP   all tests in T070-insert\r
  82 >\r
  83 > This seems OK to me?\r
  84 \r
  85 More than okay. /me hides.\r
  86 \r
  87 > Of course you're right that moving it forward to only skip the gdb\r
  88 > requiring tests is the right thing to do, and in that setting having a\r
  89 > skipped message for all 10 skipped tests is a bit ugly. OTOHO your\r
  90 > version doesn't give any output at all, which seems not perfect either.\r
  91 \r
  92 How does it work if you just move the prereq test forward?\r
  93 \r
  94 BR,\r
  95 Jani.\r