1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D7D21431FBC
\r
6 for <notmuch@notmuchmail.org>; Wed, 18 Jun 2014 14:11:38 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id c3n6P7RIOsLb for <notmuch@notmuchmail.org>;
\r
16 Wed, 18 Jun 2014 14:11:34 -0700 (PDT)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id D5FD6431FAE
\r
21 for <notmuch@notmuchmail.org>; Wed, 18 Jun 2014 14:11:33 -0700 (PDT)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1WxN8g-0004c6-NA; Wed, 18 Jun 2014 18:11:26 -0300
\r
25 Received: (nullmailer pid 5527 invoked by uid 1000); Wed, 18 Jun 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH 5/5] lib: Separate all phrases indexed by
\r
30 _notmuch_message_gen_terms
\r
31 In-Reply-To: <1402886434-16169-6-git-send-email-amdragon@mit.edu>
\r
32 References: <1402886434-16169-1-git-send-email-amdragon@mit.edu>
\r
33 <1402886434-16169-6-git-send-email-amdragon@mit.edu>
\r
34 User-Agent: Notmuch/0.18+13~g1adde01 (http://notmuchmail.org) Emacs/24.3.1
\r
35 (x86_64-pc-linux-gnu)
\r
36 Date: Wed, 18 Jun 2014 18:11:23 -0300
\r
37 Message-ID: <87fvj1gbyc.fsf@zancas.localnet>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Wed, 18 Jun 2014 21:11:39 -0000
\r
54 Austin Clements <amdragon@MIT.EDU> writes:
\r
56 > This adds a 100 termpos gap between all phrases indexed by
\r
57 > _notmuch_message_gen_terms. This fixes a bug where terms from the end
\r
58 > of one header and the beginning of another header could match together
\r
59 > in a single phrase and a separate bug where term positions of
\r
60 > un-prefixed terms overlapped.
\r
62 > This fix only affects newly indexed messages. Messages that are
\r
63 > already indexed won't benefit from this fix without re-indexing, but
\r
64 > the fix won't make things any worse for existing messages.
\r
66 The series looks OK to me. It took me a little while to understand the
\r
67 problem with multiple parts was that the term positions currently start
\r
68 from zero for each part. If you happen to be re-rolling the series for
\r
69 some other reason, maybe you could be more explicit about that. I
\r
70 wouldn't bother just for that though.
\r