1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3E8BE431E62
\r
6 for <notmuch@notmuchmail.org>; Tue, 20 Aug 2013 11:23:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id g3YuI9UG8Qv8 for <notmuch@notmuchmail.org>;
\r
17 Tue, 20 Aug 2013 11:23:40 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 2A293431FD6
\r
22 for <notmuch@notmuchmail.org>; Tue, 20 Aug 2013 11:23:39 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1VBqaT-0001uT-I2; Tue, 20 Aug 2013 19:23:28 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1VBqaT-0000CF-67; Tue, 20 Aug 2013 19:23:25 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
33 Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts
\r
35 In-Reply-To: <87fvu4fl25.fsf@servo.finestructure.net>
\r
36 References: <m3r4dtgz9k.fsf@zsu.kismala.com>
\r
37 <87fvu4fl25.fsf@servo.finestructure.net>
\r
38 User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1
\r
40 Date: Tue, 20 Aug 2013 19:23:24 +0100
\r
41 Message-ID: <87ob8ste5f.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 93.97.24.31
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: 26e0a99910db8cbecbf5593e343a339b (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: 0.0
\r
48 X-SpamAssassin-SpamBar: /
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored 0.0 points. Summary of the scoring:
\r
53 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
54 provider * (markwalters1009[at]gmail.com)
\r
55 * 0.0 AWL AWL: From: address is in the auto white-list
\r
56 X-QM-Scan-Virus: ClamAV says the message is clean
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Tue, 20 Aug 2013 18:23:48 -0000
\r
74 What does the (mis-behaving) part button say? is it [image/jpeg] or
\r
75 [application/octet-stream as image/jpeg] or? and what do correctly
\r
76 behaving part buttons say?
\r
82 Jameson Graef Rollins <jrollins@finestructure.net> writes:
\r
84 > On Fri, Aug 16 2013, Istvan Marko <notmuch@kismala.com> wrote:
\r
85 >> When text/html parts include images as multipart/related and the
\r
86 >> text/plain alternative is used these images can be completely hidden
\r
87 >> with no easy way to access them or even find out that they are there.
\r
89 >> Make notmuch-show-insert-part-multipart/related add buttons for all
\r
90 >> parts, the first one visible the rest hidden.
\r
92 > Hey, Istvan. Thanks so much for this patch. It seems to be addressing
\r
93 > the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net.
\r
95 > However, the behavior of the part button that now appears seems to be a
\r
96 > bit strange. Clicking/hitting enter on the part attempts to save it
\r
97 > rather than open it. I wouldn't be surprised if has nothing to do with
\r
98 > the correctness of this patch, though. So is it possible that the
\r
99 > button is not inserted in the most ideal way, or is there some other
\r
100 > issue preventing it from behaving properly (could it have to do with the
\r
101 > part being "inline"?)?
\r
106 >> emacs/notmuch-show.el | 4 ++++
\r
107 >> 1 file changed, 4 insertions(+)
\r
109 >> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
110 >> index 82b70ba..20844f0 100644
\r
111 >> --- a/emacs/notmuch-show.el
\r
112 >> +++ b/emacs/notmuch-show.el
\r
113 >> @@ -621,6 +621,10 @@ message at DEPTH in the current thread."
\r
115 >> ;; Render the primary part.
\r
116 >> (notmuch-show-insert-bodypart msg (car inner-parts) depth)
\r
117 >> + ;; Add hidden buttons for the rest
\r
118 >> + (mapc (lambda (inner-part)
\r
119 >> + (notmuch-show-insert-bodypart msg inner-part depth t))
\r
120 >> + (cdr inner-parts))
\r
122 >> (when notmuch-show-indent-multipart
\r
123 >> (indent-rigidly start (point) 1)))
\r
126 > _______________________________________________
\r
127 > notmuch mailing list
\r
128 > notmuch@notmuchmail.org
\r
129 > http://notmuchmail.org/mailman/listinfo/notmuch
\r