1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1C524431FC2
\r
6 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 04:30:59 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2Z4MaOXyC9d9 for <notmuch@notmuchmail.org>;
\r
16 Mon, 12 May 2014 04:30:51 -0700 (PDT)
\r
17 Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
\r
18 [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 92B5F431FC0
\r
21 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 04:30:51 -0700 (PDT)
\r
22 Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
\r
23 4.72) (envelope-from <david@tethera.net>)
\r
24 id 1WjoQI-0007LJ-Bt; Mon, 12 May 2014 11:29:34 +0000
\r
25 Received: (nullmailer pid 3745 invoked by uid 1000); Mon, 12 May 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h
\r
31 In-Reply-To: <87d2fjgtcr.fsf@maritornes.cs.unb.ca>
\r
32 References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>
\r
33 <87d2fjgtcr.fsf@maritornes.cs.unb.ca>
\r
34 User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1
\r
35 (x86_64-pc-linux-gnu)
\r
36 Date: Mon, 12 May 2014 20:29:09 +0900
\r
37 Message-ID: <877g5rgrqy.fsf@maritornes.cs.unb.ca>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Mon, 12 May 2014 11:30:59 -0000
\r
54 David Bremner <david@tethera.net> writes:
\r
56 > Charles Celerier <cceleri@cs.stanford.edu> writes:
\r
58 >> An underscore should precede every function name in
\r
59 >> lib/notmuch-private.h. This was not true and was noted by the failure of
\r
60 >> test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore
\r
61 >> before each function name in lib/notmuch-private.h where the underscore
\r
62 >> was missing and renames functions appropriately where they are used.
\r
64 > Originally I thought this was uneccesarily intrusive, but on a second
\r
65 > look I see that there is only one symbol changed that doesn't start with
\r
66 > _notmuch, so I guess for consistency it's fine.
\r
68 > I'm thinking about a 0.18.1 point release for build and portability
\r
69 > fixes; I do think this is a bit too much change for that (especially
\r
70 > since it doesn't actually fix the symbol hiding test (or more precisely,
\r
71 > your fix for OS/X breaks the linux test).
\r
73 Also, I'd like a less confusing commit message. Do you understand the
\r
74 situation enough to write one now? In particular it's just a convention
\r
75 that private symbols should not start with "notmuch", and the actual
\r
76 hiding happens elsewhere.
\r