1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id F132D429E5B
\r
6 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 06:20:11 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id eBue4EPYi6hg for <notmuch@notmuchmail.org>;
\r
17 Wed, 1 Feb 2012 06:20:11 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 30EC4431E64
\r
22 for <notmuch@notmuchmail.org>; Wed, 1 Feb 2012 06:20:11 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so1207256bke.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 06:20:09 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=o4sCw8BMqETJfFey8loJk4XilN3ARIxOx1kpv6KKwG4=;
\r
29 b=rhT/OFJzUTdSe10iXXPFo3Q8fPs7DGoLYzaLgjLazef07eYJT5+7/FIZnMum7INjvZ
\r
30 RXZN5qOVRdSNbAYzfWmKhfg3wEOKfEF+RYARcZe+wcqBRToG8T9vQ+2zolcKm7lBPo++
\r
31 q+evIN2O4hNvr5gsNa7iPJREtIUNvB2PbTJrY=
\r
32 Received: by 10.204.128.79 with SMTP id j15mr12567790bks.75.1328106009594;
\r
33 Wed, 01 Feb 2012 06:20:09 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id z15sm52122876bkd.7.2012.02.01.06.20.08
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Wed, 01 Feb 2012 06:20:08 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Pieter Praet <pieter@praet.org>, notmuch@notmuchmail.org
\r
40 Subject: Re: emacs: quote MML tags in replies
\r
41 In-Reply-To: <87vcnq64ra.fsf@praet.org>
\r
42 References: <1326998589-37187-1-git-send-email-aaronecay@gmail.com>
\r
43 <1328064581-13949-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <87vcnq64ra.fsf@praet.org>
\r
45 User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Wed, 01 Feb 2012 18:18:55 +0400
\r
48 Message-ID: <87d39ymyb4.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Wed, 01 Feb 2012 14:20:12 -0000
\r
65 On Wed, 01 Feb 2012 14:51:37 +0100, Pieter Praet <pieter@praet.org> wrote:
\r
66 > On Wed, 1 Feb 2012 06:49:39 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
69 > > Thanks for your work! I took the liberty to do some cleanups for your
\r
70 > > patch. Below is a detailed list of changes.
\r
73 > Thanks to the both of you!
\r
76 > > Hope this helps.
\r
78 > > Changes since v2:
\r
80 > > * change patch names to be consistent with others:
\r
82 > > - s/emacs:/test:/ for the test patch
\r
84 > > - lower case the first word after colon in the patch title
\r
86 > > * polish NEWS wording, move it to 0.12 section
\r
88 > > * add comment to `mml-quote-region' call, as suggested by Tomi [1]
\r
90 > > * fix and clean up the test:
\r
92 > > - set `notmuch-fcc-dirs' to nil to avoid adding the Fcc header,
\r
93 > > otherwise it breaks the test on other systems as pointed by
\r
97 > Could also have been avoided by adding the expected result inline,
\r
98 > and using "Fcc: $(pwd)/mail/sent". I'll send an updated patch to
\r
102 I do not understand how this is better. But please do not use $(pwd)
\r
103 here. I know that other tests do that in the same case, but it is
\r
104 wrong. There is $MAIL_DIR variable for this. See "notmuch-fcc-dirs set
\r
105 to a string" test for an example.
\r
111 > > - use default values for add_message parameters where possible
\r
113 > > - use a sane subject value in add_message
\r
115 > > - use shorter MML tag as produced by (mml-insert-part)
\r
117 > > - indenting and other minor cleanups
\r
122 > > [1] id:"m2wr89ioos.fsf@guru.guru-group.fi"
\r
123 > > [2] id:"87ehugzycb.fsf@zancas.localnet"
\r
125 > > _______________________________________________
\r
126 > > notmuch mailing list
\r
127 > > notmuch@notmuchmail.org
\r
128 > > http://notmuchmail.org/mailman/listinfo/notmuch
\r
130 > Despite my comment re Fcc, both LGTM.
\r