d1/a86886e16890c8604eb76af655fa149092ad33

   1 Return-Path: <jani@nikula.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1E607429E4F\r
   6         for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 05:01:50 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id eZVMEhBklc5G for <notmuch@notmuchmail.org>;\r
  16         Tue,  5 Nov 2013 05:01:42 -0800 (PST)\r
  17 Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com\r
  18  [74.125.82.42])        (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
  19  certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
  20  60656429E45    for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 05:01:42 -0800\r
  21  (PST)\r
  22 Received: by mail-wg0-f42.google.com with SMTP id n12so2973811wgh.5\r
  23         for <notmuch@notmuchmail.org>; Tue, 05 Nov 2013 05:01:40 -0800 (PST)\r
  24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  25         d=1e100.net; s=20130820;\r
  26         h=x-gm-message-state:from:to:cc:subject:in-reply-to:references\r
  27         :user-agent:date:message-id:mime-version:content-type;\r
  28         bh=c40WBy0qJUCJgWzCWwkl6XGaeJSO1htEbbAx0/qSLZw=;\r
  29         b=Ov8VAoAkKhVzyDMb7kmjZIT677eqThpZ11Ms/LLn33dTln6K5gpiIzsLDc4F9pmHQ8\r
  30         Poc1CJDSWQrFQEH6tQboeFH1sdIoBXQNmujNBBIWF+ss/SyRyUeCO7/sbSCzXtESFx+w\r
  31         xQ2GoYR2o4cvSWNaTiAXUzVzd6N7sQuC/5vLQD5EY0dzEnNoG7fEHZJKu2XE9q+Q8lrS\r
  32         oTgRiWYotBzP9k5kk0L3Do7hiL3tX0XHPtQm+CXIk82gvzh0rFpIShHMD9rBltGzk9Qi\r
  33         ZYdhwgZ0heaphcIWcHmCzIA2FiBXYdajbCyusgoi7e75iSBxjei4WlZWz+qH7rLI322E\r
  34         W2uQ==\r
  35 X-Gm-Message-State:\r
  36  ALoCoQnkggH5Y/43K9In1Oh65fxIFlOHZwfl98kYlRlY1n/dHbqmr9DbDju3RwR9dgCj/GEM5gyV\r
  37 X-Received: by 10.180.160.165 with SMTP id xl5mr15989336wib.48.1383650137413; \r
  38         Tue, 05 Nov 2013 03:15:37 -0800 (PST)\r
  39 Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])\r
  40         by mx.google.com with ESMTPSA id fu1sm13567130wib.8.2013.11.05.03.15.34\r
  41         for <multiple recipients>\r
  42         (version=TLSv1.1 cipher=RC4-SHA bits=128/128);\r
  43         Tue, 05 Nov 2013 03:15:36 -0800 (PST)\r
  44 From: Jani Nikula <jani@nikula.org>\r
  45 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
  46 Subject: Re: [PATCH v2 07/11] lib: use the compaction backup path provided by\r
  47         the caller\r
  48 In-Reply-To: <87ob5zqft7.fsf@zancas.localnet>\r
  49 References: <cover.1383481295.git.jani@nikula.org>\r
  50         <6e8053834c8ab856c2ebab881069f18b2badcf71.1383481295.git.jani@nikula.org>\r
  51         <87ob5zqft7.fsf@zancas.localnet>\r
  52 User-Agent: Notmuch/0.16+115~gd647c65 (http://notmuchmail.org) Emacs/23.2.1\r
  53         (x86_64-pc-linux-gnu)\r
  54 Date: Tue, 05 Nov 2013 12:15:19 +0100\r
  55 Message-ID: <87sivb9k1k.fsf@nikula.org>\r
  56 MIME-Version: 1.0\r
  57 Content-Type: text/plain; charset=us-ascii\r
  58 X-BeenThere: notmuch@notmuchmail.org\r
  59 X-Mailman-Version: 2.1.13\r
  60 Precedence: list\r
  61 List-Id: "Use and development of the notmuch mail system."\r
  62         <notmuch.notmuchmail.org>\r
  63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  64         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  66 List-Post: <mailto:notmuch@notmuchmail.org>\r
  67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  70 X-List-Received-Date: Tue, 05 Nov 2013 13:01:50 -0000\r
  71 \r
  72 On Tue, 05 Nov 2013, David Bremner <david@tethera.net> wrote:\r
  73 > Jani Nikula <jani@nikula.org> writes:\r
  74 >\r
  75 >> +    backup_path = talloc_asprintf (config, "%s/xapian.old", path);\r
  76 >> +    if (! backup_path)\r
  77 >> +    return 1;\r
  78 >> +\r
  79 >\r
  80 > Is it intentional that no message is printed here? A random glance at\r
  81 > notmuch-search.c suggests we usually print a message on OOM in the CLI.\r
  82 \r
  83 Oversight.\r
  84 \r
  85 Jani.\r