1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A6BB0431FD0
\r
6 for <notmuch@notmuchmail.org>; Mon, 4 Jul 2011 01:55:28 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id J76t8G3Ux4Oj for <notmuch@notmuchmail.org>;
\r
16 Mon, 4 Jul 2011 01:55:27 -0700 (PDT)
\r
17 Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 62070431FB6
\r
21 for <notmuch@notmuchmail.org>; Mon, 4 Jul 2011 01:55:27 -0700 (PDT)
\r
22 Received: by wyh22 with SMTP id 22so3798848wyh.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 04 Jul 2011 01:55:26 -0700 (PDT)
\r
24 Received: by 10.216.235.33 with SMTP id t33mr5042192weq.6.1309769724452;
\r
25 Mon, 04 Jul 2011 01:55:24 -0700 (PDT)
\r
26 Received: from localhost ([109.131.160.67])
\r
27 by mx.google.com with ESMTPS id g2sm2922571weg.38.2011.07.04.01.55.22
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Mon, 04 Jul 2011 01:55:23 -0700 (PDT)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH v2] emacs: add insisible space after the search widget
\r
33 field in notmuch-hello
\r
34 In-Reply-To: <1309768024-14584-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
35 References: <id:1309762025-1172-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
36 <1309768024-14584-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
37 User-Agent: Notmuch/0.5-326-ga5de9f3 (http://notmuchmail.org) Emacs/23.1.50.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Mon, 04 Jul 2011 10:55:21 +0200
\r
40 Message-ID: <8762nifmrq.fsf@praet.org>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Mon, 04 Jul 2011 08:55:28 -0000
\r
57 On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
58 > It is very convenient when C-e (bound to `widget-end-of-line') ignores
\r
59 > trailing spaces inside the search widget. But it only does so if a
\r
60 > widget is not followed by a newline (that is why it works in the saved
\r
61 > search widgets). The patch just adds an insisible space after the
\r
62 > search widget to get the desirable behavior of `widget-end-of-line'.
\r
64 > Previous behavior of C-e:
\r
72 > The extra space is also added to expected results of emacs tests.
\r
75 > Amended version with a better commit message. Stolen from a similar
\r
76 > patch by Kan-Ru Chen [1] as suggested by Pieter Praet :)
\r
83 > [1] id:"1280195325-9066-2-git-send-email-kanru@kanru.info"
\r
85 > emacs/notmuch-hello.el | 4 ++++
\r
86 > test/emacs.expected-output/notmuch-hello | 2 +-
\r
87 > .../notmuch-hello-no-saved-searches | 2 +-
\r
88 > .../emacs.expected-output/notmuch-hello-with-empty | 2 +-
\r
89 > 4 files changed, 7 insertions(+), 3 deletions(-)
\r
91 > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
92 > index 65fde75..1a76c30 100644
\r
93 > --- a/emacs/notmuch-hello.el
\r
94 > +++ b/emacs/notmuch-hello.el
\r
95 > @@ -462,6 +462,10 @@ Complete list of currently available key bindings:
\r
96 > (length "Search: ")))
\r
97 > :action (lambda (widget &rest ignore)
\r
98 > (notmuch-hello-search (widget-value widget))))
\r
99 > + ;; add an invisible space to make `widget-end-of-line' ignore
\r
100 > + ;; trailine spaces in the search widget field
\r
101 > + (widget-insert " ")
\r
102 > + (put-text-property (1- (point)) (point) 'invisible t)
\r
103 > (widget-insert "\n")
\r
105 > (when notmuch-hello-recent-searches
\r
106 > diff --git a/test/emacs.expected-output/notmuch-hello b/test/emacs.expected-output/notmuch-hello
\r
107 > index 64b7e42..48143bd 100644
\r
108 > --- a/test/emacs.expected-output/notmuch-hello
\r
109 > +++ b/test/emacs.expected-output/notmuch-hello
\r
110 > @@ -4,7 +4,7 @@ Saved searches: [edit]
\r
112 > 50 inbox 50 unread
\r
119 > diff --git a/test/emacs.expected-output/notmuch-hello-no-saved-searches b/test/emacs.expected-output/notmuch-hello-no-saved-searches
\r
120 > index 7f8206a..7c09e40 100644
\r
121 > --- a/test/emacs.expected-output/notmuch-hello-no-saved-searches
\r
122 > +++ b/test/emacs.expected-output/notmuch-hello-no-saved-searches
\r
124 > Welcome to notmuch. You have 50 messages.
\r
131 > diff --git a/test/emacs.expected-output/notmuch-hello-with-empty b/test/emacs.expected-output/notmuch-hello-with-empty
\r
132 > index a9ed630..2a267c9 100644
\r
133 > --- a/test/emacs.expected-output/notmuch-hello-with-empty
\r
134 > +++ b/test/emacs.expected-output/notmuch-hello-with-empty
\r
135 > @@ -4,7 +4,7 @@ Saved searches: [edit]
\r
137 > 50 inbox 50 unread 0 empty
\r
147 > _______________________________________________
\r
148 > notmuch mailing list
\r
149 > notmuch@notmuchmail.org
\r
150 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
152 Signed-off-by: Pieter Praet <pieter@praet.org>
\r
155 Would this be the right place to promote two of your previous patches [1,2] ?
\r
157 They serve as ears when using eye protection against `show-trailing-whitespace'.
\r
165 [1] id:"1278000507-22290-5-git-send-email-dmitry.kurochkin@gmail.com"
\r
166 [2] id:"1278000507-22290-6-git-send-email-dmitry.kurochkin@gmail.com"
\r