1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C7874409F24
\r
6 for <notmuch@notmuchmail.org>; Fri, 6 Jan 2012 23:31:38 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ljgEtkjvzolL for <notmuch@notmuchmail.org>;
\r
16 Fri, 6 Jan 2012 23:31:38 -0800 (PST)
\r
17 Received: from mail-pz0-f53.google.com (mail-pz0-f53.google.com
\r
18 [209.85.210.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 05B80409F22
\r
21 for <notmuch@notmuchmail.org>; Fri, 6 Jan 2012 23:31:37 -0800 (PST)
\r
22 Received: by dady9 with SMTP id y9so3170649dad.26
\r
23 for <notmuch@notmuchmail.org>; Fri, 06 Jan 2012 23:31:36 -0800 (PST)
\r
25 Received: by 10.68.74.10 with SMTP id p10mr21813949pbv.3.1325921495682; Fri,
\r
26 06 Jan 2012 23:31:35 -0800 (PST)
\r
27 Received: by 10.68.58.7 with HTTP; Fri, 6 Jan 2012 23:31:35 -0800 (PST)
\r
28 Received: by 10.68.58.7 with HTTP; Fri, 6 Jan 2012 23:31:35 -0800 (PST)
\r
29 In-Reply-To: <87sjjsjhjk.fsf@zancas.localnet>
\r
30 References: <cover.1325794371.git.jani@nikula.org>
\r
31 <974a2ef1f1df7d93e0b5bd642ca8a49f8b727a86.1325794371.git.jani@nikula.org>
\r
32 <87sjjsjhjk.fsf@zancas.localnet>
\r
33 Date: Sat, 7 Jan 2012 09:31:35 +0200
\r
35 <CAB+hUn9cWzDYK7ZvKWvsU=cCNuU80ERR8gT+T_Tu=SfMXH7K5A@mail.gmail.com>
\r
36 Subject: Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch
\r
38 From: Jani Nikula <jani@nikula.org>
\r
39 To: David Bremner <david@tethera.net>
\r
40 Content-Type: multipart/alternative; boundary=f46d04138ecdc00d7104b5eb277e
\r
41 Cc: notmuch@notmuchmail.org
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Sat, 07 Jan 2012 07:31:39 -0000
\r
56 --f46d04138ecdc00d7104b5eb277e
\r
57 Content-Type: text/plain; charset=UTF-8
\r
59 On Jan 7, 2012 5:52 AM, "David Bremner" <david@tethera.net> wrote:
\r
61 > On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
62 > > notmuch_show_params_t params is only initialized partially in
\r
63 > > notmuch_reply_command(). The only field that is used uninitialized is
\r
64 > > params.decrypt. It is usually non-zero, making "notmuch reply" on
\r
66 > > messages work by coincidence.
\r
70 > I get one test failure with this patch on current master:
\r
72 Can't investigate right now, but did you try with just patch 1/4? (I really
\r
73 should have separated the bug fix from the rest.)
\r
78 > FAIL Reply within emacs
\r
79 > --- emacs.24.expected 2012-01-07 03:47:50.000000000 +0000
\r
80 > +++ emacs.24.output 2012-01-07 03:47:50.000000000 +0000
\r
82 > From: Notmuch Test Suite <test_suite@notmuchmail.org>
\r
83 > -To: user@example.com
\r
85 > Subject: Re: Testing message sent via SMTP
\r
86 > In-Reply-To: <XXX>
\r
87 > Fcc: /tmp/notmuch-dev-bremner/test/tmp.emacs/mail/sent
\r
91 --f46d04138ecdc00d7104b5eb277e
\r
92 Content-Type: text/html; charset=UTF-8
\r
93 Content-Transfer-Encoding: quoted-printable
\r
96 On Jan 7, 2012 5:52 AM, "David Bremner" <<a href=3D"mailto:dav=
\r
97 id@tethera.net">david@tethera.net</a>> wrote:<br>
\r
99 > On Thu, =C2=A05 Jan 2012 22:25:12 +0200, Jani Nikula <<a href=3D"ma=
\r
100 ilto:jani@nikula.org">jani@nikula.org</a>> wrote:<br>
\r
101 > > notmuch_show_params_t params is only initialized partially in<br>
\r
102 > > notmuch_reply_command(). The only field that is used uninitialize=
\r
104 > > params.decrypt. It is usually non-zero, making "notmuch repl=
\r
105 y" on encrypted<br>
\r
106 > > messages work by coincidence.<br>
\r
110 > I get one test failure with this patch on current master:</p>
\r
111 <p>Can't investigate right now, but did you try with just patch 1/4? (I=
\r
112 really should have separated the bug fix from the rest.)</p>
\r
115 > =C2=A0FAIL =C2=A0 Reply within emacs<br>
\r
116 > =C2=A0 =C2=A0 =C2=A0 =C2=A0--- emacs.24.expected =C2=A0 2012-01-07 03:=
\r
117 47:50.000000000 +0000<br>
\r
118 > =C2=A0 =C2=A0 =C2=A0 =C2=A0+++ emacs.24.output =C2=A0 =C2=A0 2012-01-0=
\r
119 7 03:47:50.000000000 +0000<br>
\r
120 > =C2=A0 =C2=A0 =C2=A0 =C2=A0@@ -1,5 +1,5 @@<br>
\r
121 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 From: Notmuch Test Suite <<a href=3D"ma=
\r
122 ilto:test_suite@notmuchmail.org">test_suite@notmuchmail.org</a>><br>
\r
123 > =C2=A0 =C2=A0 =C2=A0 =C2=A0-To: <a href=3D"mailto:user@example.com">us=
\r
124 er@example.com</a><br>
\r
125 > =C2=A0 =C2=A0 =C2=A0 =C2=A0+To:<br>
\r
126 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 Subject: Re: Testing message sent via SMTP=
\r
128 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 In-Reply-To: <XXX><br>
\r
129 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 Fcc: /tmp/notmuch-dev-bremner/test/tmp.ema=
\r
135 --f46d04138ecdc00d7104b5eb277e--
\r