1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 17AFF431FC2
\r
6 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 03:56:17 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id hfUkIZz6dFtc for <notmuch@notmuchmail.org>;
\r
16 Mon, 12 May 2014 03:56:09 -0700 (PDT)
\r
17 Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
\r
18 [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 1210C431FC0
\r
21 for <notmuch@notmuchmail.org>; Mon, 12 May 2014 03:56:09 -0700 (PDT)
\r
22 Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
\r
23 4.72) (envelope-from <david@tethera.net>)
\r
24 id 1Wjnsd-0007DY-NO; Mon, 12 May 2014 10:54:47 +0000
\r
25 Received: (nullmailer pid 27461 invoked by uid 1000); Mon, 12 May 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h
\r
31 In-Reply-To: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>
\r
32 References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>
\r
33 User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Mon, 12 May 2014 19:54:28 +0900
\r
36 Message-ID: <87d2fjgtcr.fsf@maritornes.cs.unb.ca>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Mon, 12 May 2014 10:56:17 -0000
\r
53 Charles Celerier <cceleri@cs.stanford.edu> writes:
\r
55 > An underscore should precede every function name in
\r
56 > lib/notmuch-private.h. This was not true and was noted by the failure of
\r
57 > test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore
\r
58 > before each function name in lib/notmuch-private.h where the underscore
\r
59 > was missing and renames functions appropriately where they are used.
\r
61 Originally I thought this was uneccesarily intrusive, but on a second
\r
62 look I see that there is only one symbol changed that doesn't start with
\r
63 _notmuch, so I guess for consistency it's fine.
\r
65 I'm thinking about a 0.18.1 point release for build and portability
\r
66 fixes; I do think this is a bit too much change for that (especially
\r
67 since it doesn't actually fix the symbol hiding test (or more precisely,
\r
68 your fix for OS/X breaks the linux test).
\r