1 Return-Path: <teythoon@jade-hamburg.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D7B46431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 13 May 2012 14:52:55 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Xrgk+Y+YazXb for <notmuch@notmuchmail.org>;
\r
16 Sun, 13 May 2012 14:52:54 -0700 (PDT)
\r
17 Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])
\r
18 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id DEAB3431FAE
\r
21 for <notmuch@notmuchmail.org>; Sun, 13 May 2012 14:52:53 -0700 (PDT)
\r
22 Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])
\r
23 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
24 (No client certificate requested)
\r
25 by mail.cryptobitch.de (Postfix) with ESMTPSA id DA725587D9F
\r
26 for <notmuch@notmuchmail.org>; Sun, 13 May 2012 23:52:51 +0200 (CEST)
\r
27 Received: by mail.jade-hamburg.de (Postfix, from userid 401)
\r
28 id 5AFBEDF2A3; Sun, 13 May 2012 23:52:51 +0200 (CEST)
\r
29 Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de
\r
30 [10.1.1.153]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client
\r
31 certificate requested) (Authenticated sender: teythoon) by
\r
32 mail.jade-hamburg.de (Postfix) with ESMTPSA id 608E9DF2A0; Sun, 13 May 2012
\r
33 23:52:39 +0200 (CEST)
\r
34 Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)
\r
35 (envelope-from <teythoon@thinkbox.jade-hamburg.de>)
\r
36 id 1STghT-0004Ff-7V; Sun, 13 May 2012 23:51:35 +0200
\r
37 Content-Type: text/plain; charset="utf-8"
\r
39 Content-Transfer-Encoding: quoted-printable
\r
40 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
41 From: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
42 In-Reply-To: <1336939029-13969-3-git-send-email-amdragon@mit.edu>
\r
43 References: <1336939029-13969-1-git-send-email-amdragon@mit.edu>
\r
44 <1336939029-13969-3-git-send-email-amdragon@mit.edu>
\r
45 Message-ID: <20120513215135.15106.40581@thinkbox.jade-hamburg.de>
\r
46 User-Agent: alot/0.3+
\r
47 Subject: Re: [PATCH 2/5] go: Update for changes to
\r
48 notmuch_database_get_directory
\r
49 Date: Sun, 13 May 2012 23:51:35 +0200
\r
50 Cc: tomi.ollila@iki.fi
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Sun, 13 May 2012 21:52:56 -0000
\r
67 thanks for taking care of this.
\r
69 Quoting Austin Clements (2012-05-13 21:57:06)
\r
71 > bindings/go/src/notmuch/notmuch.go | 13 +++++++------
\r
72 > bindings/python/notmuch/database.py | 4 ++--
\r
74 A change to the python bindings slipped into this one.
\r
76 Other than that this looks good.
\r
78 I just saw that I marked another function as problematic,
\r
79 notmuch_database_find_message_by_filename ends up calling
\r
80 _notmuch_directory_create that aborts if the database is not
\r
81 writable. But this might have to wait and might not even requira an
\r