1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D4AE2431FBF
\r
6 for <notmuch@notmuchmail.org>; Thu, 8 May 2014 08:36:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id FeaAFMbtrAkZ for <notmuch@notmuchmail.org>;
\r
16 Thu, 8 May 2014 08:36:36 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 8E528431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 8 May 2014 08:36:36 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 1683F1000E5;
\r
22 Thu, 8 May 2014 18:36:29 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] notmuch-dump: use fsync instead of fdatasync
\r
26 In-Reply-To: <1399550227-18488-1-git-send-email-david@tethera.net>
\r
27 References: <20140507171835.GA27619@mit.edu>
\r
28 <1399550227-18488-1-git-send-email-david@tethera.net>
\r
29 User-Agent: Notmuch/0.18+11~gbc95cc5 (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Thu, 08 May 2014 18:36:28 +0300
\r
35 Message-ID: <m2r444wadf.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Thu, 08 May 2014 15:36:41 -0000
\r
52 On Thu, May 08 2014, David Bremner <david@tethera.net> wrote:
\r
54 > Since the file size will have changed, there is no performance benefit
\r
55 > to calling fdatasync. Somewhat surprisingly, using fdatasync
\r
56 > apparently causes portability problems on FreeBSD.
\r
59 Well, this is easy to review! LGTM.
\r
64 > notmuch-dump.c | 2 +-
\r
65 > 1 file changed, 1 insertion(+), 1 deletion(-)
\r
67 > diff --git a/notmuch-dump.c b/notmuch-dump.c
\r
68 > index 2849eab..887a208 100644
\r
69 > --- a/notmuch-dump.c
\r
70 > +++ b/notmuch-dump.c
\r
71 > @@ -169,7 +169,7 @@ notmuch_database_dump (notmuch_database_t *notmuch,
\r
74 > if (output_file_name) {
\r
75 > - ret = fdatasync (outfd);
\r
76 > + ret = fsync (outfd);
\r
78 > fprintf (stderr, "Error syncing %s to disk: %s\n",
\r
79 > name_for_error, strerror (errno));
\r